From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 3F4131B00B; Mon, 8 Jan 2018 07:43:52 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jan 2018 22:43:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,329,1511856000"; d="scan'208";a="19096892" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 07 Jan 2018 22:43:50 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 7 Jan 2018 22:43:50 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 7 Jan 2018 22:43:49 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0319.002; Mon, 8 Jan 2018 14:43:48 +0800 From: "Zhang, Helin" To: "Xing, Beilei" , Olivier Matz , "dev@dpdk.org" , "Wu, Jingjing" CC: "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] net/i40e: fix setting of MAC address on i40evf Thread-Index: AQHThJenvml0LKWZCkCcdtbJ0OjFeKNjVQCAgAY5seA= Date: Mon, 8 Jan 2018 06:43:47 +0000 Message-ID: References: <20171214171531.10506-1-olivier.matz@6wind.com> <20180103133418.494-1-olivier.matz@6wind.com> <94479800C636CB44BD422CB454846E0132087449@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <94479800C636CB44BD422CB454846E0132087449@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix setting of MAC address on i40evf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jan 2018 06:43:52 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xing, Beilei > Sent: Thursday, January 4, 2018 3:40 PM > To: Olivier Matz; dev@dpdk.org; Wu, Jingjing > Cc: stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix setting of MAC address o= n > i40evf >=20 >=20 > > -----Original Message----- > > From: Olivier Matz [mailto:olivier.matz@6wind.com] > > Sent: Wednesday, January 3, 2018 9:34 PM > > To: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > > > > Cc: stable@dpdk.org > > Subject: [PATCH v2] net/i40e: fix setting of MAC address on i40evf > > > > When setting the MAC address, the ethdev layer copies the new mac > > address in dev->data->mac_addrs[0] before calling the dev_ops. > > > > Therefore, "is_same_ether_addr(mac_addr, dev->data->mac_addrs)" was > > always true, and the MAC was never set. Remove this test to fix the iss= ue. > > > > Fixes: 943c2d899a0c ("net/i40e: set VF MAC from VF") > > Cc: stable@dpdk.org > > > > Signed-off-by: Olivier Matz >=20 > Acked-by: Beilei Xing , thanks for the fix. Applied to dpdk-next-net-intel, thanks! /Helin