From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id B00FE1B161; Tue, 9 Jan 2018 08:34:15 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2018 23:34:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,334,1511856000"; d="scan'208";a="191757490" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 08 Jan 2018 23:34:13 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 8 Jan 2018 23:34:13 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 8 Jan 2018 23:34:13 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Tue, 9 Jan 2018 15:34:11 +0800 From: "Zhang, Helin" To: "Zhang, Qi Z" , "Xing, Beilei" , "Wu, Jingjing" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: fix FDIR rule confiliction issue Thread-Index: AQHTaaV/gExNy3GpYUSiQPDrOY98TKNOtBhwgByw/sA= Date: Tue, 9 Jan 2018 07:34:10 +0000 Message-ID: References: <1512023768-53485-1-git-send-email-beilei.xing@intel.com> <039ED4275CED7440929022BC67E7061153123D37@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061153123D37@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix FDIR rule confiliction issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 07:34:16 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Friday, December 22, 2017 9:27 AM > To: Xing, Beilei; Wu, Jingjing > Cc: dev@dpdk.org; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix FDIR rule confiliction issu= e >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing > > Sent: Thursday, November 30, 2017 2:36 PM > > To: Wu, Jingjing > > Cc: dev@dpdk.org; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH] net/i40e: fix FDIR rule confiliction issue > > > > Failed to create two FDIR rules with different vlan id for the same PCT= YPE. > > Root cause is that wrong hash key length is used. > > > > Fixes: 4149825bbdb9 ("net/i40e: finish integration FDIR with generic > > flow > > API") > > Cc: stable@dpdk.org > > > > Signed-off-by: Beilei Xing > > --- > > drivers/net/i40e/i40e_ethdev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > b/drivers/net/i40e/i40e_ethdev.c index 811cc9f..583f100 100644 > > --- a/drivers/net/i40e/i40e_ethdev.c > > +++ b/drivers/net/i40e/i40e_ethdev.c > > @@ -1006,7 +1006,7 @@ i40e_init_fdir_filter_list(struct rte_eth_dev *de= v) > > struct rte_hash_parameters fdir_hash_params =3D { > > .name =3D fdir_hash_name, > > .entries =3D I40E_MAX_FDIR_FILTER_NUM, > > - .key_len =3D sizeof(struct rte_eth_fdir_input), > > + .key_len =3D sizeof(struct i40e_fdir_input), > > .hash_func =3D rte_hash_crc, > > .hash_func_init_val =3D 0, > > .socket_id =3D rte_socket_id(), > > -- > > 2.5.5 >=20 > Acked-by: Qi Zhang Applied to dpdk-next-net-intel, thanks! /Helin