DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Helin" <helin.zhang@intel.com>
To: "Rybalchenko, Kirill" <kirill.rybalchenko@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Rybalchenko, Kirill" <kirill.rybalchenko@intel.com>,
	"Chilikin, Andrey" <andrey.chilikin@intel.com>,
	"Xing, Beilei" <beilei.xing@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: do not turn on flexible payload on	driver init
Date: Tue, 9 Jan 2018 16:06:32 +0000	[thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E71ACEDAA2@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1515512214-2971-1-git-send-email-kirill.rybalchenko@intel.com>



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Kirill Rybalchenko
> Sent: Tuesday, January 9, 2018 11:37 PM
> To: dev@dpdk.org
> Cc: Rybalchenko, Kirill; Chilikin, Andrey; Xing, Beilei; Wu, Jingjing
> Subject: [dpdk-dev] [PATCH v3] net/i40e: do not turn on flexible payload on
> driver init
> 
> Function i40e_GLQF_reg_init() overwrites global register for flexible payload,
> forcing extraction of first 16 bytes of
> L2/L3/L4 payload to the field vector even if flexible payload is not used by an
> application. Such unconditional turn on of flexible payload effectively disables
> ability to use outer IP Destination address for RSS/FDIR for tunnelled packets,
> as flexible payload overwrites outer IP destination address on the field vector.
> 
> Now flexible payload turned on only when flow director is enabled and
> configured.
> 
> v1:
> Global registers will be set only when payload is enabled.
> They will be reset if payload is disabled or on port reset (uninit).
> 
> v2:
> dev_init and dev_close disable flexible payload by default.
> Flexible payload enabled selectively, only if appropriate PIT is set up. The same
> done for FDIR and for rte_flow API.
> 
> v3:
> Minor fix in comments.
> 
> Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
Applied to dpdk-next-net-intel, with minor commit log changes.

/Helin

      reply	other threads:[~2018-01-09 16:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29 12:55 [dpdk-dev] [PATCH] " Kirill Rybalchenko
2017-11-30  9:17 ` Xing, Beilei
2017-12-01 15:27 ` Kirill Rybalchenko
2017-12-11  6:00   ` Xing, Beilei
2017-12-12  3:40     ` Xing, Beilei
2018-01-04 17:45   ` [dpdk-dev] [PATCH v2] " Kirill Rybalchenko
2018-01-08  5:41     ` Xing, Beilei
2018-01-09 15:28       ` Zhang, Helin
2018-01-09 15:36     ` [dpdk-dev] [PATCH v3] " Kirill Rybalchenko
2018-01-09 16:06       ` Zhang, Helin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E71ACEDAA2@SHSMSX103.ccr.corp.intel.com \
    --to=helin.zhang@intel.com \
    --cc=andrey.chilikin@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=kirill.rybalchenko@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).