From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 6A7A81B1C4 for ; Tue, 9 Jan 2018 17:06:36 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2018 08:06:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,336,1511856000"; d="scan'208";a="8472457" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga008.fm.intel.com with ESMTP; 09 Jan 2018 08:06:35 -0800 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Jan 2018 08:06:35 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Jan 2018 08:06:34 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Wed, 10 Jan 2018 00:06:33 +0800 From: "Zhang, Helin" To: "Rybalchenko, Kirill" , "dev@dpdk.org" CC: "Rybalchenko, Kirill" , "Chilikin, Andrey" , "Xing, Beilei" , "Wu, Jingjing" Thread-Topic: [dpdk-dev] [PATCH v3] net/i40e: do not turn on flexible payload on driver init Thread-Index: AQHTiV/OzxEptSROd0OI7Wq8wl8NyKNrtLpw Date: Tue, 9 Jan 2018 16:06:32 +0000 Message-ID: References: <1515087906-2893-1-git-send-email-kirill.rybalchenko@intel.com> <1515512214-2971-1-git-send-email-kirill.rybalchenko@intel.com> In-Reply-To: <1515512214-2971-1-git-send-email-kirill.rybalchenko@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: do not turn on flexible payload on driver init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 16:06:36 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Kirill Rybalchenko > Sent: Tuesday, January 9, 2018 11:37 PM > To: dev@dpdk.org > Cc: Rybalchenko, Kirill; Chilikin, Andrey; Xing, Beilei; Wu, Jingjing > Subject: [dpdk-dev] [PATCH v3] net/i40e: do not turn on flexible payload = on > driver init >=20 > Function i40e_GLQF_reg_init() overwrites global register for flexible pay= load, > forcing extraction of first 16 bytes of > L2/L3/L4 payload to the field vector even if flexible payload is not used= by an > application. Such unconditional turn on of flexible payload effectively d= isables > ability to use outer IP Destination address for RSS/FDIR for tunnelled pa= ckets, > as flexible payload overwrites outer IP destination address on the field = vector. >=20 > Now flexible payload turned on only when flow director is enabled and > configured. >=20 > v1: > Global registers will be set only when payload is enabled. > They will be reset if payload is disabled or on port reset (uninit). >=20 > v2: > dev_init and dev_close disable flexible payload by default. > Flexible payload enabled selectively, only if appropriate PIT is set up. = The same > done for FDIR and for rte_flow API. >=20 > v3: > Minor fix in comments. >=20 > Signed-off-by: Kirill Rybalchenko Applied to dpdk-next-net-intel, with minor commit log changes. /Helin