From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id D7D381B01D for ; Wed, 10 Jan 2018 03:23:31 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2018 18:23:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,337,1511856000"; d="scan'208";a="25916450" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 09 Jan 2018 18:23:30 -0800 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Jan 2018 18:23:30 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Jan 2018 18:23:29 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Wed, 10 Jan 2018 10:23:27 +0800 From: "Zhang, Helin" To: "Ananyev, Konstantin" , "Wu, Yanglong" , "dev@dpdk.org" Thread-Topic: [PATCH v6] net/ixgbe: fix tx_q check failed on PF Thread-Index: AQHTibXYOcejgQN0V0qDdc1e9X3bX6Nr0zQAgACNOuA= Date: Wed, 10 Jan 2018 02:23:27 +0000 Message-ID: References: <20180108030601.5622-1-yanglong.wu@intel.com> <20180110015136.7245-1-yanglong.wu@intel.com> <2601191342CEEE43887BDE71AB97725880E3B1C0@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB97725880E3B1C0@irsmsx105.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6] net/ixgbe: fix tx_q check failed on PF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 02:23:32 -0000 > -----Original Message----- > From: Ananyev, Konstantin > Sent: Wednesday, January 10, 2018 9:57 AM > To: Wu, Yanglong; dev@dpdk.org; Zhang, Helin > Subject: RE: [PATCH v6] net/ixgbe: fix tx_q check failed on PF >=20 >=20 >=20 > > -----Original Message----- > > From: Wu, Yanglong > > Sent: Wednesday, January 10, 2018 1:52 AM > > To: dev@dpdk.org; Ananyev, Konstantin ; > > Zhang, Helin > > Cc: Wu, Yanglong > > Subject: [PATCH v6] net/ixgbe: fix tx_q check failed on PF > > > > Tx_q check failed on PF that occurred when the SRIOV is active and > > tx_q > rx_q. The tx_q is equal to nb_q_per_pool. The number of > > nb_q_per_pool should equeal to max number of queues supported by HW > > not nb_rx_q. > > > > Fixes: 27b609cbd1c6 (ethdev: move the multi-queue mode check to > > specific drivers) > > > > Signed-off-by: Yanglong Wu > > --- > > v5: > > Rework according to comments > > --- > > v6: > > rework commit log > > --- > > drivers/net/ixgbe/ixgbe_ethdev.c | 10 +++++++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > > b/drivers/net/ixgbe/ixgbe_ethdev.c > > index ff19a564a..baaeee5d9 100644 > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > @@ -95,6 +95,9 @@ > > /* Timer value included in XOFF frames. */ #define IXGBE_FC_PAUSE > > 0x680 > > > > +/*Default value of Max Rx Queue*/ > > +#define IXGBE_MAX_RX_QUEUE_NUM 128 > > + > > #define IXGBE_LINK_DOWN_CHECK_TIMEOUT 4000 /* ms */ > > #define IXGBE_LINK_UP_CHECK_TIMEOUT 1000 /* ms */ > > #define IXGBE_VMDQ_NUM_UC_MAC 4096 /* Maximum nb. of UC > MAC addr. */ > > @@ -2194,9 +2197,10 @@ ixgbe_check_vf_rss_rxq_num(struct rte_eth_dev > *dev, uint16_t nb_rx_q) > > return -EINVAL; > > } > > > > - RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool =3D nb_rx_q; > > - RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx =3D pci_dev->max_vfs * > nb_rx_q; > > - > > + RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool =3D > > + IXGBE_MAX_RX_QUEUE_NUM / > RTE_ETH_DEV_SRIOV(dev).active; > > + RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx =3D > > + pci_dev->max_vfs * RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool; > > return 0; > > } > > > > -- >=20 > Acked-by: Konstantin Ananyev Applied to dpdk-next-net-intel, with commit log changes. Thanks! /Helin >=20 > > 2.11.0