From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 5571B2BC8 for ; Sat, 13 Jan 2018 06:55:53 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jan 2018 21:55:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,351,1511856000"; d="scan'208";a="21314747" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 12 Jan 2018 21:55:52 -0800 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 12 Jan 2018 21:55:52 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 12 Jan 2018 21:55:51 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Sat, 13 Jan 2018 13:55:49 +0800 From: "Zhang, Helin" To: "Zhang, Qi Z" , "Zhao1, Wei" , "dev@dpdk.org" CC: "Yigit, Ferruh" Thread-Topic: [PATCH] net/i40e: add break case in flow API Thread-Index: AQHTi3FTFcvl8BxWqEOclHUu+JCL/qNxT1iw Date: Sat, 13 Jan 2018 05:55:49 +0000 Message-ID: References: <20180112061332.63874-1-wei.zhao1@intel.com> <039ED4275CED7440929022BC67E706115312BB6B@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E706115312BB6B@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: add break case in flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jan 2018 05:55:53 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Friday, January 12, 2018 2:48 PM > To: Zhao1, Wei; dev@dpdk.org > Cc: Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH] net/i40e: add break case in flow API >=20 >=20 >=20 > > -----Original Message----- > > From: Zhao1, Wei > > Sent: Friday, January 12, 2018 2:14 PM > > To: dev@dpdk.org > > Cc: Zhang, Qi Z ; Yigit, Ferruh > > ; Zhao1, Wei > > Subject: [PATCH] net/i40e: add break case in flow API > > > > This bug may cause build error when there is no break case code, so add= it. > > > > Fixes: accf70b2ae64e ("net/i40e: move RSS to flow API") > > > > Signed-off-by: Wei Zhao > > --- > > drivers/net/i40e/i40e_flow.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/i40e/i40e_flow.c > > b/drivers/net/i40e/i40e_flow.c index > > 6106f78..cd9a9b6 100644 > > --- a/drivers/net/i40e/i40e_flow.c > > +++ b/drivers/net/i40e/i40e_flow.c > > @@ -4600,6 +4600,7 @@ i40e_flow_destroy(struct rte_eth_dev *dev, > > case RTE_ETH_FILTER_HASH: > > ret =3D i40e_config_rss_filter_del(dev, > > (struct i40e_rte_flow_rss_conf *)flow->rule); > > + break; > > default: > > PMD_DRV_LOG(WARNING, "Filter type (%d) not supported", > > filter_type); > > -- > > 2.9.3 >=20 > Thanks Ferruh's capture. >=20 > Acked by: Qi Zhang Applied to dpdk-next-net-intel, thanks! /Helin