* [dpdk-dev] [PATCH] net/i40e: add break case in flow API
@ 2018-01-12 6:13 Wei Zhao
2018-01-12 6:47 ` Zhang, Qi Z
0 siblings, 1 reply; 3+ messages in thread
From: Wei Zhao @ 2018-01-12 6:13 UTC (permalink / raw)
To: dev; +Cc: qi.z.zhang, ferruh.yigit, Wei Zhao
This bug may cause build error when there is no break
case code, so add it.
Fixes: accf70b2ae64e ("net/i40e: move RSS to flow API")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/i40e/i40e_flow.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index 6106f78..cd9a9b6 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -4600,6 +4600,7 @@ i40e_flow_destroy(struct rte_eth_dev *dev,
case RTE_ETH_FILTER_HASH:
ret = i40e_config_rss_filter_del(dev,
(struct i40e_rte_flow_rss_conf *)flow->rule);
+ break;
default:
PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
filter_type);
--
2.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: add break case in flow API 2018-01-12 6:13 [dpdk-dev] [PATCH] net/i40e: add break case in flow API Wei Zhao @ 2018-01-12 6:47 ` Zhang, Qi Z 2018-01-13 5:55 ` Zhang, Helin 0 siblings, 1 reply; 3+ messages in thread From: Zhang, Qi Z @ 2018-01-12 6:47 UTC (permalink / raw) To: Zhao1, Wei, dev; +Cc: Yigit, Ferruh > -----Original Message----- > From: Zhao1, Wei > Sent: Friday, January 12, 2018 2:14 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yigit, Ferruh > <ferruh.yigit@intel.com>; Zhao1, Wei <wei.zhao1@intel.com> > Subject: [PATCH] net/i40e: add break case in flow API > > This bug may cause build error when there is no break case code, so add it. > > Fixes: accf70b2ae64e ("net/i40e: move RSS to flow API") > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com> > --- > drivers/net/i40e/i40e_flow.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index > 6106f78..cd9a9b6 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -4600,6 +4600,7 @@ i40e_flow_destroy(struct rte_eth_dev *dev, > case RTE_ETH_FILTER_HASH: > ret = i40e_config_rss_filter_del(dev, > (struct i40e_rte_flow_rss_conf *)flow->rule); > + break; > default: > PMD_DRV_LOG(WARNING, "Filter type (%d) not supported", > filter_type); > -- > 2.9.3 Thanks Ferruh's capture. Acked by: Qi Zhang <qi.z.zhang@intel.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: add break case in flow API 2018-01-12 6:47 ` Zhang, Qi Z @ 2018-01-13 5:55 ` Zhang, Helin 0 siblings, 0 replies; 3+ messages in thread From: Zhang, Helin @ 2018-01-13 5:55 UTC (permalink / raw) To: Zhang, Qi Z, Zhao1, Wei, dev; +Cc: Yigit, Ferruh > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Friday, January 12, 2018 2:48 PM > To: Zhao1, Wei; dev@dpdk.org > Cc: Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH] net/i40e: add break case in flow API > > > > > -----Original Message----- > > From: Zhao1, Wei > > Sent: Friday, January 12, 2018 2:14 PM > > To: dev@dpdk.org > > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yigit, Ferruh > > <ferruh.yigit@intel.com>; Zhao1, Wei <wei.zhao1@intel.com> > > Subject: [PATCH] net/i40e: add break case in flow API > > > > This bug may cause build error when there is no break case code, so add it. > > > > Fixes: accf70b2ae64e ("net/i40e: move RSS to flow API") > > > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com> > > --- > > drivers/net/i40e/i40e_flow.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/i40e/i40e_flow.c > > b/drivers/net/i40e/i40e_flow.c index > > 6106f78..cd9a9b6 100644 > > --- a/drivers/net/i40e/i40e_flow.c > > +++ b/drivers/net/i40e/i40e_flow.c > > @@ -4600,6 +4600,7 @@ i40e_flow_destroy(struct rte_eth_dev *dev, > > case RTE_ETH_FILTER_HASH: > > ret = i40e_config_rss_filter_del(dev, > > (struct i40e_rte_flow_rss_conf *)flow->rule); > > + break; > > default: > > PMD_DRV_LOG(WARNING, "Filter type (%d) not supported", > > filter_type); > > -- > > 2.9.3 > > Thanks Ferruh's capture. > > Acked by: Qi Zhang <qi.z.zhang@intel.com> Applied to dpdk-next-net-intel, thanks! /Helin ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-13 5:55 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-01-12 6:13 [dpdk-dev] [PATCH] net/i40e: add break case in flow API Wei Zhao 2018-01-12 6:47 ` Zhang, Qi Z 2018-01-13 5:55 ` Zhang, Helin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).