From: "Zhang, Helin" <helin.zhang@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Dai, Wei" <wei.dai@intel.com>,
"Wang, Liang-min" <liang-min.wang@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler
Date: Sat, 13 Jan 2018 06:27:28 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E71ACFC7F9@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1514406150-17517-1-git-send-email-qi.z.zhang@intel.com>
Hi Qi
Could you help to rebase on the latest dpdk-next-net-intel? It cannot be applied now. Thanks!
Regards,
Helin
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang
> Sent: Thursday, December 28, 2017 4:22 AM
> To: Lu, Wenzhuo
> Cc: dev@dpdk.org; Dai, Wei; Wang, Liang-min; Zhang, Qi Z; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler
>
> Mailbox interrupt handler only take care of PF reset notification, for other
> message ixgbe_read_mbx should not be called since it get chance to break the
> foreground VF to PF communication.
> This can be simply repeated by
> testpmd>rx_vlan rm all 0
>
> Fixes: 77234603fba0 ("net/ixgbe: support VF mailbox interrupt for link
> up/down")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index ff19a56..02121f4 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -8165,13 +8165,17 @@ static void ixgbevf_mbx_process(struct
> rte_eth_dev *dev)
> struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data-
> >dev_private);
> u32 in_msg = 0;
>
> - if (ixgbe_read_mbx(hw, &in_msg, 1, 0))
> - return;
> + /* peek the message first */
> + in_msg = IXGBE_READ_REG(hw, IXGBE_VFMBMEM);
>
> /* PF reset VF event */
> - if (in_msg == IXGBE_PF_CONTROL_MSG)
> + if (in_msg == IXGBE_PF_CONTROL_MSG) {
> + /* dummy mbx read to ack pf */
> + if (ixgbe_read_mbx(hw, &in_msg, 1, 0))
> + return;
> _rte_eth_dev_callback_process(dev,
> RTE_ETH_EVENT_INTR_RESET,
> NULL, NULL);
> + }
> }
>
> static int
> --
> 2.7.4
next prev parent reply other threads:[~2018-01-13 6:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-27 20:22 Qi Zhang
2017-12-27 20:22 ` [dpdk-dev] [PATCH 2/2] net/e1000: " Qi Zhang
2018-01-12 2:32 ` Dai, Wei
2018-01-13 16:14 ` Zhang, Helin
2017-12-28 4:38 ` [dpdk-dev] [PATCH 1/2] net/ixgbe: " Dai, Wei
2018-01-11 8:07 ` Zhang, Qi Z
2018-01-12 2:29 ` Dai, Wei
2018-01-12 2:30 ` Dai, Wei
2018-01-13 6:27 ` Zhang, Helin [this message]
2018-01-13 16:13 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E71ACFC7F9@SHSMSX103.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=liang-min.wang@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=wei.dai@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).