* [dpdk-dev] [PATCH] app/testpmd:vlan filter fail @ 2018-02-02 5:09 Yanglong Wu 2018-02-04 6:27 ` Shahaf Shuler 2018-02-05 2:33 ` [dpdk-dev] [PATCH v2] " Yanglong Wu 0 siblings, 2 replies; 13+ messages in thread From: Yanglong Wu @ 2018-02-02 5:09 UTC (permalink / raw) To: dev; +Cc: shahafs, wenzhuo.lu, Yanglong Wu Removing out port_conf.rxmode.hw_vlan_filter = 1 will let it equal to 0 and port_conf.rxmode.offloads is assigned as 0 again if hw_vlan_filter = 1. So it will always lead to fail for vlan filter setting Fix:0074d02fc(convert to new Rx offloads API) Signed-off-by: Yanglong Wu <yanglong.wu@intel.com> --- app/test-pmd/testpmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 5dc8ccac5..0751e573c 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2328,7 +2328,7 @@ init_port_dcb_config(portid_t pid, retval = get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs, pfc_en); if (retval < 0) return retval; - port_conf.rxmode.offloads |= DEV_RX_OFFLOAD_VLAN_FILTER; + port_conf.rxmode.hw_vlan_filter = 1; /** * Write the configuration into the device. -- 2.11.0 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd:vlan filter fail 2018-02-02 5:09 [dpdk-dev] [PATCH] app/testpmd:vlan filter fail Yanglong Wu @ 2018-02-04 6:27 ` Shahaf Shuler 2018-02-05 1:51 ` Wu, Yanglong 2018-02-05 2:33 ` [dpdk-dev] [PATCH v2] " Yanglong Wu 1 sibling, 1 reply; 13+ messages in thread From: Shahaf Shuler @ 2018-02-04 6:27 UTC (permalink / raw) To: Yanglong Wu, dev; +Cc: wenzhuo.lu Hi Wu, Indeed there is an issue here, but this is not the right fix. Friday, February 2, 2018 7:10 AM, Yanglong Wu: > Subject: [PATCH] app/testpmd:vlan filter fail > > Removing out port_conf.rxmode.hw_vlan_filter = 1 will let it equal to 0 and > port_conf.rxmode.offloads is assigned as 0 again if hw_vlan_filter = 1. So it > will always lead to fail for vlan filter setting > > Fix:0074d02fc(convert to new Rx offloads API) > Signed-off-by: Yanglong Wu <yanglong.wu@intel.com> > --- > app/test-pmd/testpmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > 5dc8ccac5..0751e573c 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -2328,7 +2328,7 @@ init_port_dcb_config(portid_t pid, > retval = get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs, > pfc_en); > if (retval < 0) > return retval; > - port_conf.rxmode.offloads |= DEV_RX_OFFLOAD_VLAN_FILTER; > + port_conf.rxmode.hw_vlan_filter = 1; The VLAN filter resets because the rxmode.ignore_offload_bitfield is not set. If it was set, the ethdev rxmode convert functions would have convert the new flag to the old API (rxmode.hw_vlan_filter). Am not much familiar with this configuration but here is a suggested fix: diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index d8ac43268..caf282386 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2324,6 +2324,8 @@ init_port_dcb_config(portid_t pid, rte_port = &ports[pid]; memset(&port_conf, 0, sizeof(struct rte_eth_conf)); + port_conf.rxmode = rte_port->dev_conf.rxmode; + port_conf.txmode = rte_port->dev_conf.txmode; /* Enter DCB configuration status */ dcb_config = 1; The port_conf for the dcb configuration will inherit the same configuration of the port (which has the ignore_offload_bitfield set). Otherwise, at least the rxmode.ignore_offload_bitfield must be set. > > /** > * Write the configuration into the device. > -- > 2.11.0 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd:vlan filter fail 2018-02-04 6:27 ` Shahaf Shuler @ 2018-02-05 1:51 ` Wu, Yanglong 0 siblings, 0 replies; 13+ messages in thread From: Wu, Yanglong @ 2018-02-05 1:51 UTC (permalink / raw) To: Shahaf Shuler, dev; +Cc: Lu, Wenzhuo Hi, Thanks for your review. I got it! Yanglong Wu -----Original Message----- From: Shahaf Shuler [mailto:shahafs@mellanox.com] Sent: Sunday, February 4, 2018 2:27 PM To: Wu, Yanglong <yanglong.wu@intel.com>; dev@dpdk.org Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com> Subject: RE: [PATCH] app/testpmd:vlan filter fail Hi Wu, Indeed there is an issue here, but this is not the right fix. Friday, February 2, 2018 7:10 AM, Yanglong Wu: > Subject: [PATCH] app/testpmd:vlan filter fail > > Removing out port_conf.rxmode.hw_vlan_filter = 1 will let it equal to > 0 and port_conf.rxmode.offloads is assigned as 0 again if > hw_vlan_filter = 1. So it will always lead to fail for vlan filter > setting > > Fix:0074d02fc(convert to new Rx offloads API) > Signed-off-by: Yanglong Wu <yanglong.wu@intel.com> > --- > app/test-pmd/testpmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > 5dc8ccac5..0751e573c 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -2328,7 +2328,7 @@ init_port_dcb_config(portid_t pid, > retval = get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs, pfc_en); > if (retval < 0) > return retval; > - port_conf.rxmode.offloads |= DEV_RX_OFFLOAD_VLAN_FILTER; > + port_conf.rxmode.hw_vlan_filter = 1; The VLAN filter resets because the rxmode.ignore_offload_bitfield is not set. If it was set, the ethdev rxmode convert functions would have convert the new flag to the old API (rxmode.hw_vlan_filter). Am not much familiar with this configuration but here is a suggested fix: diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index d8ac43268..caf282386 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2324,6 +2324,8 @@ init_port_dcb_config(portid_t pid, rte_port = &ports[pid]; memset(&port_conf, 0, sizeof(struct rte_eth_conf)); + port_conf.rxmode = rte_port->dev_conf.rxmode; + port_conf.txmode = rte_port->dev_conf.txmode; /* Enter DCB configuration status */ dcb_config = 1; The port_conf for the dcb configuration will inherit the same configuration of the port (which has the ignore_offload_bitfield set). Otherwise, at least the rxmode.ignore_offload_bitfield must be set. > > /** > * Write the configuration into the device. > -- > 2.11.0 ^ permalink raw reply [flat|nested] 13+ messages in thread
* [dpdk-dev] [PATCH v2] app/testpmd:vlan filter fail 2018-02-02 5:09 [dpdk-dev] [PATCH] app/testpmd:vlan filter fail Yanglong Wu 2018-02-04 6:27 ` Shahaf Shuler @ 2018-02-05 2:33 ` Yanglong Wu 2018-02-05 6:14 ` Shahaf Shuler ` (2 more replies) 1 sibling, 3 replies; 13+ messages in thread From: Yanglong Wu @ 2018-02-05 2:33 UTC (permalink / raw) To: dev; +Cc: shahafs, wenzhuo.lu, Yanglong Wu This bug is caused by miss port configuration. The port_conf for the DCB configuration should inherit the same configuration of the port. Fix:0074d02fc(convert to new Rx offloads API) Signed-off-by: Yanglong Wu <yanglong.wu@intel.com> --- v2: changing patch accoding to the review --- app/test-pmd/testpmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 5dc8ccac5..da1d9bd3a 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2324,6 +2324,9 @@ init_port_dcb_config(portid_t pid, /* Enter DCB configuration status */ dcb_config = 1; + port_conf.rxmode = rte_port->dev_conf.rxmode; + port_conf.txmode = rte_port->dev_conf.txmode; + /*set configuration of DCB in vt mode and DCB in non-vt mode*/ retval = get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs, pfc_en); if (retval < 0) -- 2.11.0 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH v2] app/testpmd:vlan filter fail 2018-02-05 2:33 ` [dpdk-dev] [PATCH v2] " Yanglong Wu @ 2018-02-05 6:14 ` Shahaf Shuler 2018-02-05 7:36 ` Wu, Yanglong 2018-02-05 7:53 ` [dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue Yanglong Wu 2018-02-05 8:48 ` [dpdk-dev] [PATCH v3] app/testpmd: fix port DCB configuration Yanglong Wu 2 siblings, 1 reply; 13+ messages in thread From: Shahaf Shuler @ 2018-02-05 6:14 UTC (permalink / raw) To: Yanglong Wu, dev; +Cc: wenzhuo.lu Hi Wu, Few small comment. Monday, February 5, 2018 4:34 AM, Yanglong Wu: > Subject: [PATCH v2] app/testpmd:vlan filter fail The commit title can better describe the patch, something like: "app/testpmd: fix port DCB configuration" > > This bug is caused by miss port configuration. The above line is not needed. > The port_conf for the DCB configuration should inherit the same > configuration of the port. > > Fix:0074d02fc(convert to new Rx offloads API) It needs to be : Fixes: 0074d02fca21 ("app/testpmd: convert to new Rx offloads API") > Signed-off-by: Yanglong Wu <yanglong.wu@intel.com> > --- > v2: > changing patch accoding to the review > --- > app/test-pmd/testpmd.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > 5dc8ccac5..da1d9bd3a 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -2324,6 +2324,9 @@ init_port_dcb_config(portid_t pid, > /* Enter DCB configuration status */ > dcb_config = 1; > > + port_conf.rxmode = rte_port->dev_conf.rxmode; > + port_conf.txmode = rte_port->dev_conf.txmode; > + > /*set configuration of DCB in vt mode and DCB in non-vt mode*/ > retval = get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs, > pfc_en); > if (retval < 0) > -- Otherwise - Acked-by: Shahaf Shuler <shahafs@mellanox.com> > 2.11.0 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH v2] app/testpmd:vlan filter fail 2018-02-05 6:14 ` Shahaf Shuler @ 2018-02-05 7:36 ` Wu, Yanglong 0 siblings, 0 replies; 13+ messages in thread From: Wu, Yanglong @ 2018-02-05 7:36 UTC (permalink / raw) To: Shahaf Shuler, dev; +Cc: Lu, Wenzhuo Thx! I will change it right now -----Original Message----- From: Shahaf Shuler [mailto:shahafs@mellanox.com] Sent: Monday, February 5, 2018 2:14 PM To: Wu, Yanglong <yanglong.wu@intel.com>; dev@dpdk.org Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com> Subject: RE: [PATCH v2] app/testpmd:vlan filter fail Hi Wu, Few small comment. Monday, February 5, 2018 4:34 AM, Yanglong Wu: > Subject: [PATCH v2] app/testpmd:vlan filter fail The commit title can better describe the patch, something like: "app/testpmd: fix port DCB configuration" > > This bug is caused by miss port configuration. The above line is not needed. > The port_conf for the DCB configuration should inherit the same > configuration of the port. > > Fix:0074d02fc(convert to new Rx offloads API) It needs to be : Fixes: 0074d02fca21 ("app/testpmd: convert to new Rx offloads API") > Signed-off-by: Yanglong Wu <yanglong.wu@intel.com> > --- > v2: > changing patch accoding to the review > --- > app/test-pmd/testpmd.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > 5dc8ccac5..da1d9bd3a 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -2324,6 +2324,9 @@ init_port_dcb_config(portid_t pid, > /* Enter DCB configuration status */ > dcb_config = 1; > > + port_conf.rxmode = rte_port->dev_conf.rxmode; > + port_conf.txmode = rte_port->dev_conf.txmode; > + > /*set configuration of DCB in vt mode and DCB in non-vt mode*/ > retval = get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs, pfc_en); > if (retval < 0) > -- Otherwise - Acked-by: Shahaf Shuler <shahafs@mellanox.com> > 2.11.0 ^ permalink raw reply [flat|nested] 13+ messages in thread
* [dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue 2018-02-05 2:33 ` [dpdk-dev] [PATCH v2] " Yanglong Wu 2018-02-05 6:14 ` Shahaf Shuler @ 2018-02-05 7:53 ` Yanglong Wu 2018-02-05 8:00 ` Yang, Zhiyong 2018-02-05 8:48 ` [dpdk-dev] [PATCH v3] app/testpmd: fix port DCB configuration Yanglong Wu 2 siblings, 1 reply; 13+ messages in thread From: Yanglong Wu @ 2018-02-05 7:53 UTC (permalink / raw) To: dev; +Cc: shahafs, wenzhuo.lu, Yanglong Wu In the feature of increasing port_id range from 8 bits to 16 bits, vlan port_id allocation function was forget to substitute UINT8 with UINT16, so the vlan port_id was allocated as a inccrete number. Fixes:28caa76aea71 ("app/testpmd: fix port id type") Signed-off-by: Yanglong Wu <yanglong.wu@intel.com> Reviewed-by: Zhiyong Yang <zhiyong.yang@intel.com> --- v2: modified commit message --- v3: add review tag --- app/test-pmd/cmdline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index f71d96301..8990ebf6b 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -3352,7 +3352,7 @@ cmdline_parse_token_num_t cmd_vlan_tpid_tpid = tp_id, UINT16); cmdline_parse_token_num_t cmd_vlan_tpid_portid = TOKEN_NUM_INITIALIZER(struct cmd_vlan_tpid_result, - port_id, UINT8); + port_id, UINT16); cmdline_parse_inst_t cmd_vlan_tpid = { .f = cmd_vlan_tpid_parsed, -- 2.11.0 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue 2018-02-05 7:53 ` [dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue Yanglong Wu @ 2018-02-05 8:00 ` Yang, Zhiyong 0 siblings, 0 replies; 13+ messages in thread From: Yang, Zhiyong @ 2018-02-05 8:00 UTC (permalink / raw) To: Wu, Yanglong, dev; +Cc: shahafs, Lu, Wenzhuo, Wu, Yanglong It seems that the patch has been applied by Thomas. Please check mail list. > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu > Sent: Monday, February 5, 2018 3:53 PM > To: dev@dpdk.org > Cc: shahafs@mellanox.com; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, > Yanglong <yanglong.wu@intel.com> > Subject: [dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue > > In the feature of increasing port_id range from 8 bits to 16 bits, vlan port_id > allocation function was forget to substitute UINT8 with UINT16, so the vlan > port_id was allocated as a inccrete number. > > Fixes:28caa76aea71 ("app/testpmd: fix port id type") > > Signed-off-by: Yanglong Wu <yanglong.wu@intel.com> > Reviewed-by: Zhiyong Yang <zhiyong.yang@intel.com> > --- ^ permalink raw reply [flat|nested] 13+ messages in thread
* [dpdk-dev] [PATCH v3] app/testpmd: fix port DCB configuration 2018-02-05 2:33 ` [dpdk-dev] [PATCH v2] " Yanglong Wu 2018-02-05 6:14 ` Shahaf Shuler 2018-02-05 7:53 ` [dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue Yanglong Wu @ 2018-02-05 8:48 ` Yanglong Wu 2018-02-05 8:59 ` Shahaf Shuler ` (2 more replies) 2 siblings, 3 replies; 13+ messages in thread From: Yanglong Wu @ 2018-02-05 8:48 UTC (permalink / raw) To: dev; +Cc: shahafs, wenzhuo.lu, Yanglong Wu The port_conf for the DCB configuration should inherit the same configuration of the port. Fix:0074d02fc("app/testpmd: convert to new Rx offloads API") Signed-off-by: Yanglong Wu <yanglong.wu@intel.com> --- v2: changing patch accoding to review --- v3: changing patch accoding to comments --- app/test-pmd/testpmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 5dc8ccac5..da1d9bd3a 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2324,6 +2324,9 @@ init_port_dcb_config(portid_t pid, /* Enter DCB configuration status */ dcb_config = 1; + port_conf.rxmode = rte_port->dev_conf.rxmode; + port_conf.txmode = rte_port->dev_conf.txmode; + /*set configuration of DCB in vt mode and DCB in non-vt mode*/ retval = get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs, pfc_en); if (retval < 0) -- 2.11.0 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH v3] app/testpmd: fix port DCB configuration 2018-02-05 8:48 ` [dpdk-dev] [PATCH v3] app/testpmd: fix port DCB configuration Yanglong Wu @ 2018-02-05 8:59 ` Shahaf Shuler 2018-02-05 9:47 ` [dpdk-dev] [PATCH v4] " Yanglong Wu 2018-02-05 9:56 ` Yanglong Wu 2 siblings, 0 replies; 13+ messages in thread From: Shahaf Shuler @ 2018-02-05 8:59 UTC (permalink / raw) To: Yanglong Wu, dev; +Cc: wenzhuo.lu Monday, February 5, 2018 10:48 AM, Yanglong Wu: > Fix:0074d02fc("app/testpmd: convert to new Rx offloads API") The fix line is still wrong. Use the one I suggested. > Signed-off-by: Yanglong Wu <yanglong.wu@intel.com> > --- > v2: > changing patch accoding to review > --- > v3: > changing patch accoding to comments > --- > app/test-pmd/testpmd.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > 5dc8ccac5..da1d9bd3a 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -2324,6 +2324,9 @@ init_port_dcb_config(portid_t pid, > /* Enter DCB configuration status */ > dcb_config = 1; > > + port_conf.rxmode = rte_port->dev_conf.rxmode; > + port_conf.txmode = rte_port->dev_conf.txmode; > + > /*set configuration of DCB in vt mode and DCB in non-vt mode*/ > retval = get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs, > pfc_en); > if (retval < 0) > -- > 2.11.0 Acked-by: Shahaf Shuler <shahafs@mellanox.com> (please include this on the next version if any). ^ permalink raw reply [flat|nested] 13+ messages in thread
* [dpdk-dev] [PATCH v4] app/testpmd: fix port DCB configuration 2018-02-05 8:48 ` [dpdk-dev] [PATCH v3] app/testpmd: fix port DCB configuration Yanglong Wu 2018-02-05 8:59 ` Shahaf Shuler @ 2018-02-05 9:47 ` Yanglong Wu 2018-02-05 9:56 ` Yanglong Wu 2 siblings, 0 replies; 13+ messages in thread From: Yanglong Wu @ 2018-02-05 9:47 UTC (permalink / raw) To: dev; +Cc: shahafs, wenzhuo.lu, Yanglong Wu The port_conf for the DCB configuration should inherit the same configuration of the port. Fixes: 0074d02fca21("app/testpmd: convert to new Rx offloads API") Signed-off-by: Yanglong Wu <yanglong.wu@intel.com> --- v2: changing patch accoding to review --- v3: changing patch accoding to comments --- v4: changing patch accoding to comments --- app/test-pmd/testpmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 5dc8ccac5..da1d9bd3a 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2324,6 +2324,9 @@ init_port_dcb_config(portid_t pid, /* Enter DCB configuration status */ dcb_config = 1; + port_conf.rxmode = rte_port->dev_conf.rxmode; + port_conf.txmode = rte_port->dev_conf.txmode; + /*set configuration of DCB in vt mode and DCB in non-vt mode*/ retval = get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs, pfc_en); if (retval < 0) -- 2.11.0 ^ permalink raw reply [flat|nested] 13+ messages in thread
* [dpdk-dev] [PATCH v4] app/testpmd: fix port DCB configuration 2018-02-05 8:48 ` [dpdk-dev] [PATCH v3] app/testpmd: fix port DCB configuration Yanglong Wu 2018-02-05 8:59 ` Shahaf Shuler 2018-02-05 9:47 ` [dpdk-dev] [PATCH v4] " Yanglong Wu @ 2018-02-05 9:56 ` Yanglong Wu 2018-02-06 15:09 ` Zhang, Helin 2 siblings, 1 reply; 13+ messages in thread From: Yanglong Wu @ 2018-02-05 9:56 UTC (permalink / raw) To: dev; +Cc: shahafs, wenzhuo.lu, Yanglong Wu The port_conf for the DCB configuration should inherit the same configuration of the port. Fixes: 0074d02fca21("app/testpmd: convert to new Rx offloads API") Signed-off-by: Yanglong Wu <yanglong.wu@intel.com> Acked-by: Shahaf Shuler <shahafs@mellanox.com> --- v2: changing patch accoding to review --- v3: changing patch accoding to comments --- v4: changing patch accoding to comments --- app/test-pmd/testpmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 5dc8ccac5..da1d9bd3a 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2324,6 +2324,9 @@ init_port_dcb_config(portid_t pid, /* Enter DCB configuration status */ dcb_config = 1; + port_conf.rxmode = rte_port->dev_conf.rxmode; + port_conf.txmode = rte_port->dev_conf.txmode; + /*set configuration of DCB in vt mode and DCB in non-vt mode*/ retval = get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs, pfc_en); if (retval < 0) -- 2.11.0 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH v4] app/testpmd: fix port DCB configuration 2018-02-05 9:56 ` Yanglong Wu @ 2018-02-06 15:09 ` Zhang, Helin 0 siblings, 0 replies; 13+ messages in thread From: Zhang, Helin @ 2018-02-06 15:09 UTC (permalink / raw) To: Wu, Yanglong, dev; +Cc: shahafs, Lu, Wenzhuo, Wu, Yanglong > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu > Sent: Monday, February 5, 2018 5:56 PM > To: dev@dpdk.org > Cc: shahafs@mellanox.com; Lu, Wenzhuo; Wu, Yanglong > Subject: [dpdk-dev] [PATCH v4] app/testpmd: fix port DCB configuration > > The port_conf for the DCB configuration should inherit the same configuration > of the port. > > Fixes: 0074d02fca21("app/testpmd: convert to new Rx offloads API") > Signed-off-by: Yanglong Wu <yanglong.wu@intel.com> > > Acked-by: Shahaf Shuler <shahafs@mellanox.com> Applied to dpdk-next-net-intel, thanks! /Helin ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2018-02-06 15:09 UTC | newest] Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-02-02 5:09 [dpdk-dev] [PATCH] app/testpmd:vlan filter fail Yanglong Wu 2018-02-04 6:27 ` Shahaf Shuler 2018-02-05 1:51 ` Wu, Yanglong 2018-02-05 2:33 ` [dpdk-dev] [PATCH v2] " Yanglong Wu 2018-02-05 6:14 ` Shahaf Shuler 2018-02-05 7:36 ` Wu, Yanglong 2018-02-05 7:53 ` [dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue Yanglong Wu 2018-02-05 8:00 ` Yang, Zhiyong 2018-02-05 8:48 ` [dpdk-dev] [PATCH v3] app/testpmd: fix port DCB configuration Yanglong Wu 2018-02-05 8:59 ` Shahaf Shuler 2018-02-05 9:47 ` [dpdk-dev] [PATCH v4] " Yanglong Wu 2018-02-05 9:56 ` Yanglong Wu 2018-02-06 15:09 ` Zhang, Helin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).