From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C07302965 for ; Thu, 29 Mar 2018 07:10:50 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2018 22:10:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,375,1517904000"; d="scan'208";a="42217105" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga001.fm.intel.com with ESMTP; 28 Mar 2018 22:10:49 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 28 Mar 2018 22:10:49 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 28 Mar 2018 22:10:49 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.235]) by shsmsx102.ccr.corp.intel.com ([169.254.2.80]) with mapi id 14.03.0319.002; Thu, 29 Mar 2018 13:10:47 +0800 From: "Zhang, Helin" To: "Zhang, Qi Z" , "Xu, Rosen" , "Xing, Beilei" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] drivers/net/i40e/i40e_ethdev_vf.c: fix missing promiscuous disable at device stop Thread-Index: AQHTvEH3lVV1xxB1iUWBysqXgl7OE6PSY/mAgBRbxSA= Date: Thu, 29 Mar 2018 05:10:47 +0000 Message-ID: References: <1521107140-68349-1-git-send-email-rosen.xu@intel.com> <039ED4275CED7440929022BC67E706115316E52F@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E706115316E52F@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] drivers/net/i40e/i40e_ethdev_vf.c: fix missing promiscuous disable at device stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 05:10:51 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Friday, March 16, 2018 2:25 PM > To: Xu, Rosen; Xing, Beilei > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] drivers/net/i40e/i40e_ethdev_vf.c: fix > missing promiscuous disable at device stop >=20 > Hi Rosen: >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rosen Xu > > Sent: Thursday, March 15, 2018 5:46 PM > > To: Xing, Beilei > > Cc: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v2] drivers/net/i40e/i40e_ethdev_vf.c: fix > > missing promiscuous disable at device stop > > > > In scenario of Kernel Driver runs on PF and PMD runs on VF, PMD exit > > doesn't disable promiscuous mode, this will cause vlan filter set by > > Kernel Driver will not take effect. > > > > This patch will fix it, add promiscuous disable at device stop. > > > > Signed-off-by: Rosen Xu > > --- > > drivers/net/i40e/i40e_ethdev_vf.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > > b/drivers/net/i40e/i40e_ethdev_vf.c > > index fd003fe..f395b02 100644 > > --- a/drivers/net/i40e/i40e_ethdev_vf.c > > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > > @@ -2051,6 +2051,8 @@ static int eth_i40evf_pci_remove(struct > > rte_pci_device *pci_dev) > > > > if (hw->adapter_stopped =3D=3D 1) > > return; > > + i40evf_dev_promiscuous_disable(dev); > > + i40evf_dev_allmulticast_disable(dev); >=20 > Device's promiscuous mode is not expected to be changed in a > dev_start/dev_stop cycle Application need to call > rte_eth_promiscuous_disable and i40evf_dev_allmulticast_disable to change= it > explicitly. >=20 > Regards > Qi Basically I'd reject your patch, based on the comments Qi made above. /Helin >=20 > > i40evf_stop_queues(dev); > > i40evf_disable_queues_intr(dev); > > i40e_dev_clear_queues(dev); > > -- > > 1.8.3.1