From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30079.outbound.protection.outlook.com [40.107.3.79]) by dpdk.org (Postfix) with ESMTP id 14CF92BF7; Thu, 23 Aug 2018 18:18:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y+aSfttEHiip8SzO3fTQQhcznyC8kssyKYjA3FzTy6E=; b=FUtwUHdylYt0X6qPnsRjVqOcOkJ8rzLInpeqjclmK1x04NkGDfBbwcmlIOxe2sZBjsYWFtPr1SRWCpggiq8oobbEwxv/GxnkGlE7zjd6DVj9Z7xtamuNVA8lMlwtjxhL25uluVug/R3QJNpRtUi3wgoH5qGNpI25oRg81mug29c= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4060.eurprd05.prod.outlook.com (52.134.72.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.15; Thu, 23 Aug 2018 16:18:37 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::d45:8e84:6d63:c57c]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::d45:8e84:6d63:c57c%2]) with mapi id 15.20.1059.023; Thu, 23 Aug 2018 16:18:37 +0000 From: Yongseok Koh To: Alejandro Lucero CC: dpdk stable , dev Thread-Topic: [dpdk-dev] 17.11.4 patches review and test Thread-Index: AQHUNY2SOKtSvwXKMk+v7+wMKBsJwqTKAoWAgAIK4ICAAYFjAA== Date: Thu, 23 Aug 2018 16:18:37 +0000 Message-ID: References: <20180816181821.37143-1-yskoh@mellanox.com> <20180823001915.GA27470@yongseok-MBP.local> In-Reply-To: <20180823001915.GA27470@yongseok-MBP.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [73.222.116.174] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4060; 6:tTqCnC/PLCQmvvKz/vkIzW31dz4mNNWnqIvs7KJBQJi/8xCKYQv4yfdMrxnPAYZChMSQmjKjAT5kujbYCft9PqDgn3JlaF2qL7Doz/28s823LKej/tB+sp+alyTuWqSeuO8GXkTwSOIiCZoi7o0j9+tvOcVIA/rqvyEh2h/Tg0ivLfxsfHHVuWIXOjI5zPU1zeQJfeNO0L58jPwIicI5v2Bxo2epSxZNKIkPCJQHD9fthdtKVJuGhMWqNy8Eclepowd29CUiLQQ6lmO/K0zW7FHW/JjpcJeykicHC65M/SqonxLM654Et7wBKje6hj/6kM0kESdyAGlTi7I9LBSyrh/GHgZtmW5nznKRJ9Moe0qgheWygzkCVAiiQ9VdvYPjBHQ66W7aRRPiT/q6hdvhXAwJOdkmVgzwjzpjaGmOwERzDglUavT0Nwtc9O0PXw34EaVGdMeHFFN+ZnFx4Q4vsw==; 5:VDj6CUJrfz+WG5ZuZrUQ2beoH5iJ2v1Qr1KvC/di/3kyTfwhcQYTY8YxDdHRTvQI8crEl/RkSLnj5m0NaL7EtdB/WU19i6J32XqU84xcOqe7yoDIxQwH0XlgqOBxQLFSPVQew00M50sEbrBejAyzdiocggrTafu6kHTviQo5OFE=; 7:rkQIvoTjBa/ppPXKrDvCbZ4omoEzOO3Uge0i5WEXndzara3rQ2YCWHiYgsyYbYU8YGfvJgzl6hrQPvwHOe2+RNo1n0gk7G4gzrFB4KS3O17u5NLlEemQUJvtf1hh5N7rlXM5qBz6/oNZ5xTDXRPU5SFw4IaF51eaBIwibp0iFo3pUBXmBBiD2jHFLCLeUI8R7Dl63+xwB4fMwqw4EqXKXWvIab0AXttnd5jAl0Aom0FyTvYHidltDsHJX7M589qB x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: e8a452d8-29ed-42d7-4d1b-08d609141510 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4060; x-ms-traffictypediagnostic: DB3PR0502MB4060: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(192374486261705)(189930954265078)(45079756050767)(17755550239193); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231311)(944501410)(52105095)(10201501046)(93006095)(93001095)(3002001)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(201708071742011)(7699016); SRVR:DB3PR0502MB4060; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB4060; x-forefront-prvs: 0773BB46AC x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(136003)(39860400002)(366004)(396003)(54094003)(189003)(53754006)(199004)(3846002)(478600001)(4326008)(8676002)(8936002)(6116002)(81156014)(81166006)(97736004)(6916009)(5660300001)(6246003)(25786009)(68736007)(5250100002)(39060400002)(7736002)(45080400002)(33656002)(105586002)(106356001)(36756003)(2900100001)(66066001)(2906002)(186003)(26005)(102836004)(14454004)(6436002)(76176011)(82746002)(86362001)(229853002)(486006)(6486002)(476003)(2616005)(11346002)(446003)(575784001)(83716003)(6506007)(966005)(316002)(54906003)(14444005)(256004)(53546011)(305945005)(99286004)(6512007)(6306002)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4060; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: tBs4vT7DODtvDqTFDfPR9ABwtCrWcXCLoYB3ZQPpmv/qZ3LvLo+VpHJjU1jIAGxa59uxs0nQMijsXn7HJuufxne25O3fsN/KTYH0UYtEHP83bwa6h2KycayEIp+KmstgtFrTbQZTzdwIkKpaWahFhcTk14IpIrtxmW8P2la1w4YA679GsXjAoRqaW+/w+GK4sHmtyEIUPqlLpUFhAbWt9vhARy8DiMv8i8CThnpTZeEXXbqvupT49BUe0oy/5oLYbBKib2gw+MNkLOduSw6zwqdBe0r2pGDfD4CsVqmn4juLQGwic+X4SuGbXlB9XI9rIFRLmRuR972hCmkbOBxRSdtBeeYo4mS+FfXe0m+lPOk= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <6FC6E1FB5457BE4FA6CC38FD66CAD0D7@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8a452d8-29ed-42d7-4d1b-08d609141510 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2018 16:18:37.6420 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4060 Subject: Re: [dpdk-dev] 17.11.4 patches review and test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2018 16:18:39 -0000 > On Aug 22, 2018, at 5:19 PM, Yongseok Koh wrote: >=20 > On Tue, Aug 21, 2018 at 12:07:49PM +0200, Alejandro Lucero wrote: >> Hi Yonngseok, >>=20 >> There is a patchset aimed at 17.11.x: >>=20 >> https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fpat= ches.dpdk.org%2Fcover%2F42741%2F&data=3D02%7C01%7Cyskoh%40mellanox.com%= 7Cb1b0e3eff71c499ff3fb08d6088e1ede%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7= C0%7C636705803846548967&sdata=3D8f12c1IuUe4mw2EaTZ18vVTuLTjXOD2cSe%2B%2= B7f6OFfk%3D&reserved=3D0 >>=20 >> It was not accepted for master because the memory code has changed a lot >> since 17.11, and I'm working on another patchset for adjusting to the th= ose >> changes. >>=20 >> I wonder if there is any issue with adding this patchset to stable 17.11= .4. >> Note that this makes unlikely a known limitation with emulated IOMMU ins= ide >> VMs. >=20 > This patchset seems quite large for stable release and need to be well ve= rified > before GA. In -rc1 stage, we don't usually take such a large patchset as = people > have already started verification. And we don't usually release -rc2. If = you're > trying to solve a very critical issue with this patchset, I have to relea= se -rc2 > and ask people to verify again. How critical is your issue? >=20 > For the patchset, > - "mem: add function for checking memsegs IOVAs addresses" > This is adding a new API, so I don't expect any API/ABI breakage, but wa= nt to > double-confirm with Thomas. Thomas? >=20 > - "bus/pci: use IOVAs check when setting IOVA mode" > All the patches got ack except for this one but from looking at the thre= ads in > dev mailing list, it looks okay. I have a question though. >=20 >> @@ -640,13 +643,17 @@ >> { >> struct rte_pci_device *dev =3D NULL; >> struct rte_pci_driver *drv =3D NULL; >> + int iommu_dma_mask_check_done =3D 0; >>=20 >> FOREACH_DRIVER_ON_PCIBUS(drv) { >> FOREACH_DEVICE_ON_PCIBUS(dev) { >> if (!rte_pci_match(drv, dev)) >> continue; >> - if (!pci_one_device_iommu_support_va(dev)) >> - return false; >> + if (!iommu_dma_mask_check_done) { >> + if (pci_one_device_iommu_support_va(dev)= < 0) >=20 > pci_one_device_iommu_support_va() returns true/false(1/0), then why do yo= u > expect to see a negative return value in case of failure? Alejandro, As I will release -rc2, I can integrate your patchset but this should be addressed. Please let me know. Thanks, Yongseok >> + return false; >> + iommu_dma_mask_check_done =3D 1; >> + } >> } >> } >> return true; >>=20 >>=20 >>=20 >> Thanks >>=20 >> On Thu, Aug 16, 2018 at 8:18 PM, Yongseok Koh wrote= : >>=20 >>> Hi all, >>>=20 >>> Here is a list of patches targeted for LTS release 17.11.4. Please help >>> review >>> and test. The planned date for the final release is August 23. Before t= hat, >>> please shout if anyone has objections with these patches being applied. >>>=20 >>> Also for the companies committed to running regression tests, please ru= n >>> the >>> tests and report any issue before the release date. >>>=20 >>> A release candidate tarball can be found at: >>>=20 >>> https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2= Fdpdk.org%2Fbrowse%2Fdpdk-stable%2Ftag%2F%3Fid%3Dv17.11.4-rc1&data=3D02= %7C01%7Cyskoh%40mellanox.com%7Cb1b0e3eff71c499ff3fb08d6088e1ede%7Ca652971c7= d2e4d9ba6a4d149256f461b%7C0%7C0%7C636705803846548967&sdata=3DAMgyJMFIs5= 12o5zfZ4aNSy1Ptp%2BhEIMUCVZ6HaL2F40%3D&reserved=3D0 >>>=20 >>> These patches are located at branch 17.11 of dpdk-stable repo: >>> https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2= Fdpdk.org%2Fbrowse%2Fdpdk-stable%2F&data=3D02%7C01%7Cyskoh%40mellanox.c= om%7Cb1b0e3eff71c499ff3fb08d6088e1ede%7Ca652971c7d2e4d9ba6a4d149256f461b%7C= 0%7C0%7C636705803846548967&sdata=3DhvOhEk502vVzboCbRbCZXqJXcsiI3DTtgQyp= QJi0Aro%3D&reserved=3D0 >>>=20 >>> Thanks, >>> Yongseok >>>=20 >>> --- >>> Adrien Mazarguil (2): >>> maintainers: update for Mellanox PMDs >>> net/mlx4: fix minor resource leak during init >>>=20 >>> Ajit Khaparde (7): >>> net/bnxt: fix HW Tx checksum offload check >>> net/bnxt: fix set MTU >>> net/bnxt: fix Rx ring count limitation >>> net/bnxt: fix memory leaks in NVM commands >>> net/bnxt: fix lock release on NVM write failure >>> net/bnxt: check access denied for HWRM commands >>> net/bnxt: fix RETA size >>>=20 >>> Alejandro Lucero (1): >>> net/nfp: fix field initialization in Tx descriptor >>>=20 >>> Alok Makhariya (1): >>> bus/dpaa: fix phandle support for Linux 4.16 >>>=20 >>> Anatoly Burakov (8): >>> eal/linux: fix invalid syntax in interrupts >>> eal/linux: fix uninitialized value >>> test: fix EAL flags autotest on FreeBSD >>> test: fix result printing >>> test: fix code on report >>> test: make autotest runner python 2/3 compliant >>> test: print autotest categories >>> test: improve filtering >>>=20 >>> Andrew Rybchenko (2): >>> net/sfc: cut non VLAN ID bits from TCI >>> net/sfc: fix assert in set multicast address list >>>=20 >>> Andy Green (1): >>> ring: fix sign conversion warning >>>=20 >>> Beilei Xing (3): >>> net/i40e: fix shifts of 32-bit value >>> net/i40e: fix packet type parsing with DDP >>> net/i40e: fix setting TPID with AQ command >>>=20 >>> Bruce Richardson (2): >>> examples/exception_path: fix out-of-bounds read >>> mk: fix permissions when using make install >>>=20 >>> Chas Williams (2): >>> net/bonding: always update bonding link status >>> net/bonding: do not clear active slave count >>>=20 >>> Dan Gora (1): >>> kni: fix crash with null name >>>=20 >>> Daria Kolistratova (1): >>> net/ena: fix SIGFPE with 0 Rx queue >>>=20 >>> Dariusz Stojaczyk (1): >>> eal: fix return codes on thread naming failure >>>=20 >>> David Marchand (1): >>> net/bnxt: add missing ids in xstats >>>=20 >>> Drocula Lambda (1): >>> kni: fix build on RHEL 7.5 >>>=20 >>> Ferruh Yigit (2): >>> kni: fix build with gcc 8.1 >>> net/thunderx: fix build with gcc optimization on >>>=20 >>> Gavin Hu (3): >>> mk: fix cross build >>> net/dpaa2: remove loop for unused pool entries >>> maintainers: claim maintainership for ARM v7 and v8 >>>=20 >>> Haiyue Wang (1): >>> net/i40e: workaround performance degradation >>>=20 >>> Harry van Haaren (1): >>> event: fix ring init failure handling >>>=20 >>> Hemant Agrawal (2): >>> test/crypto: fix device id when stopping port >>> bus/dpaa: fix buffer offset setting in FMAN >>>=20 >>> Hyong Youb Kim (1): >>> net/enic: do not overwrite admin Tx queue limit >>>=20 >>> Ido Goshen (1): >>> net/pcap: fix multiple queues >>>=20 >>> Jananee Parthasarathy (1): >>> mk: update targets for classified tests >>>=20 >>> Jay Ding (1): >>> net/bnxt: check for invalid vNIC id >>>=20 >>> Jerin Jacob (2): >>> ethdev: fix queue statistics mapping documentation >>> eal: fix bitmap documentation >>>=20 >>> Kiran Kumar (2): >>> net/bonding: fix MAC address reset >>> net/thunderx: avoid sq door bell write on zero packet >>>=20 >>> Konstantin Ananyev (3): >>> examples/ipsec-secgw: fix IPv4 checksum at Tx >>> examples/ipsec-secgw: fix bypass rule processing >>> app/testpmd: fix DCB config >>>=20 >>> Maxime Coquelin (4): >>> vhost: improve dirty pages logging performance >>> vhost: fix missing increment of log cache count >>> vhost: flush IOTLB cache on new mem table handling >>> vhost: retranslate vring addr when memory table changes >>>=20 >>> Moti Haimovsky (2): >>> net/mlx5: fix build with old kernels >>> net/mlx4: check RSS queues number limitation >>>=20 >>> Nelio Laranjeiro (1): >>> net/mlx5: fix TCI mask filter >>>=20 >>> Nikhil Rao (5): >>> eventdev: fix port in Rx adapter internal function >>> eventdev: fix missing update to Rx adaper WRR position >>> eventdev: add event buffer flush in Rx adapter >>> eventdev: fix internal port logic in Rx adapter >>> eventdev: fix Rx SW adapter stop >>>=20 >>> Nithin Dabilpuram (1): >>> app/testpmd: fix buffer leak in TM command >>>=20 >>> Ophir Munk (1): >>> net/mlx5: fix secondary process resource leakage >>>=20 >>> Pablo de Lara (7): >>> examples/l2fwd-crypto: fix digest with AEAD algo >>> examples/l2fwd-crypto: check return value on IV size check >>> examples/l2fwd-crypto: skip device not supporting operation >>> test/hash: fix multiwriter with non consecutive cores >>> test/hash: fix potential memory leak >>> app/crypto-perf: fix auth IV offset >>> hash: fix doxygen of return values >>>=20 >>> Pavan Nikhilesh (2): >>> event/octeontx: remove unnecessary port start and stop >>> net/octeontx: fix stop clearing Rx/Tx functions >>>=20 >>> Qi Zhang (1): >>> vfio: fix PCI address comparison >>>=20 >>> Radu Nicolau (3): >>> security: fix crash on destroy null session >>> test: fix uninitialized port configuration >>> net/bonding: fix race condition >>>=20 >>> Rafal Kozik (4): >>> net/ena: fix GENMASK_ULL macro >>> net/ena: set link speed as none >>> net/ena: check pointer before memset >>> net/ena: change memory type >>>=20 >>> Rahul Lakkireddy (1): >>> net/cxgbe: fix init failure due to new flash parts >>>=20 >>> Rami Rosen (2): >>> examples/l3fwd: remove useless include >>> ethdev: fix a doxygen comment for port allocation >>>=20 >>> Rasesh Mody (9): >>> net/qede: fix VF MTU update >>> net/qede: remove primary MAC removal >>> net/qede: fix for devargs >>> net/qede: fix default extended VLAN offload config >>> doc: update qede management firmware guide >>> net/qede/base: fix GRC attention callback >>> net/bnx2x: fix FW command timeout during stop >>> net/bnx2x: fix poll link status >>> net/qede/base: fix to clear HW indication >>>=20 >>> Remy Horton (4): >>> bitrate: add sanity check on parameters >>> metrics: add check for invalid key >>> metrics: do not fail silently when uninitialised >>> metrics: disallow null as metric name >>>=20 >>> Reshma Pattan (2): >>> test/flow_classify: fix return types >>> mk: remove unnecessary test rules >>>=20 >>> Rosen Xu (1): >>> examples/flow_filtering: add flow director config for i40e >>>=20 >>> Shahaf Shuler (1): >>> net/mlx5: fix compilation for rdma-core v19 >>>=20 >>> Shahed Shaikh (7): >>> net/qede: fix link change event notification >>> net/qede: fix legacy interrupt mode >>> net/qede: fix incorrect link status update >>> net/qede: fix unicast MAC address handling in VF >>> net/qede: fix interrupt handler unregister >>> net/qede: fix MAC address removal failure message >>> net/qede: fix ntuple filter configuration >>>=20 >>> Shreyansh Jain (1): >>> doc: fix bonding command in testpmd >>>=20 >>> Somnath Kotur (3): >>> net/bnxt: fix to move a flow to a different queue >>> net/bnxt: use correct flags during VLAN configuration >>> net/bnxt: fix filter freeing >>>=20 >>> Thomas Monjalon (1): >>> bus/dpaa: fix build >>>=20 >>> Tomasz Duszynski (1): >>> net/mvpp2: check pointer before using it >>>=20 >>> Wei Zhao (7): >>> net/ixgbe: add support for VLAN in IP mode FDIR >>> net/ixgbe: fix tunnel id format error for FDIR >>> net/ixgbe: fix tunnel type set error for FDIR >>> net/ixgbe: fix mask bits register set error for FDIR >>> app/testpmd: fix VLAN TCI mask set error for FDIR >>> net/i40e: fix check of flow director programming status >>> net/i40e: revert fix of flow director check >>>=20 >>> Xiaoyun Li (1): >>> net/i40e: fix link speed >>>=20 >>> Xueming Li (1): >>> net/mlx5: fix crash in device probe >>>=20 >>> Yipeng Wang (3): >>> hash: fix multiwriter lock memory allocation >>> hash: fix a multi-writer race condition >>> hash: fix key slot size accuracy >>>=20 >>> Yongseok Koh (7): >>> net/mlx5: fix Rx buffer replenishment threshold >>> net/mlx5: add missing sanity checks for Tx completion queue >>> net/mlx5: fix assert for Tx completion queue count >>> net/mlx5: fix queue rollback when starting device >>> net/mlx5: fix error number handling >>> net/mlx5: preserve promiscuous flag for flow isolation mode >>> net/mlx5: preserve allmulticast flag for flow isolation mode >>>=20