From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8717F41E88; Tue, 14 Mar 2023 03:24:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F5F2410D1; Tue, 14 Mar 2023 03:24:17 +0100 (CET) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id 98F5240F16 for ; Tue, 14 Mar 2023 03:24:15 +0100 (CET) Received: by mail-pl1-f173.google.com with SMTP id h8so15068836plf.10 for ; Mon, 13 Mar 2023 19:24:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678760655; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:from:to:cc:subject:date:message-id :reply-to; bh=zrq2NSbRwmCHgOtGnEzo5X6J9eSKl3Z5VYnjBKflfnA=; b=og7dZroluMdBSLxqk876Wwz8vOYo7cY4yKRrArM3+/6pw4dXc/ZT5OYhGrZHbtQNH0 4os75Za5wTfm8Pk86h4z+RuFx65+u/tfU3oSulgUG7NwYuw/Qc6btlD4VXyc61TTfVYa TkOiYW5oAL0gMzGXyt7BC+sbJvOPjC0BKAtbdMXTnSsSdf9YjkHlDkJMmUmZw1in/Kxg iRbKtUVHmSosLcPmxa7o3B2WbYvLBIw2TUlOCk4xs+nB3w6laL4qZ+QKxPUhaOF8m0IH +PUPzoS3ADWbO7kRO27YoqvtJvIPXbYfaUEaQZsNLABF1csrq6bsMpdyiekpsvalPgF1 RDQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678760655; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zrq2NSbRwmCHgOtGnEzo5X6J9eSKl3Z5VYnjBKflfnA=; b=bhqWheqGXtKgv24WAhpNImO/lwjm4xdeTVm2o0Bpv4r4dpNfd90rM+KD1HdXq70bvx 7o2Zmdasqwclk/5IBrAM5CxjJYyBZR1PmvVlRbTVleCoYnXcuEn2D94bG4cM9gUQpNAD P6zaebj6fp08Hg7tHc0XTg9Tv+KIX7Fo5Xo0sgZvvR5502OOobhelWUHLNjd+zld4hqk dEAMn092UIP9jL6Fz3h983KbD0f29cnnwHvgWyIZIHra5CCPG78bB3X7GzMP7XdC6vVC O8OmLdyj+WmGeQX7NmFAoHv47ceWP4IB5tnbCFYGIqfRb7qYdTlcMhs9qXlwIC9BWM0G v65Q== X-Gm-Message-State: AO0yUKU9jDvIr5272rTfa46c4FRQuL8Lz3Ma2n27Lv2tOfqlEC9mOwKZ YJ4e82RVUgAxvcb6V+t50dU= X-Google-Smtp-Source: AK7set8G1q+UHe1JVBWBmZDjFolBcvoO2llPu8VgZUV2O+2Txg6rExW7JPv7SVuY1vTdN2wEsOy3wQ== X-Received: by 2002:a17:90b:3881:b0:234:409:9752 with SMTP id mu1-20020a17090b388100b0023404099752mr35707565pjb.25.1678760654679; Mon, 13 Mar 2023 19:24:14 -0700 (PDT) Received: from smtpclient.apple (65.49.198.103.16clouds.com. [65.49.198.103]) by smtp.gmail.com with ESMTPSA id m11-20020a17090a7f8b00b0023a71a06c86sm500329pjl.29.2023.03.13.19.24.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Mar 2023 19:24:14 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: =?utf-8?B?6ams5bCU5pav?= Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v4] lib/bpf: Rename bpf function names to avoid potential conflict with libpcap Date: Tue, 14 Mar 2023 10:21:40 +0800 Message-Id: References: <20230313102226.29c84784@hermes.local> Cc: Konstantin Ananyev , Konstantin Ananyev , dev@dpdk.org, thomas@monjalon.net, Ruifeng Wang In-Reply-To: <20230313102226.29c84784@hermes.local> To: Stephen Hemminger X-Mailer: iPhone Mail (20D67) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Ok, that was my mistake. I=E2=80=99ll send the new patch later :) Sent from my iPhone > On Mar 14, 2023, at 01:22, Stephen Hemminger w= rote: >=20 > =EF=BB=BFOn Mon, 13 Mar 2023 17:07:29 +0000 > Konstantin Ananyev wrote: >=20 >>> I've read the libbpf code again and I found some other functions with >>> pure 'bpf_' prefix. Should we rename all the functions whose names >>> start with pure 'bpf_'? =20 >>=20 >> I thought you already prefixed all non-static functions in the lib... >> Or do I miss something?=20 >=20 > Right, it was bpf_validate, bpf_jit_XXX that were not prefixed. >=20 > .../build/lib/librte_bpf.a.p $ nm * | grep ' T ' | grep -v 'rte_bpf' > 0000000000000070 T bpf_jit > 0000000000003210 T bpf_jit_x86 > 00000000000021f0 T bpf_validate