From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <changchun.ouyang@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 3FF45593A
 for <dev@dpdk.org>; Thu, 22 May 2014 17:41:47 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga101.jf.intel.com with ESMTP; 22 May 2014 08:41:56 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.98,887,1392192000"; d="scan'208";a="516095863"
Received: from fmsmsx103.amr.corp.intel.com ([10.19.9.34])
 by orsmga001.jf.intel.com with ESMTP; 22 May 2014 08:41:48 -0700
Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by
 FMSMSX103.amr.corp.intel.com (10.19.9.34) with Microsoft SMTP Server (TLS) id
 14.3.123.3; Thu, 22 May 2014 08:41:48 -0700
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
 fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS)
 id 14.3.123.3; Thu, 22 May 2014 08:41:48 -0700
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.190]) by
 SHSMSX101.ccr.corp.intel.com ([169.254.1.7]) with mapi id 14.03.0123.003;
 Thu, 22 May 2014 23:41:46 +0800
From: "Ouyang, Changchun" <changchun.ouyang@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH] [PMD] [VHOST] Revert unnecessary definition
 and fix wrong referring in user space vhost zero copy patches
Thread-Index: AQHPc3RkrY/5mCabZEWVJYv0tj1eYJtHidCAgAEfHZCAA48hgIAAiYDQ
Date: Thu, 22 May 2014 15:41:45 +0000
Message-ID: <F52918179C57134FAEC9EA62FA2F9625117AAC84@shsmsx102.ccr.corp.intel.com>
References: <1400512177-19315-1-git-send-email-changchun.ouyang@intel.com>
 <1478243.AGf3d0Vu1X@xps13>
 <F52918179C57134FAEC9EA62FA2F9625117A9950@shsmsx102.ccr.corp.intel.com>
 <1780795.ydK3nqfa9Z@xps13>
In-Reply-To: <1780795.ydK3nqfa9Z@xps13>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] [PMD] [VHOST] Revert unnecessary definition
 and fix wrong referring in user space vhost zero copy patches
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 22 May 2014 15:41:47 -0000

Hi, Thomas
Thanks very much for your guiding!
Best regards,
Changchun

-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20
Sent: Thursday, May 22, 2014 11:29 PM
To: Ouyang, Changchun
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] [PMD] [VHOST] Revert unnecessary definition=
 and fix wrong referring in user space vhost zero copy patches

Hi Changchun,

Please, it is preferred to answer below the question.

2014-05-20 01:14, Ouyang, Changchun:
> So "[PMD] [VHOST]" in the title should be removed in the cover letter,=20
> right? And in each separate patch letter, it could use "ixgbe:"  or=20
> "examples/vhost:", instead of "[PMD] [VHOST]" Is it right?

Yes, you did right in the v2.

Thanks
--
Thomas


> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, May 20, 2014 12:00 AM
> To: Ouyang, Changchun
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] [PMD] [VHOST] Revert unnecessary definiti=
on
> and fix wrong referring in user space vhost zero copy patches
>=20
> Hi Changchun,
>=20
> 2014-05-19 23:09, Ouyang Changchun:
> > 1. Revert the change of metadata macro definition for referring to
> > headroom space in mbuf; 2. Fix wrongly referring to RX queues number
> > in TX queues start/stop function.
> >=20
> > Signed-off-by: Ouyang Changchun <changchun.ouyang@intel.com>
>=20
> You are fixing commits which are not yet applied.
> Please merge and re-send the whole serie by suffixing with "v2".
>=20
> The title was "[PATCH 0/3] [PMD] [VHOST] *** Support zero copy RX/TX in u=
ser
> space vhost ***" It should be "[PATCH v2 0/3] Support zero copy RX/TX in
> user space vhost"
>=20
> Other notes:
> - please split API and ixgbe changes
> - set a significant title to each patch
> - use prefixes like "ethdev:", "ixgbe:" or "examples/vhost:"
>=20
> In general, this page is a good help:
> 	http://dpdk.org/dev#send
>=20
> Thanks
> --
> Thomas