From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 7316C5A32 for ; Thu, 12 Feb 2015 01:52:54 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 11 Feb 2015 16:52:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,562,1418112000"; d="scan'208";a="650971302" Received: from pgsmsx106.gar.corp.intel.com ([10.221.44.98]) by orsmga001.jf.intel.com with ESMTP; 11 Feb 2015 16:52:52 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by PGSMSX106.gar.corp.intel.com (10.221.44.98) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 12 Feb 2015 08:52:48 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.62]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.46]) with mapi id 14.03.0195.001; Thu, 12 Feb 2015 08:52:47 +0800 From: "Ouyang, Changchun" To: Thomas Monjalon , Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH v4 17/26] virtio: Use port IO to get PCI resource. Thread-Index: AQHQRAXdKnzLoxlegk2pGtV3w1l/GJzqWVgAgACJ35D//6eZgIAAak+AgAAHTgCAATZeYA== Date: Thu, 12 Feb 2015 00:52:47 +0000 Message-ID: References: <1422516249-14596-1-git-send-email-changchun.ouyang@intel.com> <54DB04DF.4040201@6wind.com> <2184198.2u2mViVrxD@xps13> In-Reply-To: <2184198.2u2mViVrxD@xps13> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v4 17/26] virtio: Use port IO to get PCI resource. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Feb 2015 00:52:55 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, February 11, 2015 10:16 PM > To: Stephen Hemminger > Cc: dev@dpdk.org; Vincent JARDIN; Ouyang, Changchun > Subject: Re: [dpdk-dev] [PATCH v4 17/26] virtio: Use port IO to get PCI > resource. >=20 > 2015-02-11 05:50, Stephen Hemminger: > > But driver needs to tell application via driver flags >=20 > I think it's done: > > + pci_dev->intr_handle.type =3D RTE_INTR_HANDLE_UIO; > > + pci_drv->drv_flags |=3D RTE_PCI_DRV_INTR_LSC; >=20 > In my understanding, Changchun chose to use ioports as a fallback if uio = is > not available. Seems OK. Thomas is absolutely correct! :-) And on the other hand, without uio, disable the interrupt in driver flag: + /* can't support lsc interrupt without uio */ + pci_drv->drv_flags &=3D ~RTE_PCI_DRV_INTR_LSC; Thanks Changchun