From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 80993DE4 for ; Wed, 15 Jul 2015 10:38:49 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 15 Jul 2015 01:38:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,479,1432623600"; d="scan'208";a="729217454" Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88]) by orsmga001.jf.intel.com with ESMTP; 15 Jul 2015 01:38:25 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by KMSMSX153.gar.corp.intel.com (172.21.73.88) with Microsoft SMTP Server (TLS) id 14.3.224.2; Wed, 15 Jul 2015 16:36:51 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.165]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.146]) with mapi id 14.03.0224.002; Wed, 15 Jul 2015 16:36:49 +0800 From: "Ouyang, Changchun" To: "Iremonger, Bernard" , "dev@dpdk.org" Thread-Topic: [PATCH 4/5] virtio: free queue memory in virtio_dev_close() Thread-Index: AQHQvjaW2CyFvQoqnEi6U9EIN+HQZ53bwGsw///mDQCAAI7mgA== Date: Wed, 15 Jul 2015 08:36:49 +0000 Message-ID: References: <1436879459-18400-1-git-send-email-bernard.iremonger@intel.com> <1436879459-18400-5-git-send-email-bernard.iremonger@intel.com> <8CEF83825BEC744B83065625E567D7C204A48FD6@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C204A48FD6@IRSMSX108.ger.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 4/5] virtio: free queue memory in virtio_dev_close() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2015 08:38:50 -0000 Hi, Bernard > -----Original Message----- > From: Iremonger, Bernard > Sent: Wednesday, July 15, 2015 4:02 PM > To: Ouyang, Changchun; dev@dpdk.org > Cc: Xu, Qian Q; stephen@networkplumber.org > Subject: RE: [PATCH 4/5] virtio: free queue memory in virtio_dev_close() >=20 > Hi Ouyang, >=20 > >=20 > > > --- a/drivers/net/virtio/virtio_ethdev.c > > > +++ b/drivers/net/virtio/virtio_ethdev.c > > > @@ -438,6 +438,24 @@ virtio_dev_cq_queue_setup(struct rte_eth_dev > > > *dev, uint16_t vtpci_queue_idx, } > > > > > > static void > > > +virtio_free_queues(struct rte_eth_dev *dev) { > > > + unsigned int i; > > > + > > > + for (i =3D 0; i < dev->data->nb_rx_queues; i++) { > > > + virtio_dev_rx_queue_release(dev->data->rx_queues[i]); > > > + dev->data->rx_queues[i] =3D NULL; > > > + } > > > + dev->data->nb_rx_queues =3D 0; > > > + > > > + for (i =3D 0; i < dev->data->nb_tx_queues; i++) { > > > + virtio_dev_tx_queue_release(dev->data->tx_queues[i]); > > > + dev->data->tx_queues[i] =3D NULL; > > > + } > > > + dev->data->nb_tx_queues =3D 0; > > > +} > > > + > > > +static void > > > virtio_dev_close(struct rte_eth_dev *dev) { > > > struct virtio_hw *hw =3D dev->data->dev_private; @@ -451,6 +469,7 > > @@ > > > virtio_dev_close(struct rte_eth_dev *dev) > > > vtpci_reset(hw); > > > hw->started =3D 0; > > > virtio_dev_free_mbufs(dev); > > > + virtio_free_queues(dev); > > > > Validate it with vhost sample or not for this change? >=20 > I have tested this change with testpmd on a Fedora VM. I think we should make sure it will not break any current test case for vir= tio, So before applying it, it needs use vhost sample on host and test the virti= o driver on guest. Thanks Changchun =20