* [dpdk-dev] [PATCH 1/3] compress/isal: fix logtype name
@ 2018-07-11 6:38 Pablo de Lara
2018-07-11 6:38 ` [dpdk-dev] [PATCH 2/3] compress/isal: set null pointer after freeing Pablo de Lara
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Pablo de Lara @ 2018-07-11 6:38 UTC (permalink / raw)
To: lee.daly; +Cc: dev, Pablo de Lara, stable
There is a naming convention for logtypes of PMDs:
"pmd.driverType.driverName".
Therefore, the logtype for ISA-L PMD should be "pmd.compress.isal".
Fixes: 490e725b95b2 ("compress/isal: add device init and de-init")
Cc: stable@dpdk.org
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
drivers/compress/isal/isal_compress_pmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/compress/isal/isal_compress_pmd.c b/drivers/compress/isal/isal_compress_pmd.c
index 0f025a3bf..a3b28f29b 100644
--- a/drivers/compress/isal/isal_compress_pmd.c
+++ b/drivers/compress/isal/isal_compress_pmd.c
@@ -465,7 +465,7 @@ RTE_INIT(isal_init_log);
static void
isal_init_log(void)
{
- isal_logtype_driver = rte_log_register("comp_isal");
+ isal_logtype_driver = rte_log_register("pmd.compress.isal");
if (isal_logtype_driver >= 0)
rte_log_set_level(isal_logtype_driver, RTE_LOG_INFO);
}
--
2.14.4
^ permalink raw reply [flat|nested] 7+ messages in thread* [dpdk-dev] [PATCH 2/3] compress/isal: set null pointer after freeing
2018-07-11 6:38 [dpdk-dev] [PATCH 1/3] compress/isal: fix logtype name Pablo de Lara
@ 2018-07-11 6:38 ` Pablo de Lara
2018-07-11 16:14 ` Daly, Lee
2018-07-11 6:38 ` [dpdk-dev] [PATCH 3/3] compress/isal: fix memory leak Pablo de Lara
2018-07-11 16:14 ` [dpdk-dev] [PATCH 1/3] compress/isal: fix logtype name Daly, Lee
2 siblings, 1 reply; 7+ messages in thread
From: Pablo de Lara @ 2018-07-11 6:38 UTC (permalink / raw)
To: lee.daly; +Cc: dev, Pablo de Lara, stable
Fixes: b0e23c458a6f ("compress/isal: add queue pair related ops")
Cc: stable@dpdk.org
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
drivers/compress/isal/isal_compress_pmd_ops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c b/drivers/compress/isal/isal_compress_pmd_ops.c
index 585f22802..0738fb9c4 100644
--- a/drivers/compress/isal/isal_compress_pmd_ops.c
+++ b/drivers/compress/isal/isal_compress_pmd_ops.c
@@ -167,8 +167,8 @@ isal_comp_pmd_qp_release(struct rte_compressdev *dev, uint16_t qp_id)
if (qp->state != NULL)
rte_free(qp->state);
- if (dev->data->queue_pairs[qp_id] != NULL)
- rte_free(dev->data->queue_pairs[qp_id]);
+ rte_free(qp);
+ dev->data->queue_pairs[qp_id] = NULL;
return 0;
}
--
2.14.4
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH 2/3] compress/isal: set null pointer after freeing
2018-07-11 6:38 ` [dpdk-dev] [PATCH 2/3] compress/isal: set null pointer after freeing Pablo de Lara
@ 2018-07-11 16:14 ` Daly, Lee
0 siblings, 0 replies; 7+ messages in thread
From: Daly, Lee @ 2018-07-11 16:14 UTC (permalink / raw)
To: De Lara Guarch, Pablo; +Cc: dev, stable
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Wednesday, July 11, 2018 7:39 AM
> To: Daly, Lee <lee.daly@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> stable@dpdk.org
> Subject: [PATCH 2/3] compress/isal: set null pointer after freeing
>
> Fixes: b0e23c458a6f ("compress/isal: add queue pair related ops")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> drivers/compress/isal/isal_compress_pmd_ops.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c
> b/drivers/compress/isal/isal_compress_pmd_ops.c
> index 585f22802..0738fb9c4 100644
> --- a/drivers/compress/isal/isal_compress_pmd_ops.c
> +++ b/drivers/compress/isal/isal_compress_pmd_ops.c
> @@ -167,8 +167,8 @@ isal_comp_pmd_qp_release(struct rte_compressdev
> *dev, uint16_t qp_id)
> if (qp->state != NULL)
> rte_free(qp->state);
>
> - if (dev->data->queue_pairs[qp_id] != NULL)
> - rte_free(dev->data->queue_pairs[qp_id]);
> + rte_free(qp);
> + dev->data->queue_pairs[qp_id] = NULL;
>
> return 0;
> }
> --
> 2.14.4
Acked-by: Lee Daly <lee.daly@intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-dev] [PATCH 3/3] compress/isal: fix memory leak
2018-07-11 6:38 [dpdk-dev] [PATCH 1/3] compress/isal: fix logtype name Pablo de Lara
2018-07-11 6:38 ` [dpdk-dev] [PATCH 2/3] compress/isal: set null pointer after freeing Pablo de Lara
@ 2018-07-11 6:38 ` Pablo de Lara
2018-07-11 16:13 ` Daly, Lee
2018-07-11 16:14 ` [dpdk-dev] [PATCH 1/3] compress/isal: fix logtype name Daly, Lee
2 siblings, 1 reply; 7+ messages in thread
From: Pablo de Lara @ 2018-07-11 6:38 UTC (permalink / raw)
To: lee.daly; +Cc: dev, Pablo de Lara, stable
Processed operations ring is created for each queue pair,
but it was not being freed when the queue pair was released.
Fixes: b0e23c458a6f ("compress/isal: add queue pair related ops")
Cc: stable@dpdk.org
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
drivers/compress/isal/isal_compress_pmd_ops.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c b/drivers/compress/isal/isal_compress_pmd_ops.c
index 0738fb9c4..c61acd40c 100644
--- a/drivers/compress/isal/isal_compress_pmd_ops.c
+++ b/drivers/compress/isal/isal_compress_pmd_ops.c
@@ -167,6 +167,9 @@ isal_comp_pmd_qp_release(struct rte_compressdev *dev, uint16_t qp_id)
if (qp->state != NULL)
rte_free(qp->state);
+ if (qp->processed_pkts != NULL)
+ rte_ring_free(qp->processed_pkts);
+
rte_free(qp);
dev->data->queue_pairs[qp_id] = NULL;
--
2.14.4
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH 3/3] compress/isal: fix memory leak
2018-07-11 6:38 ` [dpdk-dev] [PATCH 3/3] compress/isal: fix memory leak Pablo de Lara
@ 2018-07-11 16:13 ` Daly, Lee
0 siblings, 0 replies; 7+ messages in thread
From: Daly, Lee @ 2018-07-11 16:13 UTC (permalink / raw)
To: De Lara Guarch, Pablo; +Cc: dev, stable
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Wednesday, July 11, 2018 7:39 AM
> To: Daly, Lee <lee.daly@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> stable@dpdk.org
> Subject: [PATCH 3/3] compress/isal: fix memory leak
>
> Processed operations ring is created for each queue pair, but it was not being
> freed when the queue pair was released.
>
> Fixes: b0e23c458a6f ("compress/isal: add queue pair related ops")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> drivers/compress/isal/isal_compress_pmd_ops.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c
> b/drivers/compress/isal/isal_compress_pmd_ops.c
> index 0738fb9c4..c61acd40c 100644
> --- a/drivers/compress/isal/isal_compress_pmd_ops.c
> +++ b/drivers/compress/isal/isal_compress_pmd_ops.c
> @@ -167,6 +167,9 @@ isal_comp_pmd_qp_release(struct rte_compressdev
> *dev, uint16_t qp_id)
> if (qp->state != NULL)
> rte_free(qp->state);
>
> + if (qp->processed_pkts != NULL)
> + rte_ring_free(qp->processed_pkts);
> +
> rte_free(qp);
> dev->data->queue_pairs[qp_id] = NULL;
>
> --
> 2.14.4
Acked-by: Lee Daly <lee.daly@intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH 1/3] compress/isal: fix logtype name
2018-07-11 6:38 [dpdk-dev] [PATCH 1/3] compress/isal: fix logtype name Pablo de Lara
2018-07-11 6:38 ` [dpdk-dev] [PATCH 2/3] compress/isal: set null pointer after freeing Pablo de Lara
2018-07-11 6:38 ` [dpdk-dev] [PATCH 3/3] compress/isal: fix memory leak Pablo de Lara
@ 2018-07-11 16:14 ` Daly, Lee
2018-07-13 14:40 ` De Lara Guarch, Pablo
2 siblings, 1 reply; 7+ messages in thread
From: Daly, Lee @ 2018-07-11 16:14 UTC (permalink / raw)
To: De Lara Guarch, Pablo; +Cc: dev, stable
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Wednesday, July 11, 2018 7:39 AM
> To: Daly, Lee <lee.daly@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> stable@dpdk.org
> Subject: [PATCH 1/3] compress/isal: fix logtype name
>
> There is a naming convention for logtypes of PMDs:
> "pmd.driverType.driverName".
> Therefore, the logtype for ISA-L PMD should be "pmd.compress.isal".
>
> Fixes: 490e725b95b2 ("compress/isal: add device init and de-init")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> drivers/compress/isal/isal_compress_pmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/compress/isal/isal_compress_pmd.c
> b/drivers/compress/isal/isal_compress_pmd.c
> index 0f025a3bf..a3b28f29b 100644
> --- a/drivers/compress/isal/isal_compress_pmd.c
> +++ b/drivers/compress/isal/isal_compress_pmd.c
> @@ -465,7 +465,7 @@ RTE_INIT(isal_init_log); static void
> isal_init_log(void)
> {
> - isal_logtype_driver = rte_log_register("comp_isal");
> + isal_logtype_driver = rte_log_register("pmd.compress.isal");
> if (isal_logtype_driver >= 0)
> rte_log_set_level(isal_logtype_driver, RTE_LOG_INFO); }
> --
> 2.14.4
Acked-by: Lee Daly <lee.daly@intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH 1/3] compress/isal: fix logtype name
2018-07-11 16:14 ` [dpdk-dev] [PATCH 1/3] compress/isal: fix logtype name Daly, Lee
@ 2018-07-13 14:40 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 7+ messages in thread
From: De Lara Guarch, Pablo @ 2018-07-13 14:40 UTC (permalink / raw)
To: Daly, Lee; +Cc: dev, stable
> -----Original Message-----
> From: Daly, Lee
> Sent: Wednesday, July 11, 2018 5:15 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH 1/3] compress/isal: fix logtype name
>
>
>
> > -----Original Message-----
> > From: De Lara Guarch, Pablo
> > Sent: Wednesday, July 11, 2018 7:39 AM
> > To: Daly, Lee <lee.daly@intel.com>
> > Cc: dev@dpdk.org; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>; stable@dpdk.org
> > Subject: [PATCH 1/3] compress/isal: fix logtype name
> >
> > There is a naming convention for logtypes of PMDs:
> > "pmd.driverType.driverName".
> > Therefore, the logtype for ISA-L PMD should be "pmd.compress.isal".
> >
> > Fixes: 490e725b95b2 ("compress/isal: add device init and de-init")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> > drivers/compress/isal/isal_compress_pmd.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/compress/isal/isal_compress_pmd.c
> > b/drivers/compress/isal/isal_compress_pmd.c
> > index 0f025a3bf..a3b28f29b 100644
> > --- a/drivers/compress/isal/isal_compress_pmd.c
> > +++ b/drivers/compress/isal/isal_compress_pmd.c
> > @@ -465,7 +465,7 @@ RTE_INIT(isal_init_log); static void
> > isal_init_log(void)
> > {
> > - isal_logtype_driver = rte_log_register("comp_isal");
> > + isal_logtype_driver = rte_log_register("pmd.compress.isal");
> > if (isal_logtype_driver >= 0)
> > rte_log_set_level(isal_logtype_driver, RTE_LOG_INFO); }
> > --
> > 2.14.4
> Acked-by: Lee Daly <lee.daly@intel.com>
Series applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-07-13 14:40 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-11 6:38 [dpdk-dev] [PATCH 1/3] compress/isal: fix logtype name Pablo de Lara
2018-07-11 6:38 ` [dpdk-dev] [PATCH 2/3] compress/isal: set null pointer after freeing Pablo de Lara
2018-07-11 16:14 ` Daly, Lee
2018-07-11 6:38 ` [dpdk-dev] [PATCH 3/3] compress/isal: fix memory leak Pablo de Lara
2018-07-11 16:13 ` Daly, Lee
2018-07-11 16:14 ` [dpdk-dev] [PATCH 1/3] compress/isal: fix logtype name Daly, Lee
2018-07-13 14:40 ` De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).