From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2E68DA05D3 for ; Tue, 21 May 2019 17:07:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CD72E5911; Tue, 21 May 2019 17:07:35 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 6038158EC for ; Tue, 21 May 2019 17:07:34 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 May 2019 08:07:33 -0700 X-ExtLoop1: 1 Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga001.fm.intel.com with ESMTP; 21 May 2019 08:07:32 -0700 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.166]) by IRSMSX107.ger.corp.intel.com ([169.254.10.142]) with mapi id 14.03.0415.000; Tue, 21 May 2019 16:07:31 +0100 From: "Daly, Lee" To: Stephen Hemminger CC: "dev@dpdk.org" , "Trahe, Fiona" Thread-Topic: [PATCH] compress/isal: fix use after free Thread-Index: AQHVD+QbNV57GiScK0K7dkIs/MIprqZ1rYEw Date: Tue, 21 May 2019 15:07:30 +0000 Message-ID: References: <20190521144713.12046-1-stephen@networkplumber.org> In-Reply-To: <20190521144713.12046-1-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzcxMzcxN2YtN2Q5OC00YjRiLWE2ZTktM2FjNzUwZTNlMGQ4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQ3duYlY4NFNVSmZBRTJQTEJCWUw1U2RYQXJQUGJSY2JMVGppdUxmWVRVNlZHQU9HVXo5MWZBU2ZsdjdDczRUbyJ9 x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] compress/isal: fix use after free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Stephen,=20 Thanks for the patch. > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Tuesday, May 21, 2019 3:47 PM > To: Daly, Lee > Cc: dev@dpdk.org; Stephen Hemminger > Subject: [PATCH] compress/isal: fix use after free >=20 > The release function was using qp->stream after already releasing it and = the > null pointer checking was missing. >=20 > Also since rte_free(NULL) is a no-op, remove unnecessary checks for NULL. >=20 > Coverity issure: 340860 > Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression functionality"= ) > Signed-off-by: Stephen Hemminger > --- > drivers/compress/isal/isal_compress_pmd_ops.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) >=20 > diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c Acked-by: Lee Daly