From: "Daly, Lee" <lee.daly@intel.com>
To: "Dybkowski, AdamX" <adamx.dybkowski@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Trahe, Fiona" <fiona.trahe@intel.com>,
"Luse, Paul E" <paul.e.luse@intel.com>
Cc: "Dybkowski, AdamX" <adamx.dybkowski@intel.com>
Subject: Re: [dpdk-dev] [PATCH] compress/isal: create shorter qp name
Date: Tue, 6 Aug 2019 09:27:41 +0000 [thread overview]
Message-ID: <F5C6929789601049BEB7272E267355989EDC1B@IRSMSX106.ger.corp.intel.com> (raw)
In-Reply-To: <20190806090954.15807-1-adamx.dybkowski@intel.com>
Hi Adam,
Take care to add the maintainer of the code you are changing to your email, a list can be found in the MAINTAINERS file.
This will hopefully ensure a response to the change.
Thanks.
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Adam Dybkowski
> Sent: Tuesday, August 6, 2019 10:10 AM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Luse, Paul E
> <paul.e.luse@intel.com>
> Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Subject: [dpdk-dev] [PATCH] compress/isal: create shorter qp name
>
> This patch shortens the queue pair name created when initializing the queue
> pair of the ISAL PIM, based on the device and qp ids.
> The patch idea of shortening the queue pair name was proposed by Luse,
> Paul E <<paul.e.luse@intel.com>
>
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> ---
> drivers/compress/isal/isal_compress_pmd_ops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c
> b/drivers/compress/isal/isal_compress_pmd_ops.c
> index 77ac6fcf2..31c455991 100644
> --- a/drivers/compress/isal/isal_compress_pmd_ops.c
> +++ b/drivers/compress/isal/isal_compress_pmd_ops.c
> @@ -216,7 +216,7 @@ isal_comp_pmd_qp_set_unique_name(struct
> rte_compressdev *dev, struct isal_comp_qp *qp) {
> unsigned int n = snprintf(qp->name, sizeof(qp->name),
> - "isal_compression_pmd_%u_qp_%u",
> + "isal_comp_pmd_%u_qp_%u",
> dev->data->dev_id, qp->id);
>
> if (n >= sizeof(qp->name))
> --
> 2.17.1
Acked-by: Lee Daly <lee.daly@intel.com>
next prev parent reply other threads:[~2019-08-06 9:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 9:09 Adam Dybkowski
2019-08-06 9:27 ` Daly, Lee [this message]
2019-08-06 9:33 ` Dybkowski, AdamX
2019-09-10 15:29 ` Trahe, Fiona
2019-09-19 14:50 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F5C6929789601049BEB7272E267355989EDC1B@IRSMSX106.ger.corp.intel.com \
--to=lee.daly@intel.com \
--cc=adamx.dybkowski@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=paul.e.luse@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).