From: "Daly, Lee" <lee.daly@intel.com>
To: Hajkowski <marcinx.hajkowski@intel.com>,
"Hunt, David" <david.hunt@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"'Hajkowski, MarcinX'" <marcinx.hajkowski@intel.com>
Subject: Re: [dpdk-dev] [PATCH 3/3] examples/power_guest: send request for specified core capabilities
Date: Mon, 30 Sep 2019 12:54:38 +0000 [thread overview]
Message-ID: <F5C6929789601049BEB7272E26735598A5FB0D@IRSMSX106.ger.corp.intel.com> (raw)
In-Reply-To: <20190530161517.11916-4-marcinx.hajkowski@intel.com>
> -----Original Message-----
> From: Daly, Lee
> Sent: Monday, September 30, 2019 11:55 AM
> To: 'Hajkowski' <marcinx.hajkowski@intel.com>; Hunt, David
> <david.hunt@intel.com>
> Cc: dev@dpdk.org; Hajkowski, MarcinX <marcinx.hajkowski@intel.com>
> Subject: RE: [dpdk-dev] [PATCH 3/3] examples/power_guest: send request
> for specified core capabilities
>
> Hi dave,
> See comments below.
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hajkowski
> > Sent: Thursday, May 30, 2019 5:15 PM
> > To: Hunt, David <david.hunt@intel.com>
> > Cc: dev@dpdk.org; Hajkowski, MarcinX <marcinx.hajkowski@intel.com>
> > Subject: [dpdk-dev] [PATCH 3/3] examples/power_guest: send request for
> > specified core capabilities
> >
> > From: Marcin Hajkowski <marcinx.hajkowski@intel.com>
> >
> > Send request to power manager for core id provided by user to get
> > related capabilities.
> >
> > Signed-off-by: Marcin Hajkowski <marcinx.hajkowski@intel.com>
> > ---
> > .../guest_cli/vm_power_cli_guest.c | 119 +++++++++++++++++-
> > 1 file changed, 117 insertions(+), 2 deletions(-)
> >
> > diff --git
> a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
> > b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
> > index 848230248..de85c1406 100644
> > --- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
> > +++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
> ));
> > +
> > + if (!strcmp(res->cpu_num, "all")) {
> > +
> > + /* Get first enabled lcore. */
> > + lcore_id = rte_get_next_lcore(-1,
> > + 0,
> > + 0);
> > + if (lcore_id == RTE_MAX_LCORE) {
> > + cmdline_printf(cl, "Enabled core not found.\n");
> > + return;
> > + }
> > +
> > + pkt.command = CPU_POWER_QUERY_CAPS_LIST;
> > + strcpy(pkt.vm_name, policy.vm_name);
> 2 uses of strcpy in this patch, could this be changed to strlcpy().
> /Lee.
Feel free to add my ack after that small change.
Acked-by: Lee Daly <lee.daly@intel.com>
next prev parent reply other threads:[~2019-09-30 12:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 16:15 [dpdk-dev] [PATCH 0/3] Core capabilities query Hajkowski
2019-05-30 16:15 ` [dpdk-dev] [PATCH 1/3] power: add new packet type for capabilities Hajkowski
2019-09-30 10:55 ` Daly, Lee
2019-09-30 13:00 ` [dpdk-dev] [PATCH v2 0/3] Core capabilities query David Hunt
2019-09-30 13:00 ` [dpdk-dev] [PATCH v2 1/3] power: add new packet type for capabilities David Hunt
2019-09-30 13:00 ` [dpdk-dev] [PATCH v2 2/3] examples/power_manager: send cpu capabilities on vm request David Hunt
2019-09-30 13:00 ` [dpdk-dev] [PATCH v2 3/3] examples/power_guest: send request for specified core capabilities David Hunt
2019-09-30 13:04 ` Hunt, David
2019-10-27 20:16 ` [dpdk-dev] [PATCH v2 0/3] Core capabilities query Thomas Monjalon
2019-05-30 16:15 ` [dpdk-dev] [PATCH 2/3] examples/power_manager: send cpu capabilities on vm request Hajkowski
2019-09-30 10:56 ` Daly, Lee
2019-05-30 16:15 ` [dpdk-dev] [PATCH 3/3] examples/power_guest: send request for specified core capabilities Hajkowski
2019-09-30 10:54 ` Daly, Lee
2019-09-30 12:54 ` Daly, Lee [this message]
2019-07-04 19:58 ` [dpdk-dev] [PATCH 0/3] Core capabilities query Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F5C6929789601049BEB7272E26735598A5FB0D@IRSMSX106.ger.corp.intel.com \
--to=lee.daly@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=marcinx.hajkowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).