From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id A66EB106A for ; Mon, 12 Dec 2016 02:28:34 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP; 11 Dec 2016 17:28:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,334,1477983600"; d="scan'208";a="201471656" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 11 Dec 2016 17:28:33 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 11 Dec 2016 17:28:32 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 11 Dec 2016 17:28:32 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.11]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0248.002; Mon, 12 Dec 2016 09:28:28 +0800 From: "Yang, Qiming" To: "Yigit, Ferruh" , "dev@dpdk.org" CC: Thomas Monjalon , "Horton, Remy" Thread-Topic: [dpdk-dev] [PATCH v2 1/5] ethdev: add firmware version get Thread-Index: AQHST5FYpSe3obyaHEiqSJjmOorbx6D9YTQAgAYsQCA= Date: Mon, 12 Dec 2016 01:28:28 +0000 Message-ID: References: <1479375779-46629-2-git-send-email-qiming.yang@intel.com> <1481008582-69416-1-git-send-email-qiming.yang@intel.com> <1481008582-69416-2-git-send-email-qiming.yang@intel.com> <4177103b-21af-403c-ad3f-6ab1fac94903@intel.com> In-Reply-To: <4177103b-21af-403c-ad3f-6ab1fac94903@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTg1NGVhODctY2EwNi00MzcwLTk4NWQtNzZjZTRkNzg2M2ZkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IndcL1pwVnRJd1BxM1hSMDZXY204VjhxUjN5UFc5d3hwYTBEU2ltRnpjcXhrPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/5] ethdev: add firmware version get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Dec 2016 01:28:35 -0000 Hi, Yigit Yes, we had planned to add fw_version in rte_eth_dev_info_get(). But Remy = think we should better to implement this feature through a way don't break = the original ABI. So I change the implement. -----Original Message----- From: Yigit, Ferruh=20 Sent: Thursday, December 8, 2016 7:07 PM To: Yang, Qiming ; dev@dpdk.org Cc: Thomas Monjalon Subject: Re: [dpdk-dev] [PATCH v2 1/5] ethdev: add firmware version get Hi Qiming, On 12/6/2016 7:16 AM, Qiming Yang wrote: > This patch adds a new API 'rte_eth_dev_fwver_get' for fetching=20 > firmware version by a given device. >=20 > Signed-off-by: Qiming Yang <...> > @@ -1444,6 +1448,7 @@ struct eth_dev_ops { > /**< Get names of extended statistics. */ > eth_queue_stats_mapping_set_t queue_stats_mapping_set; > /**< Configure per queue stat counter mapping. */ > + eth_fw_version_get_t fw_version_get; /**< Get firmware version. *= / Hi Qiming, Not sure if I am missing something but this change is for following [1] dep= recation notice, right? If so, notice suggest updating rte_eth_dev_info_get() to include fw_version= , but this patch adds a new eth_dev_ops. Is it agreed to add a new eth_dev_ops for this? [1] * In 17.02 ABI change is planned: the ``rte_eth_dev_info`` structure will be extended with a new member ``fw_version`` in order to store the NIC firmware version. > eth_dev_infos_get_t dev_infos_get; /**< Get device info. */ > eth_dev_supported_ptypes_get_t dev_supported_ptypes_get; > /**< Get packet types supported and identified by device*/ <...>