From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 7C68C2B9C for ; Wed, 4 Jan 2017 03:44:49 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP; 03 Jan 2017 18:44:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,458,1477983600"; d="scan'208";a="49808023" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 03 Jan 2017 18:44:48 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 3 Jan 2017 18:44:47 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 3 Jan 2017 18:44:47 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.177]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0248.002; Wed, 4 Jan 2017 10:44:45 +0800 From: "Yang, Qiming" To: "Yigit, Ferruh" , "dev@dpdk.org" , "thomas.monjalon@6wind.com" CC: "Horton, Remy" Thread-Topic: [PATCH v3 3/4] net/ixgbe: add firmware version get Thread-Index: AQHSYD3DiuRL/TYuM0mLO0UT6tWedKEmXsCAgAFHC3A= Date: Wed, 4 Jan 2017 02:44:45 +0000 Message-ID: References: <1481008582-69416-1-git-send-email-qiming.yang@intel.com> <1482841816-54143-1-git-send-email-qiming.yang@intel.com> <1482841816-54143-4-git-send-email-qiming.yang@intel.com> <9c401d90-0264-8fc8-3733-abb59bfd277e@intel.com> In-Reply-To: <9c401d90-0264-8fc8-3733-abb59bfd277e@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 3/4] net/ixgbe: add firmware version get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2017 02:44:49 -0000 You can see the kernel version ethtool, use command 'ethtool -i ' driver: ixgbe version: 4.2.1-k firmware-version: 0x61bf0001 Ixgbe's FW version do not have the major and minor number, and the original= purpose of this function is get FW version, so I think it's enough.=20 -----Original Message----- From: Yigit, Ferruh=20 Sent: Tuesday, January 3, 2017 11:04 PM To: Yang, Qiming ; dev@dpdk.org; thomas.monjalon@6wi= nd.com Cc: Horton, Remy Subject: Re: [PATCH v3 3/4] net/ixgbe: add firmware version get On 12/27/2016 12:30 PM, Qiming Yang wrote: > This patch add a new function ixgbe_fw_version_get. >=20 > Signed-off-by: Qiming Yang <...> > =20 > static void > +ixgbe_fw_version_get(struct rte_eth_dev *dev, __rte_unused u32 *fw_major= , > + __rte_unused u32 *fw_minor, __rte_unused u32 *fw_patch, u32=20 > +*etrack_id) This API at least provide major and minor fw versions I think. Isn't there = any kind of FW version information for ixgbe? Just providing etrack_id is n= ot looking good. > +{ > + struct ixgbe_hw *hw =3D IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private)= ; > + u16 eeprom_verh, eeprom_verl; > + > + ixgbe_read_eeprom(hw, 0x2e, &eeprom_verh); > + ixgbe_read_eeprom(hw, 0x2d, &eeprom_verl); > + > + *etrack_id =3D (eeprom_verh << 16) | eeprom_verl; } > + > +static void > ixgbe_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info=20 > *dev_info) { > struct rte_pci_device *pci_dev =3D IXGBE_DEV_TO_PCI(dev); >=20