From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 94E9A69FC for ; Wed, 4 Jan 2017 04:33:27 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP; 03 Jan 2017 19:33:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,458,1477983600"; d="scan'208";a="49818483" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 03 Jan 2017 19:33:26 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 3 Jan 2017 19:33:26 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 3 Jan 2017 19:33:25 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.177]) by SHSMSX103.ccr.corp.intel.com ([10.239.4.69]) with mapi id 14.03.0248.002; Wed, 4 Jan 2017 11:33:24 +0800 From: "Yang, Qiming" To: "Yigit, Ferruh" CC: "dev@dpdk.org" , "Horton, Remy" , Thomas Monjalon Thread-Topic: [PATCH v3 1/4] ethdev: add firmware information get Thread-Index: AQHSYD3Bpg4BAr8YOkK3L6NWIZBav6Ek1g6AgAFKypD//9JrAIAAibog///dgYCAAVrNQA== Date: Wed, 4 Jan 2017 03:33:23 +0000 Message-ID: References: <1481008582-69416-1-git-send-email-qiming.yang@intel.com> <20053497.vNKJpYf1IB@xps13> <10603884.vrshqR2O82@xps13> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add firmware information get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2017 03:33:28 -0000 Yes, in my opinion it is. And I use this name already exist in the share co= de from ND team. -----Original Message----- From: Yigit, Ferruh=20 Sent: Tuesday, January 3, 2017 10:49 PM To: Yang, Qiming Cc: dev@dpdk.org; Horton, Remy ; Thomas Monjalon Subject: Re: [PATCH v3 1/4] ethdev: add firmware information get On 1/3/2017 9:05 AM, Yang, Qiming wrote: > Hi, Ferruh > Please see the question below. In my opinion, etrack_id is just a name us= ed to define the ID of one NIC. > In kernel version ethtool, it will print this ID in the line of firmware = verison.=20 > I know what is etrack_id mean, but I really don't know why this named etr= ack_id. Hi Qiming, I suggested the API based on fields you already used in your patch. So, this API is to get FW version, is etrack_id something that defines (par= t of) firmware version? Thanks, ferruh > Can you explain this question? > =20 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, January 3, 2017 4:40 PM > To: Yang, Qiming > Subject: Re: [PATCH v3 1/4] ethdev: add firmware information get >=20 > Please reply below the question and on the mailing list. > You'll have to explain why this name etrack_id. >=20 > 2017-01-03 03:28, Yang, Qiming: >> Hi, Thomas >> etrack_id is not a terminology, it's decided by me. >> Which is store the unique number of the firmware. >> firmware-version: 5.04 0x800024ca >> 800024ca is the etrack_id of this NIC. >> >> -----Original Message----- >> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] >> Sent: Monday, January 2, 2017 11:39 PM >> To: Yang, Qiming >> Cc: dev@dpdk.org; Horton, Remy ; Yigit, Ferruh=20 >> >> Subject: Re: [PATCH v3 1/4] ethdev: add firmware information get >> >> 2016-12-27 20:30, Qiming Yang: >>> /** >>> + * Retrieve the firmware version of a device. >>> + * >>> + * @param port_id >>> + * The port identifier of the device. >>> + * @param fw_major >>> + * A array pointer to store the major firmware version of a device. >>> + * @param fw_minor >>> + * A array pointer to store the minor firmware version of a device. >>> + * @param fw_patch >>> + * A array pointer to store the firmware patch number of a device. >>> + * @param etrack_id >>> + * A array pointer to store the nvm version of a device. >>> + */ >>> +void rte_eth_dev_fw_info_get(uint8_t port_id, uint32_t *fw_major, >>> + uint32_t *fw_minor, uint32_t *fw_patch, uint32_t *etrack_id); >> >> I have a reserve about the naming etrack_id. >> Please could you point to a document explaining this ID? >> Is it known outside of Intel? >=20 >=20