From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 6081E133F for ; Mon, 9 Jan 2017 02:48:21 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP; 08 Jan 2017 17:48:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,338,1477983600"; d="scan'208";a="51506463" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 08 Jan 2017 17:48:19 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 8 Jan 2017 17:48:19 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 8 Jan 2017 17:48:19 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.177]) by shsmsx102.ccr.corp.intel.com ([169.254.2.88]) with mapi id 14.03.0248.002; Mon, 9 Jan 2017 09:48:16 +0800 From: "Yang, Qiming" To: Stephen Hemminger CC: "dev@dpdk.org" , "Yigit, Ferruh" , "Zhang, Helin" , "Horton, Remy" Thread-Topic: [dpdk-dev] [PATCH v5 2/5] net/e1000: add firmware version get Thread-Index: AQHSaWYluvL1FYgIeUGrRSSzaxxXxaEurhCAgACz5cA= Date: Mon, 9 Jan 2017 01:48:15 +0000 Message-ID: References: <1483531428-14481-1-git-send-email-qiming.yang@intel.com> <1483848695-44643-1-git-send-email-qiming.yang@intel.com> <1483848695-44643-3-git-send-email-qiming.yang@intel.com> <20170108150355.3bce1403@xeon-e3> In-Reply-To: <20170108150355.3bce1403@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzk1ZTI0YzktZDQ4ZC00NzI1LWI2YWYtN2M0N2U3MDc5MzBlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik9memhvazJtZzZXdk14c01ldUNEN2t4NDlEQjNZbFo0XC9OVlwveGQ3WUg0ND0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 2/5] net/e1000: add firmware version get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2017 01:48:21 -0000 -----Original Message----- From: Stephen Hemminger [mailto:stephen@networkplumber.org]=20 Sent: Monday, January 9, 2017 7:04 AM To: Yang, Qiming Cc: dev@dpdk.org; Yigit, Ferruh ; Zhang, Helin ; Horton, Remy Subject: Re: [dpdk-dev] [PATCH v5 2/5] net/e1000: add firmware version get On Sun, 8 Jan 2017 12:11:32 +0800 Qiming Yang wrote: > + switch (hw->mac.type) { > + case e1000_i210: > + case e1000_i211: > + if (!(e1000_get_flash_presence_i210(hw))) { > + snprintf(fw_version, fw_length, > + "%2d.%2d-%d", > + fw.invm_major, fw.invm_minor, > + fw.invm_img_type); > + break; > + } > + /* fall through */ > + default: > + /* if option rom is valid, display its version too*/ > + if (fw.or_valid) { > + snprintf(fw_version, fw_length, > + "%d.%d, 0x%08x, %d.%d.%d", > + fw.eep_major, fw.eep_minor, fw.etrack_id, > + fw.or_major, fw.or_build, fw.or_patch); > + /* no option rom */ > + } else { > + if (fw.etrack_id !=3D 0X0000) { > + snprintf(fw_version, fw_length, > + "%d.%d, 0x%08x", > + fw.eep_major, fw.eep_minor, fw.etrack_id); > + } else { > + snprintf(fw_version, fw_length, > + "%d.%d.%d", > + fw.eep_major, fw.eep_minor, fw.eep_build); Indentation is incorrect here. Qiming: my mistake.