From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <qiming.yang@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id C4432689B
 for <dev@dpdk.org>; Thu, 12 Jan 2017 02:25:59 +0100 (CET)
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by orsmga101.jf.intel.com with ESMTP; 11 Jan 2017 17:25:58 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,347,1477983600"; d="scan'208";a="52005316"
Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204])
 by orsmga005.jf.intel.com with ESMTP; 11 Jan 2017 17:25:58 -0800
Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by
 FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Wed, 11 Jan 2017 17:25:58 -0800
Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by
 fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Wed, 11 Jan 2017 17:25:58 -0800
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.177]) by
 SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0248.002;
 Thu, 12 Jan 2017 09:25:56 +0800
From: "Yang, Qiming" <qiming.yang@intel.com>
To: "Horton, Remy" <remy.horton@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Thread-Topic: [PATCH v7 2/5] net/e1000: add firmware version get
Thread-Index: AQHSa9ahlPYInOc46E6txhR2sGQPEaEy5ZcAgAEnvTA=
Date: Thu, 12 Jan 2017 01:25:55 +0000
Message-ID: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16EDCB7CA@SHSMSX101.ccr.corp.intel.com>
References: <1484039333-30074-2-git-send-email-qiming.yang@intel.com>
 <1484116905-57438-1-git-send-email-qiming.yang@intel.com>
 <1484116905-57438-3-git-send-email-qiming.yang@intel.com>
 <2ecd0288-6f58-9f55-48fc-2dc3e4e97983@intel.com>
In-Reply-To: <2ecd0288-6f58-9f55-48fc-2dc3e4e97983@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDRlZmMwNjgtOGQ1NS00NDMyLWE3MDUtMzU5MmQwNjViMzk2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InZTTExQWVlTNkRYc2MrY1lMTWhlSVVOdlkwK1VGNDJHSHdicXYxeTVVeXc9In0=
x-ctpclassification: CTP_IC
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v7 2/5] net/e1000: add firmware version get
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Jan 2017 01:26:00 -0000

-----Original Message-----
From: Horton, Remy=20
Sent: Wednesday, January 11, 2017 11:45 PM
To: Yang, Qiming <qiming.yang@intel.com>; dev@dpdk.org
Cc: Yigit, Ferruh <ferruh.yigit@intel.com>
Subject: Re: [PATCH v7 2/5] net/e1000: add firmware version get


On 11/01/2017 06:41, Qiming Yang wrote:
> This patch adds a new function eth_igb_fw_version_get.
>
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
[..]
> +static int
> +eth_igb_fw_version_get(struct rte_eth_dev *dev, char *fw_version,
> +		       size_t fw_size)
> +{
> +	struct e1000_hw *hw =3D E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private)=
;
> +	struct e1000_fw_version fw;
> +
> +	if (fw_size < 16) {

Magic number. Ought to be #define value (or at least a comment explaining t=
he choice of size)..

Otherwise looking good.. :)

..Remy

Ok, I'll use a macro to define this number. Thanks~
Qiming=20