From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 6FD02D4AE for ; Mon, 27 Mar 2017 03:29:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490578144; x=1522114144; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=zlrIGFdqBVBEDWlsXPKZ3Zg3CADzveYEg0Zq9nXUFNA=; b=Roq3/iK8OO3zDvEw8/IMu8FobtY8w7wQ2GiHDLlyfL06QiOVx0idMSqT 3IDnqzSEbOluc1/GJxXL3nkRbPeWQQ==; Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2017 18:29:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,229,1486454400"; d="scan'208";a="65312786" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 26 Mar 2017 18:29:02 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 26 Mar 2017 18:29:02 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.224]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.82]) with mapi id 14.03.0248.002; Mon, 27 Mar 2017 09:28:59 +0800 From: "Yang, Qiming" To: Olivier Matz CC: "dev@dpdk.org" , "thomas.monjalon@6wind.com" , "Ananyev, Konstantin" , "Lu, Wenzhuo" , "Zhang, Helin" , "Wu, Jingjing" , "adrien.mazarguil@6wind.com" , "nelio.laranjeiro@6wind.com" , "Yigit, Ferruh" , "Richardson, Bruce" , "Venkatesan, Venky" , "arybchenko@solarflare.com" Thread-Topic: [dpdk-dev] [PATCH v2 1/6] ethdev: add descriptor status API Thread-Index: AQHSl1wCc2R+TZvCikCbtciHP2RIKaGfC/2wgAR5PACABH6PEA== Date: Mon, 27 Mar 2017 01:28:59 +0000 Message-ID: References: <1488388752-1819-1-git-send-email-olivier.matz@6wind.com> <1488902393-7237-1-git-send-email-olivier.matz@6wind.com> <1488902393-7237-2-git-send-email-olivier.matz@6wind.com> <20170324134908.54e69070@platinum> In-Reply-To: <20170324134908.54e69070@platinum> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmFmYjI1NTgtNzU2ZC00ZTkzLWIyOGYtNmJiMWY5ZTFkZjczIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjlZT01DTW81V2hjXC9zYWk3aVZvOU9paHJxR1paZEJuUEJZdzJobENuTEdnPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add descriptor status API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Mar 2017 01:29:05 -0000 Hi, Olivier > -----Original Message----- > From: Olivier Matz [mailto:olivier.matz@6wind.com] > Sent: Friday, March 24, 2017 8:49 PM > To: Yang, Qiming > Cc: dev@dpdk.org; thomas.monjalon@6wind.com; Ananyev, Konstantin > ; Lu, Wenzhuo ; > Zhang, Helin ; Wu, Jingjing ; > adrien.mazarguil@6wind.com; nelio.laranjeiro@6wind.com; Yigit, Ferruh > ; Richardson, Bruce ; > Venkatesan, Venky ; > arybchenko@solarflare.com > Subject: Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add descriptor status API >=20 > Hi Qiming, >=20 > On Tue, 21 Mar 2017 08:32:17 +0000, "Yang, Qiming" > wrote: > > Hi, Olivier > > You need to add your new API in lib/librte_ether/rte_ether_version.map > > and doc/guides/rel_notes/release_17_05.rst >=20 > About rte_ether_version.map, I don't think it's needed since the function= s > are static inline. Did you noticed any issue? >=20 That's OK, I didn't notice that the functions are static inline, sorry. > About release_17_05.rst, you are right, I can add some words about this n= ew > feature. >=20 >=20 > Thanks, > Olivier >=20 >=20 > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Olivier Matz > > > Sent: Wednesday, March 8, 2017 12:00 AM > > > To: dev@dpdk.org; thomas.monjalon@6wind.com; Ananyev, Konstantin > > > ; Lu, Wenzhuo > ; > > > Zhang, Helin ; Wu, Jingjing > > > ; adrien.mazarguil@6wind.com; > > > nelio.laranjeiro@6wind.com > > > Cc: Yigit, Ferruh ; Richardson, Bruce > > > ; Venkatesan, Venky > > > ; arybchenko@solarflare.com > > > Subject: [dpdk-dev] [PATCH v2 1/6] ethdev: add descriptor status API > > > > > > Introduce a new API to get the status of a descriptor. > > > > > > For Rx, it is almost similar to rx_descriptor_done API, except it > > > differentiates "used" descriptors (which are hold by the driver and > > > not returned to the hardware). > > > > > > For Tx, it is a new API. > > > > > > The descriptor_done() API, and probably the rx_queue_count() API > > > could be replaced by this new API as soon as it is implemented on all > PMDs. > > > > > > Signed-off-by: Olivier Matz > > > --- > > > doc/guides/nics/features/default.ini | 2 + > > > lib/librte_ether/rte_ethdev.h | 125 > > > +++++++++++++++++++++++++++++++++++ > > > 2 files changed, 127 insertions(+) > > > > > > diff --git a/doc/guides/nics/features/default.ini > > > b/doc/guides/nics/features/default.ini > > > index 9e363ff..0e6a78d 100644 > > > --- a/doc/guides/nics/features/default.ini > > > +++ b/doc/guides/nics/features/default.ini > > > @@ -49,6 +49,8 @@ Inner L3 checksum =3D > > > Inner L4 checksum =3D > > > Packet type parsing =3D > > > Timesync =3D > > > +Rx Descriptor Status =3D > > > +Tx Descriptor Status =3D > > > Basic stats =3D > > > Extended stats =3D > > > Stats per queue =3D > > > diff --git a/lib/librte_ether/rte_ethdev.h > > > b/lib/librte_ether/rte_ethdev.h index 97f3e2d..904ecbe 100644 > > > --- a/lib/librte_ether/rte_ethdev.h > > > +++ b/lib/librte_ether/rte_ethdev.h > > > @@ -1179,6 +1179,12 @@ typedef uint32_t > > > (*eth_rx_queue_count_t)(struct rte_eth_dev *dev, typedef int > > > (*eth_rx_descriptor_done_t)(void *rxq, uint16_t offset); /**< > > > @internal Check DD bit of specific RX descriptor */ > > > > > > +typedef int (*eth_rx_descriptor_status_t)(void *rxq, uint16_t > > > +offset); /**< @internal Check the status of a Rx descriptor */ > > > + > > > +typedef int (*eth_tx_descriptor_status_t)(void *txq, uint16_t > > > +offset); /**< @internal Check the status of a Tx descriptor */ > > > + > > > typedef int (*eth_fw_version_get_t)(struct rte_eth_dev *dev, > > > char *fw_version, size_t fw_size); /**< > @internal Get > > > firmware information of an Ethernet device. */ @@ -1483,6 > > > +1489,10 @@ struct eth_dev_ops { > > > eth_queue_release_t rx_queue_release; /**< Release RX queue. > > > */ > > > eth_rx_queue_count_t rx_queue_count;/**< Get Rx queue > > > count. */ > > > eth_rx_descriptor_done_t rx_descriptor_done; /**< Check rxd DD > > > bit. */ > > > + eth_rx_descriptor_status_t rx_descriptor_status; > > > + /**< Check the status of a Rx descriptor. */ > > > + eth_tx_descriptor_status_t tx_descriptor_status; > > > + /**< Check the status of a Tx descriptor. */ > > > eth_rx_enable_intr_t rx_queue_intr_enable; /**< Enable Rx > > > queue interrupt. */ > > > eth_rx_disable_intr_t rx_queue_intr_disable; /**< Disable Rx > > > queue interrupt. */ > > > eth_tx_queue_setup_t tx_queue_setup;/**< Set up device TX > > > queue. */ > > > @@ -2768,6 +2778,121 @@ rte_eth_rx_descriptor_done(uint8_t port_id, > > > uint16_t queue_id, uint16_t offset) > > > dev->data->rx_queues[queue_id], offset); } > > > > > > +#define RTE_ETH_RX_DESC_AVAIL 0 /**< Desc available for hw. */ > > > +#define RTE_ETH_RX_DESC_DONE 1 /**< Desc done, filled by hw. */ > > > +#define RTE_ETH_RX_DESC_UNAVAIL 2 /**< Desc used by driver or hw. > > > +*/ > > > + > > > +/** > > > + * Check the status of a Rx descriptor in the queue > > > + * > > > + * It should be called in a similar context than the Rx function: > > > + * - on a dataplane core > > > + * - not concurrently on the same queue > > > + * > > > + * Since it's a dataplane function, no check is performed on > > > +port_id and > > > + * queue_id. The caller must therefore ensure that the port is > > > +enabled > > > + * and the queue is configured and running. > > > + * > > > + * Note: accessing to a random descriptor in the ring may trigger > > > +cache > > > + * misses and have a performance impact. > > > + * > > > + * @param port_id > > > + * A valid port identifier of the Ethernet device which. > > > + * @param queue_id > > > + * A valid Rx queue identifier on this port. > > > + * @param offset > > > + * The offset of the descriptor starting from tail (0 is the next > > > + * packet to be received by the driver). > > > + * > > > + * @return > > > + * - (RTE_ETH_RX_DESC_AVAIL): Descriptor is available for the > hardware to > > > + * receive a packet. > > > + * - (RTE_ETH_RX_DESC_DONE): Descriptor is done, it is filled by hw= , but > > > + * not yet processed by the driver (i.e. in the receive queue). > > > + * - (RTE_ETH_RX_DESC_UNAVAIL): Descriptor is unavailable, either > hold by > > > + * the driver and not yet returned to hw, or reserved by the hw. > > > + * - (-EINVAL) bad descriptor offset. > > > + * - (-ENOTSUP) if the device does not support this function. > > > + * - (-ENODEV) bad port or queue (only if compiled with debug). > > > + */ > > > +static inline int > > > +rte_eth_rx_descriptor_status(uint8_t port_id, uint16_t queue_id, > > > + uint16_t offset) > > > +{ > > > + struct rte_eth_dev *dev; > > > + void *rxq; > > > + > > > +#ifdef RTE_LIBRTE_ETHDEV_DEBUG > > > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); #endif > > > + dev =3D &rte_eth_devices[port_id]; > > > +#ifdef RTE_LIBRTE_ETHDEV_DEBUG > > > + if (queue_id >=3D dev->data->nb_rx_queues) > > > + return -ENODEV; > > > +#endif > > > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops- > > > >rx_descriptor_status, -ENOTSUP); > > > + rxq =3D dev->data->rx_queues[queue_id]; > > > + > > > + return (*dev->dev_ops->rx_descriptor_status)(rxq, offset); } > > > + > > > +#define RTE_ETH_TX_DESC_FULL 0 /**< Desc filled for hw, waiting > xmit. > > > */ > > > +#define RTE_ETH_TX_DESC_DONE 1 /**< Desc done, packet is > > > transmitted. */ > > > +#define RTE_ETH_TX_DESC_UNAVAIL 2 /**< Desc used by driver or hw. > > > +*/ > > > + > > > +/** > > > + * Check the status of a Tx descriptor in the queue. > > > + * > > > + * It should be called in a similar context than the Tx function: > > > + * - on a dataplane core > > > + * - not concurrently on the same queue > > > + * > > > + * Since it's a dataplane function, no check is performed on > > > +port_id and > > > + * queue_id. The caller must therefore ensure that the port is > > > +enabled > > > + * and the queue is configured and running. > > > + * > > > + * Note: accessing to a random descriptor in the ring may trigger > > > +cache > > > + * misses and have a performance impact. > > > + * > > > + * @param port_id > > > + * A valid port identifier of the Ethernet device which. > > > + * @param queue_id > > > + * A valid Tx queue identifier on this port. > > > + * @param offset > > > + * The offset of the descriptor starting from tail (0 is the place > > > +where > > > + * the next packet will be send). > > > + * > > > + * @return > > > + * - (RTE_ETH_TX_DESC_FULL) Descriptor is being processed by the hw= , > i.e. > > > + * in the transmit queue. > > > + * - (RTE_ETH_TX_DESC_DONE) Hardware is done with this descriptor, > > > +it > > > can > > > + * be reused by the driver. > > > + * - (RTE_ETH_TX_DESC_UNAVAIL): Descriptor is unavailable, > > > + reserved by > > > the > > > + * driver or the hardware. > > > + * - (-EINVAL) bad descriptor offset. > > > + * - (-ENOTSUP) if the device does not support this function. > > > + * - (-ENODEV) bad port or queue (only if compiled with debug). > > > + */ > > > +static inline int rte_eth_tx_descriptor_status(uint8_t port_id, > > > + uint16_t queue_id, uint16_t offset) { > > > + struct rte_eth_dev *dev; > > > + void *txq; > > > + > > > +#ifdef RTE_LIBRTE_ETHDEV_DEBUG > > > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); #endif > > > + dev =3D &rte_eth_devices[port_id]; > > > +#ifdef RTE_LIBRTE_ETHDEV_DEBUG > > > + if (queue_id >=3D dev->data->nb_tx_queues) > > > + return -ENODEV; > > > +#endif > > > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops- > > > >tx_descriptor_status, -ENOTSUP); > > > + txq =3D dev->data->tx_queues[queue_id]; > > > + > > > + return (*dev->dev_ops->tx_descriptor_status)(txq, offset); } > > > + > > > /** > > > * Send a burst of output packets on a transmit queue of an Ethernet > device. > > > * > > > -- > > > 2.8.1 > >