From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 48B6C2935; Fri, 28 Apr 2017 08:53:50 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP; 27 Apr 2017 23:53:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,387,1488873600"; d="scan'208";a="962056149" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 27 Apr 2017 23:53:49 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 27 Apr 2017 23:53:49 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 27 Apr 2017 23:53:49 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.193]) by shsmsx102.ccr.corp.intel.com ([169.254.2.246]) with mapi id 14.03.0319.002; Fri, 28 Apr 2017 14:53:45 +0800 From: "Yang, Qiming" To: "Lu, Wenzhuo" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH] igbvf: fix MAC address set problem Thread-Index: AQHSvzZ7mKnUcxkYi0Sx7dIq9SGtwqHZaySAgADtKCA= Date: Fri, 28 Apr 2017 06:53:44 +0000 Message-ID: References: <1493283743-71883-1-git-send-email-qiming.yang@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B59D627@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B59D627@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzJmYTY5ODQtNzRlNS00NDliLTg4ZGItNWQxYjgyMGU0MDVhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Im5ydDFYdm1leGtRWWRCRHB4Ym9IMTlZVEZpTXY2T1hDWFpRd2pxUEk4VjA9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] igbvf: fix MAC address set problem X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2017 06:53:51 -0000 Hi, Wenzhuo > -----Original Message----- > From: Lu, Wenzhuo > Sent: Friday, April 28, 2017 8:39 AM > To: Yang, Qiming ; dev@dpdk.org > Cc: stable@dpdk.org > Subject: RE: [PATCH] igbvf: fix MAC address set problem >=20 > Hi Qiming, >=20 > > -----Original Message----- > > From: Yang, Qiming > > Sent: Thursday, April 27, 2017 5:02 PM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo; stable@dpdk.org; Yang, Qiming > > Subject: [PATCH] igbvf: fix MAC address set problem > > > > We find that VF receive address register is not set if MAC address is > > assigned by PF. This patch fixes it. > > > > Signed-off-by: Qiming Yang > > > > Fixes: 2a3cf07108b4 ("igbvf: fix MAC address if none assigned by PF") > A little confused about the Fixes. You said this patch is for when mac ad= dress > is set by PF. But the fixes said the previous patch is for not set by PF.= Seems > they're different scenarios. Why this can a fix for a different scenario? > Thanks. Previous patch only do rar set when random a MAC for VF, when MAC address i= s assigned by PF, register is not set. Maybe I should correct the fix line, the issue I fixed is exist before 2a3c= f07108b4.