From: "Yang, Qiming" <qiming.yang@intel.com>
To: "Yang, Zhiyong" <zhiyong.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix Rx/Tx queue interrupt for x550 devices
Date: Tue, 18 Jul 2017 02:27:23 +0000 [thread overview]
Message-ID: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F7C6E3B@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <E182254E98A5DA4EB1E657AC7CB9BD2A6592439A@BGSMSX101.gar.corp.intel.com>
Yes, thanks. I'll send another patch with both fixed other issue.
> -----Original Message-----
> From: Yang, Zhiyong
> Sent: Monday, July 17, 2017 2:09 PM
> To: Yang, Qiming <qiming.yang@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: fix Rx/Tx queue interrupt for x550
> devices
>
> Hi，Qiming:
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang
> > Sent: Monday, July 17, 2017 1:35 PM
> > To: dev@dpdk.org
> > Cc: stable@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
> > <qiming.yang@intel.com>
> > Subject: [dpdk-dev] [PATCH] net/ixgbe: fix Rx/Tx queue interrupt for
> > x550 devices
> >
> > x550 devices not do interrupt vector mapping before enable Rx/Tx queue
> > interrupt, makes interrupt mode can't work neither with igb_uio or VFIO.
> >
> > Fixes: d2e72774e58c ("ixgbe/base: support X550")
> >
> > Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> > ---
> > drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index 9b06ac1..8432482 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -5611,7 +5611,8 @@ ixgbe_set_ivar_map(struct ixgbe_hw *hw, int8_t
> > direction,
> > tmp |= (msix_vector << (8 * (queue & 0x3)));
> > IXGBE_WRITE_REG(hw, IXGBE_IVAR(idx), tmp);
> > } else if ((hw->mac.type == ixgbe_mac_82599EB) ||
> > - (hw->mac.type == ixgbe_mac_X540)) {
> > + (hw->mac.type == ixgbe_mac_X540)
> > + (hw->mac.type == ixgbe_mac_X550)) {
>
> It looks like that you forget to add "||"
>
> Thanks
> Zhiyong
>
> > if (direction == -1) {
> > /* other causes */
> > idx = ((queue & 1) * 8);
> > --
> > 2.7.4
next prev parent reply other threads:[~2017-07-18 2:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 5:34 Qiming Yang
2017-07-17 6:09 ` Yang, Zhiyong
2017-07-18 2:27 ` Yang, Qiming [this message]
2017-07-18 2:28 ` [dpdk-dev] [PATCH v2] " Qiming Yang
2017-07-19 9:22 ` Dai, Wei
2017-07-19 10:12 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F7C6E3B@SHSMSX101.ccr.corp.intel.com \
--to=qiming.yang@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).