From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 604FF377E; Tue, 18 Jul 2017 04:27:31 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2017 19:27:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,376,1496127600"; d="scan'208";a="126274251" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 17 Jul 2017 19:27:26 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 17 Jul 2017 19:27:26 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 17 Jul 2017 19:27:25 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.197]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0319.002; Tue, 18 Jul 2017 10:27:24 +0800 From: "Yang, Qiming" To: "Yang, Zhiyong" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Lu, Wenzhuo" Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: fix Rx/Tx queue interrupt for x550 devices Thread-Index: AQHS/sM6R6fuS6UBuES0MjxlBfKejqJY3QEQ Date: Tue, 18 Jul 2017 02:27:23 +0000 Message-ID: References: <1500269687-73277-1-git-send-email-qiming.yang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix Rx/Tx queue interrupt for x550 devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jul 2017 02:27:33 -0000 Yes, thanks. I'll send another patch with both fixed other issue. > -----Original Message----- > From: Yang, Zhiyong > Sent: Monday, July 17, 2017 2:09 PM > To: Yang, Qiming ; dev@dpdk.org > Cc: stable@dpdk.org; Lu, Wenzhuo ; Yang, Qiming > > Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: fix Rx/Tx queue interrupt for = x550 > devices >=20 > Hi=1B$B!$=1B(BQiming: >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang > > Sent: Monday, July 17, 2017 1:35 PM > > To: dev@dpdk.org > > Cc: stable@dpdk.org; Lu, Wenzhuo ; Yang, Qiming > > > > Subject: [dpdk-dev] [PATCH] net/ixgbe: fix Rx/Tx queue interrupt for > > x550 devices > > > > x550 devices not do interrupt vector mapping before enable Rx/Tx queue > > interrupt, makes interrupt mode can't work neither with igb_uio or VFIO= . > > > > Fixes: d2e72774e58c ("ixgbe/base: support X550") > > > > Signed-off-by: Qiming Yang > > --- > > drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > > b/drivers/net/ixgbe/ixgbe_ethdev.c > > index 9b06ac1..8432482 100644 > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > @@ -5611,7 +5611,8 @@ ixgbe_set_ivar_map(struct ixgbe_hw *hw, int8_t > > direction, > > tmp |=3D (msix_vector << (8 * (queue & 0x3))); > > IXGBE_WRITE_REG(hw, IXGBE_IVAR(idx), tmp); > > } else if ((hw->mac.type =3D=3D ixgbe_mac_82599EB) || > > - (hw->mac.type =3D=3D ixgbe_mac_X540)) { > > + (hw->mac.type =3D=3D ixgbe_mac_X540) > > + (hw->mac.type =3D=3D ixgbe_mac_X550)) { >=20 > It looks like that you forget to add "||" >=20 > Thanks > Zhiyong >=20 > > if (direction =3D=3D -1) { > > /* other causes */ > > idx =3D ((queue & 1) * 8); > > -- > > 2.7.4