From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id B2B513257 for ; Wed, 10 Jan 2018 07:29:00 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2018 22:28:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,338,1511856000"; d="scan'208";a="22826311" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga001.jf.intel.com with ESMTP; 09 Jan 2018 22:28:59 -0800 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Jan 2018 22:28:59 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Jan 2018 22:28:59 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.159]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Wed, 10 Jan 2018 14:28:56 +0800 From: "Yang, Qiming" To: "Lu, Wenzhuo" , "Dai, Wei" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] net/ixgbe: fix VFIO interrupt mapping in PF Thread-Index: AQHTiSL8Bns7KtQ07Ua/mmH6lJL/6aNspZzQ Date: Wed, 10 Jan 2018 06:28:56 +0000 Message-ID: References: <1505903043-51967-1-git-send-email-wei.dai@intel.com> <1515486230-77436-1-git-send-email-wenzhuo.lu@intel.com> In-Reply-To: <1515486230-77436-1-git-send-email-wenzhuo.lu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGVhNDJiZjEtMjI2Yy00YWI5LTg1YzUtMmEyMmU3NGRiZDQ4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjZ4Skp1b3BmOVJsWWUxZUx0R2FoaG14K0dkbkRIc1RxenZIYkRXUzBDZG89In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] net/ixgbe: fix VFIO interrupt mapping in PF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 06:29:01 -0000 +1 why we disable interrupt in dev_start twice? > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Tuesday, January 9, 2018 4:24 PM > To: Dai, Wei > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] net/ixgbe: fix VFIO interrupt mapping in PF >=20 > Hi Wei, >=20 > > + rte_intr_disable(intr_handle); > TBH, confused by this patch. I see the intr already disabled at the begin= ing of this > function, ixgbe_dev_start, why we need to disable it again?