From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 8260BA0471 for ; Fri, 21 Jun 2019 04:18:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C2C451D4D1; Fri, 21 Jun 2019 04:18:37 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 927AF1D4D0 for ; Fri, 21 Jun 2019 04:18:35 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2019 19:18:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,398,1557212400"; d="scan'208";a="335686371" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 20 Jun 2019 19:18:34 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 20 Jun 2019 19:18:33 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 20 Jun 2019 19:18:33 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.87]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.72]) with mapi id 14.03.0439.000; Fri, 21 Jun 2019 10:18:31 +0800 From: "Yang, Qiming" To: Aaron Conole CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 2/3] net/ice: add generic flow API Thread-Index: AQHVJ2zO8yN6vuKliEaqVPsHlbvAlaalYB0A Date: Fri, 21 Jun 2019 02:18:31 +0000 Message-ID: References: <1559552722-8970-1-git-send-email-qiming.yang@intel.com> <20190620053449.32959-1-qiming.yang@intel.com> <20190620053449.32959-3-qiming.yang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmQ4ODUzMjgtMzg3Ni00YTkzLWE1ZjItZDc4ZGIwOGFhNzdmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUlZwa3NCSDg1SEpmSXN3dzNUVzJscUpMeUM3QzVYOW41REx3ZElBKzdtREtEc3RJZDgyWElWZWd0eEpCc25SSCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 2/3] net/ice: add generic flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks for your comments. I'll add it in v4. > -----Original Message----- > From: Aaron Conole [mailto:aconole@redhat.com] > Sent: Thursday, June 20, 2019 9:34 PM > To: Yang, Qiming > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/3] net/ice: add generic flow API >=20 > Qiming Yang writes: >=20 > > This patch adds ice_flow_create, ice_flow_destroy, ice_flow_flush and > > ice_flow_validate support, these are used to handle all the generic > > filters. > > > > Signed-off-by: Qiming Yang > > --- > > drivers/net/ice/Makefile | 1 + > > drivers/net/ice/ice_ethdev.c | 44 +++ > > drivers/net/ice/ice_ethdev.h | 5 + > > drivers/net/ice/ice_generic_flow.c | 682 > > +++++++++++++++++++++++++++++++++++++ > > drivers/net/ice/ice_generic_flow.h | 654 > +++++++++++++++++++++++++++++++++++ > > drivers/net/ice/meson.build | 1 + > > 6 files changed, 1387 insertions(+) > > create mode 100644 drivers/net/ice/ice_generic_flow.c > > create mode 100644 drivers/net/ice/ice_generic_flow.h > > > > diff --git a/drivers/net/ice/Makefile b/drivers/net/ice/Makefile index > > b10d826..32abeb6 100644 > > --- a/drivers/net/ice/Makefile > > +++ b/drivers/net/ice/Makefile > > @@ -79,5 +79,6 @@ endif > > ifeq ($(CC_AVX2_SUPPORT), 1) > > SRCS-$(CONFIG_RTE_LIBRTE_ICE_PMD) +=3D ice_rxtx_vec_avx2.c endif > > +SRCS-$(CONFIG_RTE_LIBRTE_ICE_PMD) +=3D ice_generic_flow.c > > [...] > > +#endif > > diff --git a/drivers/net/ice/meson.build b/drivers/net/ice/meson.build > > index 8697676..18180b9 100644 > > --- a/drivers/net/ice/meson.build > > +++ b/drivers/net/ice/meson.build > > @@ -8,6 +8,7 @@ sources =3D files( > > 'ice_ethdev.c', > > 'ice_rxtx.c', > > 'ice_switch_filter.c' >=20 > Missing a comma here. >=20 > > + 'ice_generic_flow.c' > > ) > > > > deps +=3D ['hash']