From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 565A6A046B for ; Sat, 27 Jul 2019 01:04:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 832D41C4EA; Sat, 27 Jul 2019 01:04:08 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id B1D211C4E9; Sat, 27 Jul 2019 01:04:05 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jul 2019 16:04:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,312,1559545200"; d="scan'208";a="322194812" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga004.jf.intel.com with ESMTP; 26 Jul 2019 16:04:03 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 26 Jul 2019 16:03:57 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 26 Jul 2019 16:03:56 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 26 Jul 2019 16:03:56 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.80]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.249]) with mapi id 14.03.0439.000; Sat, 27 Jul 2019 07:03:55 +0800 From: "Yang, Qiming" To: "Wang, Ying A" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/ice: fix LLDP forward Thread-Index: AQHVQ4ei878qIAjz3UWvFoqt84t4jabdgvJQ Date: Fri, 26 Jul 2019 23:03:54 +0000 Message-ID: References: <1564088408-99709-1-git-send-email-ying.a.wang@intel.com> <1564097763-276974-1-git-send-email-ying.a.wang@intel.com> In-Reply-To: <1564097763-276974-1-git-send-email-ying.a.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGNlZGM3NTctYzJjYy00OGNiLThjZmYtYWUwYmYwZWU4YmY4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSllvSW1QWnVKVnJIU3VmRHM1Y204NWx5RElcL1ViYXNkTFVOb0lxTlM1MHVxRlBvY05ab3hHZUVPc1owVEcrdG4ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix LLDP forward X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Ying > -----Original Message----- > From: Wang, Ying A > Sent: Thursday, July 25, 2019 4:36 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Yang, Qiming ; Wang, Ying A > ; stable@dpdk.org > Subject: [PATCH v2] net/ice: fix LLDP forward >=20 > The patch fix the issue that lldp packet can't be forwarded to host. >=20 > Fixes: 59d151de6673 ("net/ice: stop LLDP by default") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wang Ying A > --- > --- > V2: Remove redundant macro definiton and function argument; > Modify the function name, variables and comments to avoid > similarities with kernel code. > --- >=20 > drivers/net/ice/ice_ethdev.c | 42 > +++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 41 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c = index > 08fc9ec..9550aed 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -1385,6 +1385,40 @@ static int ice_parse_devargs(struct rte_eth_dev > *dev) > return ret; > } >=20 > +/* Forward LLDP packets to default VSI by set switch rules*/ static int > +ice_vsi_config_sw_lldp(struct ice_vsi *vsi, bool on) { Have this line's format anything wrong? And why don't we ask ND to deliver ice_cfg_sw_lldp in share code? > + struct ice_hw *hw =3D ICE_VSI_TO_HW(vsi); > + struct ice_fltr_list_entry *s_list_itr =3D NULL; > + struct LIST_HEAD_TYPE list_head; > + int ret =3D 0; > + > + INIT_LIST_HEAD(&list_head); > + > + s_list_itr =3D (struct ice_fltr_list_entry *) > + ice_malloc(hw, sizeof(*s_list_itr)); > + if (!s_list_itr) { > + ret =3D -ENOMEM; > + goto DONE; > + } > + s_list_itr->fltr_info.lkup_type =3D ICE_SW_LKUP_ETHERTYPE; > + s_list_itr->fltr_info.vsi_handle =3D vsi->idx; > + s_list_itr->fltr_info.l_data.ethertype_mac.ethertype =3D > + RTE_ETHER_TYPE_LLDP; > + s_list_itr->fltr_info.fltr_act =3D ICE_FWD_TO_VSI; > + s_list_itr->fltr_info.flag =3D ICE_FLTR_RX; > + s_list_itr->fltr_info.src_id =3D ICE_SRC_ID_LPORT; > + LIST_ADD(&s_list_itr->list_entry, &list_head); > + if (on) > + ret =3D ice_add_eth_mac(hw, &list_head); > + else > + ret =3D ice_remove_eth_mac(hw, &list_head); > +DONE: > + rte_free(s_list_itr); > + return ret; > +} > + > static int > ice_dev_init(struct rte_eth_dev *dev) > { > @@ -1492,7 +1526,13 @@ static int ice_parse_devargs(struct rte_eth_dev > *dev) > ret =3D ice_aq_stop_lldp(hw, TRUE, FALSE, NULL); > if (ret !=3D ICE_SUCCESS) > PMD_INIT_LOG(DEBUG, "lldp has already stopped\n"); > - > + ret =3D ice_init_dcb(hw, TRUE); > + if (ret !=3D ICE_SUCCESS) > + PMD_INIT_LOG(DEBUG, "Failed to init DCB\n"); > + /* Forward LLDP packets to default VSI */ > + ret =3D ice_vsi_config_sw_lldp(vsi, TRUE); > + if (ret !=3D ICE_SUCCESS) > + PMD_INIT_LOG(DEBUG, "Failed to cfg lldp\n"); > /* register callback func to eal lib */ > rte_intr_callback_register(intr_handle, > ice_interrupt_handler, dev); > -- > 1.8.3.1