From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04C65A0613 for ; Mon, 23 Sep 2019 09:12:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C90E61DB9; Mon, 23 Sep 2019 09:11:59 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 2F36291 for ; Mon, 23 Sep 2019 09:11:57 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Sep 2019 00:11:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,539,1559545200"; d="scan'208";a="339628021" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 23 Sep 2019 00:11:56 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Sep 2019 00:11:55 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Sep 2019 00:11:55 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.92]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.23]) with mapi id 14.03.0439.000; Mon, 23 Sep 2019 15:11:53 +0800 From: "Yang, Qiming" To: "Zhang, Qi Z" , "Lu, Wenzhuo" CC: "dev@dpdk.org" , "Ye, Xiaolong" , "Nowlin, Dan" , "Stillwell Jr, Paul M" Thread-Topic: [PATCH v4 25/30] net/ice/base: remove unnecessary error log Thread-Index: AQHVcdelpb9Pl/+tG0SVVvPxFzflcqc42GyA Date: Mon, 23 Sep 2019 07:11:52 +0000 Message-ID: References: <20190902035551.16852-1-qi.z.zhang@intel.com> <20190923062702.3836-1-qi.z.zhang@intel.com> <20190923062702.3836-26-qi.z.zhang@intel.com> In-Reply-To: <20190923062702.3836-26-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTk1ZmQyNmEtNmY5ZC00ZTVhLWE1NjctNjk3Yzc2ZmM5YjBlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibkFGZGRJckE3T1F1ZTNDSTUwWCszcTAwc1hnWEdWZE9paHlnTGF4bGtyQ21rUmRaOWwreVBcL1dLeVlES3cyQ1cifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 25/30] net/ice/base: remove unnecessary error log X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhang, Qi Z > Sent: Monday, September 23, 2019 2:27 PM > To: Lu, Wenzhuo ; Yang, Qiming > > Cc: dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z > ; Nowlin, Dan ; Stillwell Jr, > Paul M > Subject: [PATCH v4 25/30] net/ice/base: remove unnecessary error log >=20 > Remove the error log message when attempting to download a p ackage that 'p ackage' is weird. > has an unsupported version. >=20 > Signed-off-by: Dan Nowlin > Signed-off-by: Paul M Stillwell Jr > Signed-off-by: Qi Zhang > --- > drivers/net/ice/base/ice_flex_pipe.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) >=20 > diff --git a/drivers/net/ice/base/ice_flex_pipe.c > b/drivers/net/ice/base/ice_flex_pipe.c > index 318168910..11601f2c2 100644 > --- a/drivers/net/ice/base/ice_flex_pipe.c > +++ b/drivers/net/ice/base/ice_flex_pipe.c > @@ -1284,7 +1284,6 @@ static void ice_init_pkg_regs(struct ice_hw *hw) >=20 > /** > * ice_chk_pkg_version - check package version for compatibility with dr= iver > - * @hw: pointer to the hardware structure > * @pkg_ver: pointer to a version structure to check > * > * Check to make sure that the package about to be downloaded is > compatible with @@ -1292,18 +1291,11 @@ static void > ice_init_pkg_regs(struct ice_hw *hw) > * version must match our ICE_PKG_SUPP_VER_MAJ and > ICE_PKG_SUPP_VER_MNR > * definitions. > */ > -static enum ice_status > -ice_chk_pkg_version(struct ice_hw *hw, struct ice_pkg_ver *pkg_ver) > +static enum ice_status ice_chk_pkg_version(struct ice_pkg_ver *pkg_ver) > { > if (pkg_ver->major !=3D ICE_PKG_SUPP_VER_MAJ || > - pkg_ver->minor !=3D ICE_PKG_SUPP_VER_MNR) { > - ice_info(hw, "ERROR: Incompatible package: %d.%d.%d.%d - > requires package version: %d.%d.*.*\n", > - pkg_ver->major, pkg_ver->minor, pkg_ver->update, > - pkg_ver->draft, ICE_PKG_SUPP_VER_MAJ, > - ICE_PKG_SUPP_VER_MNR); > - > + pkg_ver->minor !=3D ICE_PKG_SUPP_VER_MNR) > return ICE_ERR_NOT_SUPPORTED; > - } >=20 > return ICE_SUCCESS; > } > @@ -1358,7 +1350,7 @@ enum ice_status ice_init_pkg(struct ice_hw *hw, > u8 *buf, u32 len) > /* before downloading the package, check package version for > * compatibility with driver > */ > - status =3D ice_chk_pkg_version(hw, &hw->pkg_ver); > + status =3D ice_chk_pkg_version(&hw->pkg_ver); > if (status) > return status; >=20 > @@ -1384,7 +1376,7 @@ enum ice_status ice_init_pkg(struct ice_hw *hw, > u8 *buf, u32 len) > if (!status) { > status =3D ice_get_pkg_info(hw); > if (!status) > - status =3D ice_chk_pkg_version(hw, &hw- > >active_pkg_ver); > + status =3D ice_chk_pkg_version(&hw->active_pkg_ver); > } >=20 > if (!status) { > -- > 2.13.6