From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44FE4A00B8; Mon, 28 Oct 2019 06:50:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 798211BEF9; Mon, 28 Oct 2019 06:50:32 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 0E5871BEBD for ; Mon, 28 Oct 2019 06:50:30 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Oct 2019 22:50:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,239,1569308400"; d="scan'208";a="198549860" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga007.fm.intel.com with ESMTP; 27 Oct 2019 22:50:21 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 27 Oct 2019 22:50:21 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 27 Oct 2019 22:50:21 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.213]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.41]) with mapi id 14.03.0439.000; Mon, 28 Oct 2019 13:50:19 +0800 From: "Yang, Qiming" To: "Di, ChenxuX" , "dev@dpdk.org" CC: "Lu, Wenzhuo" Thread-Topic: [PATCH] net/ixgbe: fix port close in FreeBSD OS Thread-Index: AQHVivdarSTLZqi1Skes5rD1JcnFU6dvkGiA Date: Mon, 28 Oct 2019 05:50:18 +0000 Message-ID: References: <20191025045258.66935-1-chenxux.di@intel.com> In-Reply-To: <20191025045258.66935-1-chenxux.di@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDllMmFmNjctYTcyNi00YzkzLWI3NTItOTlmYmMxNjUyNzE0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoib1BEWGFBdng1QVdGSDhBdlVEVEx1NTl5Z0ltem9sNlRBNmp6VHRCQmV2UDA3Y2V3cUhlSHdRWjZ5SHM1cXBvMiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix port close in FreeBSD OS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Chenxu > -----Original Message----- > From: Di, ChenxuX > Sent: Friday, October 25, 2019 12:53 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Di, ChenxuX > Subject: [PATCH] net/ixgbe: fix port close in FreeBSD OS >=20 > FreeBSD OS don't support igb_uio interrupt, so it will fail that unregis= ter intr > callback when port close. it will fail when unregister the interrupt callback in port close. > Fix by passing -ENOENT when check the return value of unregister intr > callback function. We can fix the issue by ... / please use interrupt not intr in commit messa= ge. >=20 > Fixes: f2f4990eff94 ("net/ixgbe: release port upon close") >=20 > Signed-off-by: Di ChenxuX > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index dbce7a80e..0a654accb 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -2978,7 +2978,7 @@ ixgbe_dev_close(struct rte_eth_dev *dev) > do { > ret =3D rte_intr_callback_unregister(intr_handle, > ixgbe_dev_interrupt_handler, dev); > - if (ret >=3D 0) { > + if (ret >=3D 0 || ret =3D=3D -ENOENT) { > break; > } else if (ret !=3D -EAGAIN) { > PMD_INIT_LOG(ERR, > -- > 2.17.1