From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12297A00B8; Mon, 28 Oct 2019 06:51:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C67851BF08; Mon, 28 Oct 2019 06:51:42 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id CE3291BF05 for ; Mon, 28 Oct 2019 06:51:41 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Oct 2019 22:51:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,239,1569308400"; d="scan'208";a="210810927" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 27 Oct 2019 22:51:41 -0700 Received: from fmsmsx161.amr.corp.intel.com (10.18.125.9) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 27 Oct 2019 22:51:40 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX161.amr.corp.intel.com (10.18.125.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 27 Oct 2019 22:51:40 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.213]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.200]) with mapi id 14.03.0439.000; Mon, 28 Oct 2019 13:51:38 +0800 From: "Yang, Qiming" To: "Di, ChenxuX" , "dev@dpdk.org" CC: "Lu, Wenzhuo" Thread-Topic: [PATCH] app/testpmd: fix device hotplug remove Thread-Index: AQHVig5joUea3RqcLUuDoTHKvNzYVqdvkxeg Date: Mon, 28 Oct 2019 05:51:38 +0000 Message-ID: References: <20191024010310.35882-1-chenxux.di@intel.com> In-Reply-To: <20191024010310.35882-1-chenxux.di@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzExOWM2NzQtMGZmZC00Y2JlLTg4MmQtNjA4ODJiM2JiYjYwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMFVITTNtUUlEUjhRNWE2TnF4ZFc2MWtCbDlDd0wwcHpzWGpQTUd0YlJrRklPTjhFSE1tZHlFWmxHN2tpMDBpdCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix device hotplug remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Di, ChenxuX > Sent: Thursday, October 24, 2019 9:03 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Di, ChenxuX > Subject: [PATCH] app/testpmd: fix device hotplug remove >=20 > Hotplug remove cause infinite loops. Fix by canceling port_close before > port_detach function when rmv_port_callback. >=20 > Fixes: ac89d46096d5 ("net/i40e: release port upon close") >=20 > Signed-off-by: Di ChenxuX > --- > app/test-pmd/testpmd.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > 5701f3141..a264644a1 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -2708,7 +2708,6 @@ rmv_port_callback(void *arg) > no_link_check =3D 1; > stop_port(port_id); > no_link_check =3D org_no_link_check; > - close_port(port_id); > detach_port_device(port_id); > if (need_to_start) > start_packet_forwarding(0); > -- > 2.17.1 NACK, this patch is not acceptable.