From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BFFCDA04A3; Mon, 4 Nov 2019 04:16:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C2961100C; Mon, 4 Nov 2019 04:16:35 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id B847CDE3 for ; Mon, 4 Nov 2019 04:16:34 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Nov 2019 19:16:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,265,1569308400"; d="scan'208";a="195320680" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga008.jf.intel.com with ESMTP; 03 Nov 2019 19:16:33 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 3 Nov 2019 19:16:33 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 3 Nov 2019 19:16:33 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.213]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.149]) with mapi id 14.03.0439.000; Mon, 4 Nov 2019 11:16:31 +0800 From: "Yang, Qiming" To: "Zhang, Qi Z" CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/ice/base: fix wrong symmetric hash configure Thread-Index: AQHVj56lp3AeaQkK/0OU+VW+G+eG3ad6XBMg Date: Mon, 4 Nov 2019 03:16:30 +0000 Message-ID: References: <20191031035521.45015-1-qi.z.zhang@intel.com> In-Reply-To: <20191031035521.45015-1-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzgyMzMyYzgtMDlmNC00MGQ2LTg5MDUtNmIzODEyYjVhNmNmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZXJmSVk5VWRKTFVQazJ4dTUxUGU2ZXZJUTZ3MXQ0Tk9ZUGlOMDdURjZVamdYK1NEekY5M0pKVTlmN052SjlHMCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ice/base: fix wrong symmetric hash configure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Some typos. > -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, October 31, 2019 11:55 AM > To: Yang, Qiming > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH] net/ice/base: fix wrong symmetric hash configure >=20 > When a new hash profie is created, we need to reset all related profie / profile > GLQF_HSYMM registers, otherwise unexpected hash behaviour may happens behaviour / behavior=20 > on packet that hit that profile. >=20 > The patch fix the issue that we only do reset when symmetric hash is Fix/fixes > required, but actually for non symmmetric hash we also need this, since symmmetric / symmetric > GLQF_HSYMM might be polluted by previous configuration. >=20 > Fixes: ddae0440353f ("net/ice/base: enable symmetric hash for RSS") >=20 > Signed-off-by: Qi Zhang > Tested-by: Simei Su > --- > drivers/net/ice/base/ice_flow.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_f= low.c > index d2dbb1177..797d7e6e6 100644 > --- a/drivers/net/ice/base/ice_flow.c > +++ b/drivers/net/ice/base/ice_flow.c > @@ -2199,8 +2199,6 @@ ice_add_rss_cfg_sync(struct ice_hw *hw, u16 > vsi_handle, u64 hashed_flds, > status =3D ice_add_rss_list(hw, vsi_handle, prof); >=20 > prof->cfg.symm =3D symm; > - if (!symm) > - goto exit; >=20 > update_symm: > ice_rss_update_symm(hw, prof); > -- > 2.13.6