From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B90B3A04A3; Mon, 4 Nov 2019 04:30:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 902911BE84; Mon, 4 Nov 2019 04:30:13 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 4F97C1BE80 for ; Mon, 4 Nov 2019 04:30:11 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Nov 2019 19:30:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,265,1569308400"; d="scan'208";a="205059165" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga006.jf.intel.com with ESMTP; 03 Nov 2019 19:30:09 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 3 Nov 2019 19:30:09 -0800 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 3 Nov 2019 19:30:09 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.213]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.63]) with mapi id 14.03.0439.000; Mon, 4 Nov 2019 11:30:07 +0800 From: "Yang, Qiming" To: "Zhu, TaoX" , "Lu, Wenzhuo" CC: "dev@dpdk.org" Thread-Topic: [DPDK] net/ice: set vlan tpid is not supported by ice Thread-Index: AQHVj48P7886G4e5QEyQNOEXpOJCFad6YQvw Date: Mon, 4 Nov 2019 03:30:06 +0000 Message-ID: References: <20191031102923.70585-1-taox.zhu@intel.com> In-Reply-To: <20191031102923.70585-1-taox.zhu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTc2ZWRjZGMtZWRiNy00MjM5LWI3MGItZjkxNTAzNGI4OWI2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibldBS2xLT1pCSUxXZk9cLzB1UGcxRHdSYmdKYUwxc1ZsemFTQldNR0JQa3VqMUJ6Tmpqa1lXNklXRWtBeEh5Sm4ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [DPDK] net/ice: set vlan tpid is not supported by ice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Zhu, TaoX > Sent: Thursday, October 31, 2019 6:29 PM > To: Yang, Qiming ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Zhu, TaoX > Subject: [DPDK] net/ice: set vlan tpid is not supported by ice >=20 > From: Zhu Tao >=20 > Set vlan tpid is not supported by ice hardware. Delete driver code that > doesn't work. >=20 > Signed-off-by: Zhu Tao > --- > drivers/net/ice/ice_ethdev.c | 54 ------------------------------------ > 1 file changed, 54 deletions(-) >=20 > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c = index > d74675842..ec0234091 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -69,9 +69,6 @@ static int ice_dev_set_link_down(struct rte_eth_dev > *dev); >=20 > static int ice_mtu_set(struct rte_eth_dev *dev, uint16_t mtu); static i= nt > ice_vlan_offload_set(struct rte_eth_dev *dev, int mask); -static int > ice_vlan_tpid_set(struct rte_eth_dev *dev, > - enum rte_vlan_type vlan_type, > - uint16_t tpid); > static int ice_rss_reta_update(struct rte_eth_dev *dev, > struct rte_eth_rss_reta_entry64 *reta_conf, > uint16_t reta_size); > @@ -156,7 +153,6 @@ static const struct eth_dev_ops ice_eth_dev_ops =3D { > .mac_addr_remove =3D ice_macaddr_remove, > .vlan_filter_set =3D ice_vlan_filter_set, > .vlan_offload_set =3D ice_vlan_offload_set, > - .vlan_tpid_set =3D ice_vlan_tpid_set, > .reta_update =3D ice_rss_reta_update, > .reta_query =3D ice_rss_reta_query, > .rss_hash_update =3D ice_rss_hash_update, > @@ -3340,56 +3336,6 @@ ice_vlan_offload_set(struct rte_eth_dev *dev, int > mask) > return 0; > } >=20 > -static int > -ice_vlan_tpid_set(struct rte_eth_dev *dev, > - enum rte_vlan_type vlan_type, > - uint16_t tpid) > -{ > - struct ice_hw *hw =3D ICE_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > - uint64_t reg_r =3D 0, reg_w =3D 0; > - uint16_t reg_id =3D 0; > - int ret =3D 0; > - int qinq =3D dev->data->dev_conf.rxmode.offloads & > - DEV_RX_OFFLOAD_VLAN_EXTEND; > - > - switch (vlan_type) { > - case ETH_VLAN_TYPE_OUTER: > - if (qinq) > - reg_id =3D 3; > - else > - reg_id =3D 5; > - break; > - case ETH_VLAN_TYPE_INNER: > - if (qinq) { > - reg_id =3D 5; > - } else { > - PMD_DRV_LOG(ERR, > - "Unsupported vlan type in single vlan."); > - return -EINVAL; > - } > - break; > - default: > - PMD_DRV_LOG(ERR, "Unsupported vlan type %d", vlan_type); > - return -EINVAL; > - } > - reg_r =3D ICE_READ_REG(hw, GL_SWT_L2TAGCTRL(reg_id)); > - PMD_DRV_LOG(DEBUG, "Debug read from ICE > GL_SWT_L2TAGCTRL[%d]: " > - "0x%08"PRIx64"", reg_id, reg_r); > - > - reg_w =3D reg_r & (~(GL_SWT_L2TAGCTRL_ETHERTYPE_M)); > - reg_w |=3D ((uint64_t)tpid << GL_SWT_L2TAGCTRL_ETHERTYPE_S); > - if (reg_r =3D=3D reg_w) { > - PMD_DRV_LOG(DEBUG, "No need to write"); > - return 0; > - } > - > - ICE_WRITE_REG(hw, GL_SWT_L2TAGCTRL(reg_id), reg_w); > - PMD_DRV_LOG(DEBUG, "Debug write 0x%08"PRIx64" to " > - "ICE GL_SWT_L2TAGCTRL[%d]", reg_w, reg_id); > - > - return ret; > -} > - > static int > ice_get_rss_lut(struct ice_vsi *vsi, uint8_t *lut, uint16_t lut_size) { > -- > 2.17.1 Acked-by: Qiming Yang