From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF573A04AF; Tue, 12 Nov 2019 11:36:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BADD8271; Tue, 12 Nov 2019 11:36:50 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id ACE68271 for ; Tue, 12 Nov 2019 11:36:48 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Nov 2019 02:36:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,296,1569308400"; d="scan'208";a="229331757" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 12 Nov 2019 02:36:47 -0800 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 Nov 2019 02:36:47 -0800 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 Nov 2019 02:36:47 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.213]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.248]) with mapi id 14.03.0439.000; Tue, 12 Nov 2019 18:36:45 +0800 From: "Yang, Qiming" To: "Wang, ShougangX" , "dev@dpdk.org" CC: "Zhang, Qi Z" Thread-Topic: [PATCH v4 2/4] net/ice: fix removal of FDIR profile Thread-Index: AQHVmUFF1ekTEOQKTkOcNSHvQfxptqeHVwsQ Date: Tue, 12 Nov 2019 10:36:45 +0000 Message-ID: References: <20191105033806.2878-1-shougangx.wang@intel.com> <20191112035011.67537-1-shougangx.wang@intel.com> <20191112035011.67537-3-shougangx.wang@intel.com> In-Reply-To: <20191112035011.67537-3-shougangx.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2Q2YjBlNmItNTNkMi00YTllLTgyYTQtY2Y1Y2E3Mjc3ZGMyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidVA2eTYzZmVCWnlZMTByXC8wVzBcLzM2Q2Y3OGlhRUp1OWxRZzRQWStYVWxTdUQ0V2JhU1wvTW10aHNvWFBqWVExWCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 2/4] net/ice: fix removal of FDIR profile X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Wang, ShougangX > Sent: Tuesday, November 12, 2019 11:50 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Wang, ShougangX > Subject: [PATCH v4 2/4] net/ice: fix removal of FDIR profile >=20 > The removal of FDIR profile should start from the next of > ICE_FLTR_PTYPE_NONF_NONE. >=20 > Fixes: 109e8e06249e ("net/ice: configure HW flow director rule") >=20 > Signed-off-by: Wang ShougangX > --- > drivers/net/ice/ice_fdir_filter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir= _filter.c > index a89c506c0..039e00a28 100644 > --- a/drivers/net/ice/ice_fdir_filter.c > +++ b/drivers/net/ice/ice_fdir_filter.c > @@ -571,7 +571,7 @@ ice_fdir_prof_rm_all(struct ice_pf *pf) { > enum ice_fltr_ptype ptype; >=20 > - for (ptype =3D ICE_FLTR_PTYPE_NONF_NONE; > + for (ptype =3D ICE_FLTR_PTYPE_NONF_NONE + 1; I think we should also use ICE_FLTR_PTYPE_NONF_NONE + 1 instead of ICE_FLTR= _PTYPE_TCP_IPV4 in prof_add, To make sure it is symmetric. And it should be contained in this patch. > ptype < ICE_FLTR_PTYPE_MAX; > ptype++) { > ice_fdir_prof_rm(pf, ptype, false); > -- > 2.17.1