From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A22C3A04C0; Wed, 13 Nov 2019 09:44:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 10A021BEF4; Wed, 13 Nov 2019 09:44:08 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 954991BEEF for ; Wed, 13 Nov 2019 09:44:06 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Nov 2019 00:44:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,299,1569308400"; d="scan'208";a="229682200" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga004.fm.intel.com with ESMTP; 13 Nov 2019 00:44:05 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 Nov 2019 00:44:05 -0800 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 Nov 2019 00:44:04 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.213]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.248]) with mapi id 14.03.0439.000; Wed, 13 Nov 2019 16:44:03 +0800 From: "Yang, Qiming" To: "Wang, ShougangX" , "dev@dpdk.org" CC: "Zhang, Qi Z" Thread-Topic: [PATCH v5 2/4] net/ice: fix removal of FDIR profile Thread-Index: AQHVmffxA+77dvoOsEuhjjnn/2MRE6eIyNEg Date: Wed, 13 Nov 2019 08:44:02 +0000 Message-ID: References: <20191105033806.2878-1-shougangx.wang@intel.com> <20191113013758.39664-1-shougangx.wang@intel.com> <20191113013758.39664-3-shougangx.wang@intel.com> In-Reply-To: <20191113013758.39664-3-shougangx.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTU4OTI3MWItYjg0ZS00OWQ3LWFhODYtMzMyMzZkMDc4MGE5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNVVqSWNVSEJjVUw0NlFjWGtlNkhNRWVxUjVNOUpCTWgrc2J6UkZseEdPWkF5a05sRDhiaGVJZ1ZuMGlcL3Y2d2UifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 2/4] net/ice: fix removal of FDIR profile X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Wang, ShougangX > Sent: Wednesday, November 13, 2019 9:38 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Wang, ShougangX > Subject: [PATCH v5 2/4] net/ice: fix removal of FDIR profile >=20 > The removal of FDIR profile should start from the next of > ICE_FLTR_PTYPE_NONF_NONE. >=20 > Fixes: 109e8e06249e ("net/ice: configure HW flow director rule") >=20 > Signed-off-by: Wang ShougangX > --- > drivers/net/ice/ice_fdir_filter.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir= _filter.c > index a89c506c0..39c0efbdc 100644 > --- a/drivers/net/ice/ice_fdir_filter.c > +++ b/drivers/net/ice/ice_fdir_filter.c > @@ -152,7 +152,7 @@ ice_fdir_prof_alloc(struct ice_hw *hw) > if (!hw->fdir_prof) > return -ENOMEM; > } > - for (ptype =3D ICE_FLTR_PTYPE_NONF_IPV4_UDP; > + for (ptype =3D ICE_FLTR_PTYPE_NONF_NONE + 1; > ptype < ICE_FLTR_PTYPE_MAX; > ptype++) { > if (!hw->fdir_prof[ptype]) { > @@ -165,7 +165,7 @@ ice_fdir_prof_alloc(struct ice_hw *hw) > return 0; >=20 > fail_mem: > - for (fltr_ptype =3D ICE_FLTR_PTYPE_NONF_IPV4_UDP; > + for (fltr_ptype =3D ICE_FLTR_PTYPE_NONF_NONE + 1; > fltr_ptype < ptype; > fltr_ptype++) > rte_free(hw->fdir_prof[fltr_ptype]); > @@ -521,7 +521,7 @@ ice_fdir_prof_free(struct ice_hw *hw) { > enum ice_fltr_ptype ptype; >=20 > - for (ptype =3D ICE_FLTR_PTYPE_NONF_IPV4_UDP; > + for (ptype =3D ICE_FLTR_PTYPE_NONF_NONE + 1; > ptype < ICE_FLTR_PTYPE_MAX; > ptype++) > rte_free(hw->fdir_prof[ptype]); > @@ -571,7 +571,7 @@ ice_fdir_prof_rm_all(struct ice_pf *pf) { > enum ice_fltr_ptype ptype; >=20 > - for (ptype =3D ICE_FLTR_PTYPE_NONF_NONE; > + for (ptype =3D ICE_FLTR_PTYPE_NONF_NONE + 1; > ptype < ICE_FLTR_PTYPE_MAX; > ptype++) { > ice_fdir_prof_rm(pf, ptype, false); > -- > 2.17.1 Acked-by: Qiming Yang