From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09A21A04B3; Mon, 30 Dec 2019 04:17:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CCF321BFD7; Mon, 30 Dec 2019 04:17:35 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C44181BFD1 for ; Mon, 30 Dec 2019 04:17:34 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Dec 2019 19:17:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,373,1571727600"; d="scan'208";a="220585717" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga006.jf.intel.com with ESMTP; 29 Dec 2019 19:17:33 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 29 Dec 2019 19:17:32 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 29 Dec 2019 19:17:32 -0800 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 29 Dec 2019 19:17:31 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.30]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.89]) with mapi id 14.03.0439.000; Mon, 30 Dec 2019 11:17:30 +0800 From: "Yang, Qiming" To: "Di, ChenxuX" , "dev@dpdk.org" CC: "Xing, Beilei" Thread-Topic: [PATCH v5 1/4] net/i40e: cleanup Tx buffers Thread-Index: AQHVvGqPN1BIUhJKuUW7kSb1Nw/UGKfR/0pg Date: Mon, 30 Dec 2019 03:17:29 +0000 Message-ID: References: <20191227034520.78613-1-chenxux.di@intel.com> <20191227034520.78613-2-chenxux.di@intel.com> In-Reply-To: <20191227034520.78613-2-chenxux.di@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 1/4] net/i40e: cleanup Tx buffers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- From: Di, ChenxuX=20 Sent: Friday, December 27, 2019 11:45 To: dev@dpdk.org Cc: Yang, Qiming ; Xing, Beilei ; Di, ChenxuX Subject: [PATCH v5 1/4] net/i40e: cleanup Tx buffers Add support to the i40e driver for the API rte_eth_tx_done_cleanup to force= free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/i40e/i40e_ethdev.c | 1 + drivers/net/i40e/i40e_ethdev_vf.c | 1 + drivers/net/i40e/i40e_rxtx.c | 122 ++++++++++++++++++++++++++++++ drivers/net/i40e/i40e_rxtx.h | 1 + 4 files changed, 125 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.= c index 5999c964b..fad47a942 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -522,6 +522,7 @@ static const struct eth_dev_ops i40e_eth_dev_ops =3D { .mac_addr_set =3D i40e_set_default_mac_addr, .mtu_set =3D i40e_dev_mtu_set, .tm_ops_get =3D i40e_tm_ops_get, + .tx_done_cleanup =3D i40e_tx_done_cleanup, }; =20 /* store statistics names and its offset in stats structure */ diff --git = a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 5dba0928b..0ca5417d7 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -215,6 +215,7 @@ static const struct eth_dev_ops i40evf_eth_dev_ops =3D = { .rss_hash_conf_get =3D i40evf_dev_rss_hash_conf_get, .mtu_set =3D i40evf_dev_mtu_set, .mac_addr_set =3D i40evf_set_default_mac_addr, + .tx_done_cleanup =3D i40e_tx_done_cleanup, }; =20 /* diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c in= dex 17dc8c78f..9e4b0b678 100644 --- a/drivers/net/i40e/i40e_rxtx.c +++ b/drivers/net/i40e/i40e_rxtx.c @@ -2455,6 +2455,128 @@ i40e_tx_queue_release_mbufs(struct i40e_tx_queue *t= xq) } } =20 +int i40e_tx_done_cleanup(void *q, uint32_t free_cnt) { + struct i40e_tx_queue *txq =3D (struct i40e_tx_queue *)q; + struct i40e_tx_entry *sw_ring; + volatile struct i40e_tx_desc *txr; + uint16_t tx_first; /* First segment analyzed. */ + uint16_t tx_id; /* Current segment being processed. */ + uint16_t tx_last; /* Last segment in the current packet. */ + uint16_t tx_next; /* First segment of the next packet. */ + int count; + + if (txq =3D=3D NULL) + return -ENODEV; + + count =3D 0; + sw_ring =3D txq->sw_ring; + txr =3D txq->tx_ring; + + /* + * tx_tail is the last sent packet on the sw_ring. Goto the end + * of that packet (the last segment in the packet chain) and + * then the next segment will be the start of the oldest segment + * in the sw_ring. This is the first packet that will be + * attempted to be freed. + */ + + /* Get last segment in most recently added packet. */ + tx_last =3D sw_ring[txq->tx_tail].last_id; + + /* Get the next segment, which is the oldest segment in ring. */ + tx_first =3D sw_ring[tx_last].next_id; + + /* Set the current index to the first. */ + tx_id =3D tx_first; + + /* + * Loop through each packet. For each packet, verify that an + * mbuf exists and that the last segment is free. If so, free + * it and move on. + */ + while (1) { + tx_last =3D sw_ring[tx_id].last_id; + + if (sw_ring[tx_last].mbuf) { + if ((txr[tx_last].cmd_type_offset_bsz & + rte_cpu_to_le_64(I40E_TXD_QW1_DTYPE_MASK)) =3D=3D + rte_cpu_to_le_64(I40E_TX_DESC_DTYPE_DESC_DONE)) { + /* Get the start of the next packet. */ + tx_next =3D sw_ring[tx_last].next_id; + + /* + * Loop through all segments in a + * packet. + */ + do { + rte_pktmbuf_free_seg(sw_ring[tx_id].mbuf); + sw_ring[tx_id].mbuf =3D NULL; + sw_ring[tx_id].last_id =3D tx_id; + + /* Move to next segment. */ + tx_id =3D sw_ring[tx_id].next_id; + + } while (tx_id !=3D tx_next); + + /* + * Increment the number of packets + * freed. + */ + count++; + + if (unlikely(count =3D=3D (int)free_cnt)) + break; + } else { If the else is just break, then this if can be deleted. Please follow clean code, remove unnecessary tabs.=20 + /* + * mbuf still in use, nothing left to + * free. + */ + break; + } + } else { + /* + * There are multiple reasons to be here: + * 1) All the packets on the ring have been + * freed - tx_id is equal to tx_first + * and some packets have been freed. + * - Done, exit + * 2) Interfaces has not sent a rings worth of + * packets yet, so the segment after tail is + * still empty. Or a previous call to this + * function freed some of the segments but + * not all so there is a hole in the list. + * Hopefully this is a rare case. + * - Walk the list and find the next mbuf. If + * there isn't one, then done. + */ + if (likely(tx_id =3D=3D tx_first && count !=3D 0)) + break; + + /* + * Walk the list and find the next mbuf, if any. + */ + do { + /* Move to next segment. */ + tx_id =3D sw_ring[tx_id].next_id; + + if (sw_ring[tx_id].mbuf) + break; + + } while (tx_id !=3D tx_first); + + /* + * Determine why previous loop bailed. If there + * is not an mbuf, done. + */ + if (sw_ring[tx_id].mbuf =3D=3D NULL) + break; + } + } + + return count; +} + void i40e_reset_tx_queue(struct i40e_tx_queue *txq) { diff --git a/drivers/net= /i40e/i40e_rxtx.h b/drivers/net/i40e/i40e_rxtx.h index 2106bb355..8f11f011a= 100644 --- a/drivers/net/i40e/i40e_rxtx.h +++ b/drivers/net/i40e/i40e_rxtx.h @@ -212,6 +212,7 @@ void i40e_dev_free_queues(struct rte_eth_dev *dev); vo= id i40e_reset_rx_queue(struct i40e_rx_queue *rxq); void i40e_reset_tx_queu= e(struct i40e_tx_queue *txq); void i40e_tx_queue_release_mbufs(struct i40e= _tx_queue *txq); +int i40e_tx_done_cleanup(void *txq, uint32_t free_cnt); int i40e_alloc_rx_queue_mbufs(struct i40e_rx_queue *rxq); void i40e_rx_qu= eue_release_mbufs(struct i40e_rx_queue *rxq); =20 -- 2.17.1