From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D63BA04DD; Thu, 2 Jan 2020 03:48:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 614F21BF7C; Thu, 2 Jan 2020 03:48:19 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 6F0C11BF78 for ; Thu, 2 Jan 2020 03:48:16 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jan 2020 18:48:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,385,1571727600"; d="scan'208";a="231695707" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 01 Jan 2020 18:48:15 -0800 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Jan 2020 18:48:15 -0800 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 1 Jan 2020 18:48:15 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 1 Jan 2020 18:48:14 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.30]) by shsmsx102.ccr.corp.intel.com ([169.254.2.202]) with mapi id 14.03.0439.000; Thu, 2 Jan 2020 10:48:12 +0800 From: "Yang, Qiming" To: "Zhang, Qi Z" , "Ye, Xiaolong" CC: "Wang, Haiyue" , "dev@dpdk.org" , "Zhang, Qi Z" , "Stillwell Jr, Paul M" Thread-Topic: [dpdk-dev] [PATCH 15/17] net/iavf/base: fix send adminq return value Thread-Index: AQHVqafAZukQQXNEO06Gu1xdLDXLQKfW2r8A Date: Thu, 2 Jan 2020 02:48:12 +0000 Message-ID: References: <20191203070318.39620-1-qi.z.zhang@intel.com> <20191203070318.39620-16-qi.z.zhang@intel.com> In-Reply-To: <20191203070318.39620-16-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2Y5ZDM0NmQtYmZmYi00NzM5LTljMjktMjBjOGUyMjhhMDdlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUEdQV1Z2aGNmYUNkeVpFekpuOXpIT2Yya000UUpNdTNJbUNtbzIxaEF0ODh2UmVjT2Zyc0U5XC9wNCtsakJubWQifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 15/17] net/iavf/base: fix send adminq return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang > Sent: Tuesday, December 3, 2019 3:03 PM > To: Ye, Xiaolong > Cc: Wang, Haiyue ; dev@dpdk.org; Zhang, Qi Z > ; Stillwell Jr, Paul M > Subject: [dpdk-dev] [PATCH 15/17] net/iavf/base: fix send adminq return > value >=20 > When send a adminq, if get IAVF_AQ_RC_BUSY, we should return > IAVF_ERR_NOT_READY. >=20 > Fixes: e5b2a9e957e7 ("net/avf/base: add base code for avf PMD") >=20 Lack of CC stable > Signed-off-by: Paul M Stillwell Jr > Signed-off-by: Qi Zhang > --- > drivers/net/iavf/base/iavf_adminq.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/iavf/base/iavf_adminq.c > b/drivers/net/iavf/base/iavf_adminq.c > index 0a5b2b281..c1668d228 100644 > --- a/drivers/net/iavf/base/iavf_adminq.c > +++ b/drivers/net/iavf/base/iavf_adminq.c > @@ -803,6 +803,8 @@ enum iavf_status iavf_asq_send_command(struct > iavf_hw *hw, > cmd_completed =3D true; > if ((enum iavf_admin_queue_err)retval =3D=3D IAVF_AQ_RC_OK) > status =3D IAVF_SUCCESS; > + else if ((enum iavf_admin_queue_err)retval =3D=3D > IAVF_AQ_RC_EBUSY) > + status =3D IAVF_ERR_NOT_READY; > else > status =3D IAVF_ERR_ADMIN_QUEUE_ERROR; > hw->aq.asq_last_status =3D (enum > iavf_admin_queue_err)retval; > -- > 2.13.6