DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Yang, Qiming" <qiming.yang@intel.com>
To: "Wang, Haiyue" <haiyue.wang@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"stephen@networkplumber.org" <stephen@networkplumber.org>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	"Ye, Xiaolong" <xiaolong.ye@intel.com>
Cc: "Wang, Haiyue" <haiyue.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/ice: use the copy API to do MAC assignment
Date: Fri, 3 Jan 2020 02:23:26 +0000	[thread overview]
Message-ID: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF17A5A84F8@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20200103020204.11356-1-haiyue.wang@intel.com>


> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Haiyue Wang
> Sent: Friday, January 3, 2020 10:02 AM
> To: dev@dpdk.org; stephen@networkplumber.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>
> Cc: Wang, Haiyue <haiyue.wang@intel.com>
> Subject: [dpdk-dev] [PATCH v2] net/ice: use the copy API to do MAC
> assignment
> 
> Use the fast copy an Ethernet address API to do MAC assignment, instead of

I think the grammar is not right. Do you want to say 'Use rte_ether_addr_copy API to copy an Ethernet address'?

> calling rte_memcpy function.
> 
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
> v2: Update the commit title and message, use the rte_ether_addr_copy API
>     instead of just changing the length definition to make code style clean.
> 
>  drivers/net/ice/ice_ethdev.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index
> 2cbd82c94..d104df26f 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -873,7 +873,7 @@ ice_add_mac_filter(struct ice_vsi *vsi, struct
> rte_ether_addr *mac_addr)
>  		ret = -ENOMEM;
>  		goto DONE;
>  	}
> -	rte_memcpy(&f->mac_info.mac_addr, mac_addr, ETH_ADDR_LEN);
> +	rte_ether_addr_copy(mac_addr, &f->mac_info.mac_addr);
>  	TAILQ_INSERT_TAIL(&vsi->mac_list, f, next);
>  	vsi->mac_num++;
> 
> @@ -1660,16 +1660,16 @@ ice_setup_vsi(struct ice_pf *pf, enum
> ice_vsi_type type)
> 
>  	if (type == ICE_VSI_PF) {
>  		/* MAC configuration */
> -		rte_memcpy(pf->dev_addr.addr_bytes,
> -			   hw->port_info->mac.perm_addr,
> -			   ETH_ADDR_LEN);
> +		rte_ether_addr_copy((struct rte_ether_addr *)
> +					hw->port_info->mac.perm_addr,
> +				    &pf->dev_addr);
> 
> -		rte_memcpy(&mac_addr, &pf->dev_addr,
> RTE_ETHER_ADDR_LEN);
> +		rte_ether_addr_copy(&pf->dev_addr, &mac_addr);
>  		ret = ice_add_mac_filter(vsi, &mac_addr);
>  		if (ret != ICE_SUCCESS)
>  			PMD_INIT_LOG(ERR, "Failed to add dflt MAC filter");
> 
> -		rte_memcpy(&mac_addr, &broadcast,
> RTE_ETHER_ADDR_LEN);
> +		rte_ether_addr_copy(&broadcast, &mac_addr);
>  		ret = ice_add_mac_filter(vsi, &mac_addr);
>  		if (ret != ICE_SUCCESS)
>  			PMD_INIT_LOG(ERR, "Failed to add MAC filter"); @@
> -3267,7 +3267,7 @@ static int ice_macaddr_set(struct rte_eth_dev *dev,
>  		PMD_DRV_LOG(ERR, "Failed to add mac filter");
>  		return -EIO;
>  	}
> -	memcpy(&pf->dev_addr, mac_addr, ETH_ADDR_LEN);
> +	rte_ether_addr_copy(mac_addr, &pf->dev_addr);
> 
>  	flags = ICE_AQC_MAN_MAC_UPDATE_LAA_WOL;
>  	ret = ice_aq_manage_mac_write(hw, mac_addr->addr_bytes, flags,
> NULL);
> --
> 2.17.1


  reply	other threads:[~2020-01-03  2:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-02  7:14 [dpdk-dev] [PATCH v1] net/ice: align with MAC address length definition Haiyue Wang
2020-01-02 14:01 ` Zhang, Qi Z
2020-01-02 17:36 ` Stephen Hemminger
2020-01-03  1:15   ` Wang, Haiyue
2020-01-03  2:02 ` [dpdk-dev] [PATCH v2] net/ice: use the copy API to do MAC assignment Haiyue Wang
2020-01-03  2:23   ` Yang, Qiming [this message]
2020-01-03  2:59     ` Wang, Haiyue
2020-01-03  2:58 ` [dpdk-dev] [PATCH v3] " Haiyue Wang
2020-01-06  2:45   ` Yang, Qiming
2020-01-13  8:05   ` Ye Xiaolong
2020-01-13  8:29     ` Wang, Haiyue
2020-01-13  8:22 ` [dpdk-dev] [PATCH v4] " Haiyue Wang
2020-01-13  8:32   ` Ye Xiaolong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F5DF4F0E3AFEF648ADC1C3C33AD4DBF17A5A84F8@SHSMSX101.ccr.corp.intel.com \
    --to=qiming.yang@intel.com \
    --cc=dev@dpdk.org \
    --cc=haiyue.wang@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stephen@networkplumber.org \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).