From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2184CA04FD; Tue, 14 Jan 2020 08:30:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F0A531BFA5; Tue, 14 Jan 2020 08:30:20 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id C5A831BF9C for ; Tue, 14 Jan 2020 08:30:19 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2020 23:30:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,432,1571727600"; d="scan'208";a="225144590" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 13 Jan 2020 23:30:18 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jan 2020 23:30:18 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jan 2020 23:30:17 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.30]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.203]) with mapi id 14.03.0439.000; Tue, 14 Jan 2020 15:30:16 +0800 From: "Yang, Qiming" To: "Wang, Haiyue" , "dev@dpdk.org" , "Ye, Xiaolong" , "Zhang, Qi Z" Thread-Topic: [PATCH v1 2/2] net/ice: unify the bool type value Thread-Index: AQHVypuyQaHpNRDwA0+YGUlnTqS3rafpw61g Date: Tue, 14 Jan 2020 07:30:16 +0000 Message-ID: References: <20200114052258.78791-1-haiyue.wang@intel.com> <20200114052258.78791-2-haiyue.wang@intel.com> In-Reply-To: <20200114052258.78791-2-haiyue.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTQzMjQxYTgtZjYzYy00ZGIwLWI4ZGUtZTQ2YmZmZTYxMTk2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaXZqTDc5eXJDRHhlT25vbkpLbFZxdG9XXC9vYmFOR3BvdFVZVkM2YUZpWWJ3ckd2eXR5alg5YzliRWxFOUJkVzIifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 2/2] net/ice: unify the bool type value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Wang, Haiyue > Sent: Tuesday, January 14, 2020 1:23 PM > To: dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z > ; Yang, Qiming > Cc: Wang, Haiyue > Subject: [PATCH v1 2/2] net/ice: unify the bool type value >=20 > Replaces the redefined TRUE and FALSE values with standard ones to match = the > 'bool' type definition. >=20 > Signed-off-by: Haiyue Wang Acked-by: Qiming Yang > --- > drivers/net/ice/ice_ethdev.c | 22 +++++++++++----------- > drivers/net/ice/ice_rxtx.c | 16 ++++++++-------- > 2 files changed, 19 insertions(+), 19 deletions(-) >=20 > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c = index > f99eb4e1b..8e9369e0a 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -1720,7 +1720,7 @@ ice_pf_setup(struct ice_pf *pf) > uint16_t unused; >=20 > /* Clear all stats counters */ > - pf->offset_loaded =3D FALSE; > + pf->offset_loaded =3D false; > memset(&pf->stats, 0, sizeof(struct ice_hw_port_stats)); > memset(&pf->stats_offset, 0, sizeof(struct ice_hw_port_stats)); > memset(&pf->internal_stats, 0, sizeof(struct ice_eth_stats)); @@ - > 2234,16 +2234,16 @@ ice_dev_init(struct rte_eth_dev *dev) > vsi =3D pf->main_vsi; >=20 > /* Disable double vlan by default */ > - ice_vsi_config_double_vlan(vsi, FALSE); > + ice_vsi_config_double_vlan(vsi, false); >=20 > - ret =3D ice_aq_stop_lldp(hw, TRUE, FALSE, NULL); > + ret =3D ice_aq_stop_lldp(hw, true, false, NULL); > if (ret !=3D ICE_SUCCESS) > PMD_INIT_LOG(DEBUG, "lldp has already stopped\n"); > - ret =3D ice_init_dcb(hw, TRUE); > + ret =3D ice_init_dcb(hw, true); > if (ret !=3D ICE_SUCCESS) > PMD_INIT_LOG(DEBUG, "Failed to init DCB\n"); > /* Forward LLDP packets to default VSI */ > - ret =3D ice_vsi_config_sw_lldp(vsi, TRUE); > + ret =3D ice_vsi_config_sw_lldp(vsi, true); > if (ret !=3D ICE_SUCCESS) > PMD_INIT_LOG(DEBUG, "Failed to cfg lldp\n"); > /* register callback func to eal lib */ @@ -3449,23 +3449,23 @@ > ice_vlan_offload_set(struct rte_eth_dev *dev, int mask) > rxmode =3D &dev->data->dev_conf.rxmode; > if (mask & ETH_VLAN_FILTER_MASK) { > if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_FILTER) > - ice_vsi_config_vlan_filter(vsi, TRUE); > + ice_vsi_config_vlan_filter(vsi, true); > else > - ice_vsi_config_vlan_filter(vsi, FALSE); > + ice_vsi_config_vlan_filter(vsi, false); > } >=20 > if (mask & ETH_VLAN_STRIP_MASK) { > if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_STRIP) > - ice_vsi_config_vlan_stripping(vsi, TRUE); > + ice_vsi_config_vlan_stripping(vsi, true); > else > - ice_vsi_config_vlan_stripping(vsi, FALSE); > + ice_vsi_config_vlan_stripping(vsi, false); > } >=20 > if (mask & ETH_VLAN_EXTEND_MASK) { > if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_EXTEND) > - ice_vsi_config_double_vlan(vsi, TRUE); > + ice_vsi_config_double_vlan(vsi, true); > else > - ice_vsi_config_double_vlan(vsi, FALSE); > + ice_vsi_config_double_vlan(vsi, false); > } >=20 > return 0; > diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c inde= x > ce499af43..ad3cb9c46 100644 > --- a/drivers/net/ice/ice_rxtx.c > +++ b/drivers/net/ice/ice_rxtx.c > @@ -424,7 +424,7 @@ ice_rx_queue_start(struct rte_eth_dev *dev, uint16_t > rx_queue_id) > /* Init the RX tail register. */ > ICE_PCI_REG_WRITE(rxq->qrx_tail, rxq->nb_rx_desc - 1); >=20 > - err =3D ice_switch_rx_queue(hw, rxq->reg_idx, TRUE); > + err =3D ice_switch_rx_queue(hw, rxq->reg_idx, true); > if (err) { > PMD_DRV_LOG(ERR, "Failed to switch RX queue %u on", > rx_queue_id); > @@ -450,7 +450,7 @@ ice_rx_queue_stop(struct rte_eth_dev *dev, uint16_t > rx_queue_id) > if (rx_queue_id < dev->data->nb_rx_queues) { > rxq =3D dev->data->rx_queues[rx_queue_id]; >=20 > - err =3D ice_switch_rx_queue(hw, rxq->reg_idx, FALSE); > + err =3D ice_switch_rx_queue(hw, rxq->reg_idx, false); > if (err) { > PMD_DRV_LOG(ERR, "Failed to switch RX queue %u > off", > rx_queue_id); > @@ -630,7 +630,7 @@ ice_fdir_rx_queue_start(struct rte_eth_dev *dev, > uint16_t rx_queue_id) > /* Init the RX tail register. */ > ICE_PCI_REG_WRITE(rxq->qrx_tail, rxq->nb_rx_desc - 1); >=20 > - err =3D ice_switch_rx_queue(hw, rxq->reg_idx, TRUE); > + err =3D ice_switch_rx_queue(hw, rxq->reg_idx, true); > if (err) { > PMD_DRV_LOG(ERR, "Failed to switch FDIR RX queue %u on", > rx_queue_id); > @@ -816,7 +816,7 @@ ice_fdir_rx_queue_stop(struct rte_eth_dev *dev, > uint16_t rx_queue_id) >=20 > rxq =3D pf->fdir.rxq; >=20 > - err =3D ice_switch_rx_queue(hw, rxq->reg_idx, FALSE); > + err =3D ice_switch_rx_queue(hw, rxq->reg_idx, false); > if (err) { > PMD_DRV_LOG(ERR, "Failed to switch FDIR RX queue %u off", > rx_queue_id); > @@ -973,7 +973,7 @@ ice_rx_queue_setup(struct rte_eth_dev *dev, > } >=20 > ice_reset_rx_queue(rxq); > - rxq->q_set =3D TRUE; > + rxq->q_set =3D true; > dev->data->rx_queues[queue_idx] =3D rxq; > rxq->rx_rel_mbufs =3D _ice_rx_queue_release_mbufs; >=20 > @@ -1186,7 +1186,7 @@ ice_tx_queue_setup(struct rte_eth_dev *dev, > } >=20 > ice_reset_tx_queue(txq); > - txq->q_set =3D TRUE; > + txq->q_set =3D true; > dev->data->tx_queues[queue_idx] =3D txq; > txq->tx_rel_mbufs =3D _ice_tx_queue_release_mbufs; > ice_set_tx_function_flag(dev, txq); > @@ -2043,7 +2043,7 @@ ice_fdir_setup_tx_resources(struct ice_pf *pf) > * don't need to allocate software ring and reset for the fdir > * program queue just set the queue has been configured. > */ > - txq->q_set =3D TRUE; > + txq->q_set =3D true; > pf->fdir.txq =3D txq; >=20 > txq->tx_rel_mbufs =3D _ice_tx_queue_release_mbufs; @@ -2104,7 > +2104,7 @@ ice_fdir_setup_rx_resources(struct ice_pf *pf) > * Don't need to allocate software ring and reset for the fdir > * rx queue, just set the queue has been configured. > */ > - rxq->q_set =3D TRUE; > + rxq->q_set =3D true; > pf->fdir.rxq =3D rxq; >=20 > rxq->rx_rel_mbufs =3D _ice_rx_queue_release_mbufs; > -- > 2.17.1