From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <keith.wiles@intel.com> Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 8291B2C4F for <dev@dpdk.org>; Tue, 22 May 2018 21:59:35 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2018 12:59:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,430,1520924400"; d="scan'208";a="201575358" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 22 May 2018 12:59:33 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 22 May 2018 12:59:33 -0700 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.235]) by FMSMSX102.amr.corp.intel.com ([169.254.10.39]) with mapi id 14.03.0319.002; Tue, 22 May 2018 12:59:33 -0700 From: "Wiles, Keith" <keith.wiles@intel.com> To: Alexandru Ciobotaru <alex.ciobotaru@gmail.com> CC: "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [dpdk-dev] Question about adding a new EAL Thread-Index: AQHT8gKlXsoBaN/AJ0CoCHHP4x2UHKQ8oCAA Date: Tue, 22 May 2018 19:59:32 +0000 Message-ID: <F6067F30-FB9E-42C2-82BF-606D4DF847EB@intel.com> References: <CANKOshyKZACv4DSmTLcUTGxcrFNfCs3i3__HwXbjutCsZDcp+g@mail.gmail.com> In-Reply-To: <CANKOshyKZACv4DSmTLcUTGxcrFNfCs3i3__HwXbjutCsZDcp+g@mail.gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.53.246] Content-Type: text/plain; charset="us-ascii" Content-ID: <B48B7C8A98A1DB41992AAAF4AFB373C8@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] Question about adding a new EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 22 May 2018 19:59:36 -0000 Must use text only :-( darn mail program > On May 22, 2018, at 2:23 PM, Alexandru Ciobotaru <alex.ciobotaru@gmail.co= m> wrote: >=20 > Greetings, I can not answer all of your questions, but maybe a few. >=20 > I'm currently checking on how to add new EAL "app" to the DPDK so I start= ed > by adding a new "xyzapp" next to "linuxapp" and "bsdapp". > Now, I would probably expect to make this new EAL mainline compliant on > day, and to avoid future headaches, the plan is to avoid modifying things > outside of my "xyzapp". > And thus, the first adaptation issue has arrived: >=20 > EAL is designed so that I can re-implement the "common" source files into > my "xyzapp" but how would I override the "include/rte_xyz.h" headers from > the "common" part of the EAL library (e.g. > librte_eal/common/include/rte_eal.h)? Some of the includes in these heade= rs > are currently N/A to my toolchain (via CROSS=3D) or to my executive > environment. Normally, these types of differences are just empty variables or something = that allows the system build even when you do not support it. > For example I do not have <sched.h> or <sys/queue.h> which are currently > included in some EAL API headers. Maybe you should make simple empty headers, to work around those headers. I= am sure it would be easier, but maybe someone has a better idea. > Should more work into making the "common" part truly generic be put into > this? We always like to see patches to make the EAL simpler to maintain, so pleas= e introduce a patch. > Is the current EAL API frozen for compatibility reasons? Any "next" branc= h > where such modifications are accepted? Changing a EAL API is really discouraged as it effect a lot of places. But = we do have a method to change exposed APIs. It will take two releases to ge= t your change into DPDK the first release gives notice and the second one a= llows the API to exist in the code. You can read more abort the process her= e: http://dpdk.org/dev make sure you read it all :-) > Or, is there a straight method of enforcing my "xyzapp" symlinked EAL > headers in the build directory without modifying the "common" Makefile? You should avoid symlinks in the main repo directories as they are difficul= t to maintain and some systems do not support them. You may want to do an RFC email subject to discuss your ideas on changing E= AL code first to eliminate extra work. >=20 > Thank you, > Alex Regards, Keith