From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pawelx.wodkowski@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 16EAE1F5
 for <dev@dpdk.org>; Thu, 18 May 2017 11:06:04 +0200 (CEST)
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
 by orsmga104.jf.intel.com with ESMTP; 18 May 2017 02:06:03 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,358,1491289200"; d="scan'208";a="103495481"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
 by fmsmga005.fm.intel.com with ESMTP; 18 May 2017 02:06:03 -0700
Received: from irsmsx102.ger.corp.intel.com ([169.254.2.153]) by
 IRSMSX101.ger.corp.intel.com ([163.33.3.153]) with mapi id 14.03.0319.002;
 Thu, 18 May 2017 10:06:02 +0100
From: "Wodkowski, PawelX" <pawelx.wodkowski@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [RFC][PATCH] vfio: allow to map other memory regions
Thread-Index: AQHSzv1AHusgcxidwE23C83NG26qeqH4tP2AgAEXznA=
Date: Thu, 18 May 2017 09:06:01 +0000
Message-ID: <F6F2A6264E145F47A18AB6DF8E87425D24BA296E@IRSMSX102.ger.corp.intel.com>
References: <1495032287-216322-1-git-send-email-pawelx.wodkowski@intel.com>
 <20170517102023.3c78590e@xeon-e3>
In-Reply-To: <20170517102023.3c78590e@xeon-e3>
Accept-Language: pl-PL, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [RFC][PATCH] vfio: allow to map other memory regions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 18 May 2017 09:06:05 -0000

> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Wednesday, May 17, 2017 7:20 PM
> To: Wodkowski, PawelX <pawelx.wodkowski@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [RFC][PATCH] vfio: allow to map other memory regi=
ons
>=20
> On Wed, 17 May 2017 16:44:46 +0200
> Pawel Wodkowski <pawelx.wodkowski@intel.com> wrote:
>=20
> >  /* IOMMU types we support */
> >  static const struct vfio_iommu_type iommu_types[] =3D {
> >  	/* x86 IOMMU, otherwise known as type 1 */
> > -	{ RTE_VFIO_TYPE1, "Type 1", &vfio_type1_dma_map},
> > +	{ RTE_VFIO_TYPE1, "Type 1", &vfio_type1_dma_map,
> &vfio_type1_dma_mem_map},
> >  	/* ppc64 IOMMU, otherwise known as spapr */
> > -	{ RTE_VFIO_SPAPR, "sPAPR", &vfio_spapr_dma_map},
> > +	{ RTE_VFIO_SPAPR, "sPAPR", &vfio_spapr_dma_map, NULL},
> >  	/* IOMMU-less mode */
> > -	{ RTE_VFIO_NOIOMMU, "No-IOMMU", &vfio_noiommu_dma_map},
> > +	{ RTE_VFIO_NOIOMMU, "No-IOMMU", &vfio_noiommu_dma_map,
> &vfio_noiommu_dma_mem_map},
> >  };
>=20
> For complex tables like this why not use C99 style initializer.

Sure will change it in next version.
Any comments about functional side of this change before v2 ? :)

Pawel