From: Yongseok Koh <yskoh@mellanox.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: [dpdk-dev] Compilation error by "net/bnxt: add support to set VF rxmode"
Date: Wed, 14 Jun 2017 18:01:46 +0000 [thread overview]
Message-ID: <FA0FAC14-5354-4D4E-8D2F-B8E9575F3C7B@mellanox.com> (raw)
Hi, Ajit
It looks you missed some #ifdef/endif when you made newer version for the following patch.
http://dpdk.org/dev/patchwork/patch/25011
Currently, if RTE_LIBRTE_IXGBE_PMD isn't enabled, a compilation error occurs.
> CC cperf_test_latency.o
> LD dpdk-pdump
> app/test-pmd/cmdline.c:13817:27: error: ‘cmd_set_vf_rxmode’ undeclared here (not in a function)
> (cmdline_parse_inst_t *)&cmd_set_vf_rxmode,
> ^
> make[3]: *** [cmdline.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
It is because you moved it out of RTE_LIBRTE_IXGBE_PMD macro.
> @@ -13786,9 +13795,9 @@ cmdline_parse_ctx_t main_ctx[] = {
>
> (cmdline_parse_inst_t *)&cmd_set_macsec_offload_off,
> (cmdline_parse_inst_t *)&cmd_set_macsec_sc,
> (cmdline_parse_inst_t *)&cmd_set_macsec_sa,
>
> - (cmdline_parse_inst_t *)&cmd_set_vf_rxmode,
>
> (cmdline_parse_inst_t *)&cmd_set_vf_traffic,
> #endif
>
> + (cmdline_parse_inst_t *)&cmd_set_vf_rxmode,
>
> (cmdline_parse_inst_t *)&cmd_vf_rate_limit,
> (cmdline_parse_inst_t *)&cmd_vf_rxvlan_filter,
> (cmdline_parse_inst_t *)&cmd_set_vf_mac_addr,
Thanks,
Yongseok
next reply other threads:[~2017-06-14 18:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 18:01 Yongseok Koh [this message]
2017-06-15 16:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FA0FAC14-5354-4D4E-8D2F-B8E9575F3C7B@mellanox.com \
--to=yskoh@mellanox.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).