* [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule passthrough mode
@ 2020-05-08 1:22 Simei Su
[not found] ` <35e49819d2b24673a62a497b173e8bb3@intel.com>
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Simei Su @ 2020-05-08 1:22 UTC (permalink / raw)
To: qi.z.zhang, xiaolong.ye; +Cc: dev, yahui.cao, simei.su
This patch adds support for FDIR passthrough mode. When FDIR rule
hits, FDIR just forward this packet to the next stage filter.
Fixes: 55daca4e45fc ("net/ice/base: change function to static")
Signed-off-by: Simei Su <simei.su@intel.com>
---
drivers/net/ice/base/ice_fdir.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ice/base/ice_fdir.c b/drivers/net/ice/base/ice_fdir.c
index c703a7c..33a1732 100644
--- a/drivers/net/ice/base/ice_fdir.c
+++ b/drivers/net/ice/base/ice_fdir.c
@@ -465,6 +465,10 @@
if (input->dest_ctl == ICE_FLTR_PRGM_DESC_DEST_DROP_PKT) {
fdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_YES;
fdir_fltr_ctx.qindex = 0;
+ } else if (input->dest_ctl ==
+ ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER) {
+ fdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_NO;
+ fdir_fltr_ctx.qindex = 0;
} else {
if (input->dest_ctl ==
ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QGROUP)
@@ -476,7 +480,10 @@
fdir_fltr_ctx.cnt_index = input->cnt_index;
fdir_fltr_ctx.fd_vsi = ice_get_hw_vsi_num(hw, input->dest_vsi);
fdir_fltr_ctx.evict_ena = ICE_FXD_FLTR_QW0_EVICT_ENA_FALSE;
- fdir_fltr_ctx.toq_prio = 3;
+ if (input->dest_ctl == ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER)
+ fdir_fltr_ctx.toq_prio = 0;
+ else
+ fdir_fltr_ctx.toq_prio = 3;
fdir_fltr_ctx.pcmd = (add) ? ICE_FXD_FLTR_QW1_PCMD_ADD :
ICE_FXD_FLTR_QW1_PCMD_REMOVE;
fdir_fltr_ctx.swap = ICE_FXD_FLTR_QW1_SWAP_NOT_SET;
--
1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread[parent not found: <35e49819d2b24673a62a497b173e8bb3@intel.com>]
* Re: [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule passthrough mode [not found] ` <35e49819d2b24673a62a497b173e8bb3@intel.com> @ 2020-05-08 9:34 ` Zeng, XiaoxiaoX 0 siblings, 0 replies; 7+ messages in thread From: Zeng, XiaoxiaoX @ 2020-05-08 9:34 UTC (permalink / raw) To: Zhang, Qi Z, Ye, Xiaolong; +Cc: dev, Su, Simei, Cao, Yahui Tested-by: Zeng,Xiaoxiao<xiaoxiaox.zeng@intel.com> Best regards, Zeng,xiaoxiao > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Simei Su > Sent: Friday, May 8, 2020 9:22 AM > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Ye, Xiaolong > <xiaolong.ye@intel.com> > Cc: dev@dpdk.org; Cao, Yahui <yahui.cao@intel.com>; Su, Simei > <simei.su@intel.com> > Subject: [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule passthrough mode > > This patch adds support for FDIR passthrough mode. When FDIR rule hits, > FDIR just forward this packet to the next stage filter. > > Fixes: 55daca4e45fc ("net/ice/base: change function to static") > > Signed-off-by: Simei Su <simei.su@intel.com> > --- > drivers/net/ice/base/ice_fdir.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ice/base/ice_fdir.c b/drivers/net/ice/base/ice_fdir.c > index c703a7c..33a1732 100644 > --- a/drivers/net/ice/base/ice_fdir.c > +++ b/drivers/net/ice/base/ice_fdir.c > @@ -465,6 +465,10 @@ > if (input->dest_ctl == ICE_FLTR_PRGM_DESC_DEST_DROP_PKT) { > fdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_YES; > fdir_fltr_ctx.qindex = 0; > + } else if (input->dest_ctl == > + ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER) { > + fdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_NO; > + fdir_fltr_ctx.qindex = 0; > } else { > if (input->dest_ctl == > ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QGROUP) > @@ -476,7 +480,10 @@ > fdir_fltr_ctx.cnt_index = input->cnt_index; > fdir_fltr_ctx.fd_vsi = ice_get_hw_vsi_num(hw, input->dest_vsi); > fdir_fltr_ctx.evict_ena = ICE_FXD_FLTR_QW0_EVICT_ENA_FALSE; > - fdir_fltr_ctx.toq_prio = 3; > + if (input->dest_ctl == > ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER) > + fdir_fltr_ctx.toq_prio = 0; > + else > + fdir_fltr_ctx.toq_prio = 3; > fdir_fltr_ctx.pcmd = (add) ? ICE_FXD_FLTR_QW1_PCMD_ADD : > ICE_FXD_FLTR_QW1_PCMD_REMOVE; > fdir_fltr_ctx.swap = ICE_FXD_FLTR_QW1_SWAP_NOT_SET; > -- > 1.8.3.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule passthrough mode 2020-05-08 1:22 [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule passthrough mode Simei Su [not found] ` <35e49819d2b24673a62a497b173e8bb3@intel.com> @ 2020-05-15 6:44 ` Zhang, Qi Z 2020-05-15 6:50 ` Ye Xiaolong 2020-05-18 0:47 ` Ye Xiaolong 3 siblings, 0 replies; 7+ messages in thread From: Zhang, Qi Z @ 2020-05-15 6:44 UTC (permalink / raw) To: Su, Simei, Ye, Xiaolong; +Cc: dev, Cao, Yahui > -----Original Message----- > From: Su, Simei <simei.su@intel.com> > Sent: Friday, May 8, 2020 9:22 AM > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com> > Cc: dev@dpdk.org; Cao, Yahui <yahui.cao@intel.com>; Su, Simei > <simei.su@intel.com> > Subject: [PATCH] net/ice/base: fix FDIR rule passthrough mode > > This patch adds support for FDIR passthrough mode. When FDIR rule hits, > FDIR just forward this packet to the next stage filter. > > Fixes: 55daca4e45fc ("net/ice/base: change function to static") > > Signed-off-by: Simei Su <simei.su@intel.com> Acked-by: Qi Zhang <qi.z.zhang@intel.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule passthrough mode 2020-05-08 1:22 [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule passthrough mode Simei Su [not found] ` <35e49819d2b24673a62a497b173e8bb3@intel.com> 2020-05-15 6:44 ` Zhang, Qi Z @ 2020-05-15 6:50 ` Ye Xiaolong 2020-05-15 8:33 ` Su, Simei 2020-05-18 0:47 ` Ye Xiaolong 3 siblings, 1 reply; 7+ messages in thread From: Ye Xiaolong @ 2020-05-15 6:50 UTC (permalink / raw) To: Simei Su; +Cc: qi.z.zhang, dev, yahui.cao Hi, simei On 05/08, Simei Su wrote: >This patch adds support for FDIR passthrough mode. When FDIR rule >hits, FDIR just forward this packet to the next stage filter. > >Fixes: 55daca4e45fc ("net/ice/base: change function to static") This commit doesn't make sense to me, it just change the function to static, so should have any functional impact. Thanks, Xiaolong > >Signed-off-by: Simei Su <simei.su@intel.com> >--- > drivers/net/ice/base/ice_fdir.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > >diff --git a/drivers/net/ice/base/ice_fdir.c b/drivers/net/ice/base/ice_fdir.c >index c703a7c..33a1732 100644 >--- a/drivers/net/ice/base/ice_fdir.c >+++ b/drivers/net/ice/base/ice_fdir.c >@@ -465,6 +465,10 @@ > if (input->dest_ctl == ICE_FLTR_PRGM_DESC_DEST_DROP_PKT) { > fdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_YES; > fdir_fltr_ctx.qindex = 0; >+ } else if (input->dest_ctl == >+ ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER) { >+ fdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_NO; >+ fdir_fltr_ctx.qindex = 0; > } else { > if (input->dest_ctl == > ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QGROUP) >@@ -476,7 +480,10 @@ > fdir_fltr_ctx.cnt_index = input->cnt_index; > fdir_fltr_ctx.fd_vsi = ice_get_hw_vsi_num(hw, input->dest_vsi); > fdir_fltr_ctx.evict_ena = ICE_FXD_FLTR_QW0_EVICT_ENA_FALSE; >- fdir_fltr_ctx.toq_prio = 3; >+ if (input->dest_ctl == ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER) >+ fdir_fltr_ctx.toq_prio = 0; >+ else >+ fdir_fltr_ctx.toq_prio = 3; > fdir_fltr_ctx.pcmd = (add) ? ICE_FXD_FLTR_QW1_PCMD_ADD : > ICE_FXD_FLTR_QW1_PCMD_REMOVE; > fdir_fltr_ctx.swap = ICE_FXD_FLTR_QW1_SWAP_NOT_SET; >-- >1.8.3.1 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule passthrough mode 2020-05-15 6:50 ` Ye Xiaolong @ 2020-05-15 8:33 ` Su, Simei 2020-05-18 0:44 ` Ye Xiaolong 0 siblings, 1 reply; 7+ messages in thread From: Su, Simei @ 2020-05-15 8:33 UTC (permalink / raw) To: Ye, Xiaolong; +Cc: Zhang, Qi Z, dev, Cao, Yahui Hi, xiaolong > -----Original Message----- > From: Ye, Xiaolong <xiaolong.ye@intel.com> > Sent: Friday, May 15, 2020 2:50 PM > To: Su, Simei <simei.su@intel.com> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; dev@dpdk.org; Cao, Yahui > <yahui.cao@intel.com> > Subject: Re: [PATCH] net/ice/base: fix FDIR rule passthrough mode > > Hi, simei > > On 05/08, Simei Su wrote: > >This patch adds support for FDIR passthrough mode. When FDIR rule hits, > >FDIR just forward this packet to the next stage filter. > > > >Fixes: 55daca4e45fc ("net/ice/base: change function to static") > > This commit doesn't make sense to me, it just change the function to static, so > should have any functional impact. > > Thanks, > Xiaolong Besides changing the function to static, it also removes passthrough mode support. So it leads to a bug that it doesn't support fdir passthrough. Br Simei > > > > >Signed-off-by: Simei Su <simei.su@intel.com> > >--- > > drivers/net/ice/base/ice_fdir.c | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > >diff --git a/drivers/net/ice/base/ice_fdir.c > >b/drivers/net/ice/base/ice_fdir.c index c703a7c..33a1732 100644 > >--- a/drivers/net/ice/base/ice_fdir.c > >+++ b/drivers/net/ice/base/ice_fdir.c > >@@ -465,6 +465,10 @@ > > if (input->dest_ctl == ICE_FLTR_PRGM_DESC_DEST_DROP_PKT) { > > fdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_YES; > > fdir_fltr_ctx.qindex = 0; > >+ } else if (input->dest_ctl == > >+ ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER) { > >+ fdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_NO; > >+ fdir_fltr_ctx.qindex = 0; > > } else { > > if (input->dest_ctl == > > ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QGROUP) > >@@ -476,7 +480,10 @@ > > fdir_fltr_ctx.cnt_index = input->cnt_index; > > fdir_fltr_ctx.fd_vsi = ice_get_hw_vsi_num(hw, input->dest_vsi); > > fdir_fltr_ctx.evict_ena = ICE_FXD_FLTR_QW0_EVICT_ENA_FALSE; > >- fdir_fltr_ctx.toq_prio = 3; > >+ if (input->dest_ctl == ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER) > >+ fdir_fltr_ctx.toq_prio = 0; > >+ else > >+ fdir_fltr_ctx.toq_prio = 3; > > fdir_fltr_ctx.pcmd = (add) ? ICE_FXD_FLTR_QW1_PCMD_ADD : > > ICE_FXD_FLTR_QW1_PCMD_REMOVE; > > fdir_fltr_ctx.swap = ICE_FXD_FLTR_QW1_SWAP_NOT_SET; > >-- > >1.8.3.1 > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule passthrough mode 2020-05-15 8:33 ` Su, Simei @ 2020-05-18 0:44 ` Ye Xiaolong 0 siblings, 0 replies; 7+ messages in thread From: Ye Xiaolong @ 2020-05-18 0:44 UTC (permalink / raw) To: Su, Simei; +Cc: Zhang, Qi Z, dev, Cao, Yahui On 05/15, Su, Simei wrote: >Hi, xiaolong > >> -----Original Message----- >> From: Ye, Xiaolong <xiaolong.ye@intel.com> >> Sent: Friday, May 15, 2020 2:50 PM >> To: Su, Simei <simei.su@intel.com> >> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; dev@dpdk.org; Cao, Yahui >> <yahui.cao@intel.com> >> Subject: Re: [PATCH] net/ice/base: fix FDIR rule passthrough mode >> >> Hi, simei >> >> On 05/08, Simei Su wrote: >> >This patch adds support for FDIR passthrough mode. When FDIR rule hits, >> >FDIR just forward this packet to the next stage filter. >> > >> >Fixes: 55daca4e45fc ("net/ice/base: change function to static") >> >> This commit doesn't make sense to me, it just change the function to static, so >> should have any functional impact. >> >> Thanks, >> Xiaolong > >Besides changing the function to static, it also removes passthrough mode support. So it leads to a bug that it doesn't support >fdir passthrough. Got it, I was misled by the commit subject :) Thanks, Xiaolong > >Br >Simei > >> >> > >> >Signed-off-by: Simei Su <simei.su@intel.com> >> >--- >> > drivers/net/ice/base/ice_fdir.c | 9 ++++++++- >> > 1 file changed, 8 insertions(+), 1 deletion(-) >> > >> >diff --git a/drivers/net/ice/base/ice_fdir.c >> >b/drivers/net/ice/base/ice_fdir.c index c703a7c..33a1732 100644 >> >--- a/drivers/net/ice/base/ice_fdir.c >> >+++ b/drivers/net/ice/base/ice_fdir.c >> >@@ -465,6 +465,10 @@ >> > if (input->dest_ctl == ICE_FLTR_PRGM_DESC_DEST_DROP_PKT) { >> > fdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_YES; >> > fdir_fltr_ctx.qindex = 0; >> >+} else if (input->dest_ctl == >> >+ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER) { >> >+fdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_NO; >> >+fdir_fltr_ctx.qindex = 0; >> > } else { >> > if (input->dest_ctl == >> > ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QGROUP) >> >@@ -476,7 +480,10 @@ >> > fdir_fltr_ctx.cnt_index = input->cnt_index; >> > fdir_fltr_ctx.fd_vsi = ice_get_hw_vsi_num(hw, input->dest_vsi); >> > fdir_fltr_ctx.evict_ena = ICE_FXD_FLTR_QW0_EVICT_ENA_FALSE; >> >-fdir_fltr_ctx.toq_prio = 3; >> >+if (input->dest_ctl == ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER) >> >+fdir_fltr_ctx.toq_prio = 0; >> >+else >> >+fdir_fltr_ctx.toq_prio = 3; >> > fdir_fltr_ctx.pcmd = (add) ? ICE_FXD_FLTR_QW1_PCMD_ADD : >> > ICE_FXD_FLTR_QW1_PCMD_REMOVE; >> > fdir_fltr_ctx.swap = ICE_FXD_FLTR_QW1_SWAP_NOT_SET; >> >-- >> >1.8.3.1 >> > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule passthrough mode 2020-05-08 1:22 [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule passthrough mode Simei Su ` (2 preceding siblings ...) 2020-05-15 6:50 ` Ye Xiaolong @ 2020-05-18 0:47 ` Ye Xiaolong 3 siblings, 0 replies; 7+ messages in thread From: Ye Xiaolong @ 2020-05-18 0:47 UTC (permalink / raw) To: Simei Su; +Cc: qi.z.zhang, dev, yahui.cao On 05/08, Simei Su wrote: >This patch adds support for FDIR passthrough mode. When FDIR rule >hits, FDIR just forward this packet to the next stage filter. > >Fixes: 55daca4e45fc ("net/ice/base: change function to static") > >Signed-off-by: Simei Su <simei.su@intel.com> >--- > drivers/net/ice/base/ice_fdir.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > >diff --git a/drivers/net/ice/base/ice_fdir.c b/drivers/net/ice/base/ice_fdir.c >index c703a7c..33a1732 100644 >--- a/drivers/net/ice/base/ice_fdir.c >+++ b/drivers/net/ice/base/ice_fdir.c >@@ -465,6 +465,10 @@ > if (input->dest_ctl == ICE_FLTR_PRGM_DESC_DEST_DROP_PKT) { > fdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_YES; > fdir_fltr_ctx.qindex = 0; >+ } else if (input->dest_ctl == >+ ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER) { >+ fdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_NO; >+ fdir_fltr_ctx.qindex = 0; > } else { > if (input->dest_ctl == > ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QGROUP) >@@ -476,7 +480,10 @@ > fdir_fltr_ctx.cnt_index = input->cnt_index; > fdir_fltr_ctx.fd_vsi = ice_get_hw_vsi_num(hw, input->dest_vsi); > fdir_fltr_ctx.evict_ena = ICE_FXD_FLTR_QW0_EVICT_ENA_FALSE; >- fdir_fltr_ctx.toq_prio = 3; >+ if (input->dest_ctl == ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER) >+ fdir_fltr_ctx.toq_prio = 0; >+ else >+ fdir_fltr_ctx.toq_prio = 3; > fdir_fltr_ctx.pcmd = (add) ? ICE_FXD_FLTR_QW1_PCMD_ADD : > ICE_FXD_FLTR_QW1_PCMD_REMOVE; > fdir_fltr_ctx.swap = ICE_FXD_FLTR_QW1_SWAP_NOT_SET; >-- >1.8.3.1 > Applied to dpdk-next-net-intel, Thanks. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-05-18 0:55 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-08 1:22 [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule passthrough mode Simei Su
[not found] ` <35e49819d2b24673a62a497b173e8bb3@intel.com>
2020-05-08 9:34 ` Zeng, XiaoxiaoX
2020-05-15 6:44 ` Zhang, Qi Z
2020-05-15 6:50 ` Ye Xiaolong
2020-05-15 8:33 ` Su, Simei
2020-05-18 0:44 ` Ye Xiaolong
2020-05-18 0:47 ` Ye Xiaolong
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).