From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <shaopeng.he@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id A2F963796
 for <dev@dpdk.org>; Wed, 10 Jun 2015 03:03:16 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga103.jf.intel.com with ESMTP; 09 Jun 2015 18:03:13 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,584,1427785200"; d="scan'208";a="708263891"
Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105])
 by orsmga001.jf.intel.com with ESMTP; 09 Jun 2015 18:03:12 -0700
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
 PGSMSX107.gar.corp.intel.com (10.221.44.105) with Microsoft SMTP Server (TLS)
 id 14.3.224.2; Wed, 10 Jun 2015 09:03:11 +0800
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.165]) by
 SHSMSX151.ccr.corp.intel.com ([169.254.3.168]) with mapi id 14.03.0224.002;
 Wed, 10 Jun 2015 09:03:10 +0800
From: "He, Shaopeng" <shaopeng.he@intel.com>
To: "Qiu, Michael" <michael.qiu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH 2/3] fm10k: add MAC filter
Thread-Index: AQHQnOAnwMVyB+O7skCbm1ZaTwBSRp2k9+RQ
Date: Wed, 10 Jun 2015 01:03:10 +0000
Message-ID: <FB82FCC69332B84596FE0CEC3C1310949CED5B@shsmsx102.ccr.corp.intel.com>
References: <1433213937-21690-1-git-send-email-shaopeng.he@intel.com>
 <1433213937-21690-3-git-send-email-shaopeng.he@intel.com>
 <533710CFB86FA344BFBF2D6802E60286046959F8@SHSMSX101.ccr.corp.intel.com>
In-Reply-To: <533710CFB86FA344BFBF2D6802E60286046959F8@SHSMSX101.ccr.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 2/3] fm10k: add MAC filter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Jun 2015 01:03:17 -0000

> -----Original Message-----
> From: Qiu, Michael
> Sent: Wednesday, June 10, 2015 12:00 AM
> To: He, Shaopeng; dev@dpdk.org
> Cc: Chen, Jing D
> Subject: Re: [PATCH 2/3] fm10k: add MAC filter
>=20
> On 2015/6/2 10:59, He, Shaopeng wrote:
> > MAC filter function was newly added, each PF and VF can have up to 64
> > MAC addresses. VF filter needs support from PF host, which is not avail=
able
> now.
> >
> > Signed-off-by: Shaopeng He <shaopeng.he@intel.com>
> > ---
> >  drivers/net/fm10k/fm10k.h        |  3 +-
> >  drivers/net/fm10k/fm10k_ethdev.c | 90
> > ++++++++++++++++++++++++++++++++++++----
> >  2 files changed, 85 insertions(+), 8 deletions(-)
>=20
> ...
>=20
> > ;
> > +
> > +	fm10k_mbx_lock(hw);
> > +	i =3D 0;
> > +	for (j =3D 0; j < FM10K_VFTA_SIZE; j++) {
> > +		if (macvlan->vfta[j]) {
> > +			for (k =3D 0; k < FM10K_UINT32_BIT_SIZE; k++) {
> > +				if (macvlan->vfta[j] & (1 << k)) {
> > +					if (i + 1 > macvlan->vlan_num) {
> > +						PMD_INIT_LOG(ERR, "vlan
> number "
> > +								"not match");
> > +						fm10k_mbx_unlock(hw);
> > +						return;
> > +					}
> > +					fm10k_update_uc_addr(hw,
> > +						hw->mac.dglort_map,	mac,
>=20
> Here before 'mac', does it has a incident? if no, please ignore, maybe my=
 mail
> client's issue.
>=20
> Thanks,
> Michael
Thanks for pointing out, will be fixed in next version