From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id A8B295A95 for ; Wed, 10 Jun 2015 08:07:02 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 09 Jun 2015 23:07:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,586,1427785200"; d="scan'208";a="724388644" Received: from kmsmsx152.gar.corp.intel.com ([172.21.73.87]) by fmsmga001.fm.intel.com with ESMTP; 09 Jun 2015 23:07:00 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by KMSMSX152.gar.corp.intel.com (172.21.73.87) with Microsoft SMTP Server (TLS) id 14.3.224.2; Wed, 10 Jun 2015 14:03:02 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.165]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.146]) with mapi id 14.03.0224.002; Wed, 10 Jun 2015 14:03:01 +0800 From: "He, Shaopeng" To: "Qiu, Michael" , "Chen, Jing D" , "dev@dpdk.org" Thread-Topic: [PATCH 3/3] fm10k: update VLAN offload features Thread-Index: AQHQnOAlm5wX4m2UyESob9zYYP874Z2lSahg Date: Wed, 10 Jun 2015 06:03:00 +0000 Message-ID: References: <1433213937-21690-1-git-send-email-shaopeng.he@intel.com> <1433213937-21690-4-git-send-email-shaopeng.he@intel.com> <4341B239C0EFF9468EE453F9E9F4604D016FA28F@shsmsx102.ccr.corp.intel.com> <533710CFB86FA344BFBF2D6802E60286046949A6@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <533710CFB86FA344BFBF2D6802E60286046949A6@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/3] fm10k: update VLAN offload features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jun 2015 06:07:03 -0000 > -----Original Message----- > From: Qiu, Michael > Sent: Tuesday, June 09, 2015 11:41 PM > To: Chen, Jing D; He, Shaopeng; dev@dpdk.org > Subject: Re: [PATCH 3/3] fm10k: update VLAN offload features >=20 > On 2015/6/9 11:27, Chen, Jing D wrote: > > Hi, > > > > > >> -----Original Message----- > >> From: He, Shaopeng > >> Sent: Tuesday, June 02, 2015 10:59 AM > >> To: dev@dpdk.org > >> Cc: Chen, Jing D; Qiu, Michael; He, Shaopeng > >> Subject: [PATCH 3/3] fm10k: update VLAN offload features > >> > >> Fm10k PF/VF does not support QinQ; VLAN strip and filter are always > >> on for PF/VF ports. > >> > >> Signed-off-by: Shaopeng He > >> --- > >> drivers/net/fm10k/fm10k_ethdev.c | 22 ++++++++++++++++++++++ > >> 1 file changed, 22 insertions(+) > >> > >> diff --git a/drivers/net/fm10k/fm10k_ethdev.c > >> b/drivers/net/fm10k/fm10k_ethdev.c > >> index 4f23bf1..9b198a7 100644 > >> --- a/drivers/net/fm10k/fm10k_ethdev.c > >> +++ b/drivers/net/fm10k/fm10k_ethdev.c > >> @@ -884,6 +884,27 @@ fm10k_vlan_filter_set(struct rte_eth_dev *dev, > >> uint16_t vlan_id, int on) > >> return (-EIO); > >> } > >> > >> +static void > >> +fm10k_vlan_offload_set(__rte_unused struct rte_eth_dev *dev, int > >> +mask) { > >> + if (mask & ETH_VLAN_STRIP_MASK) { > >> + if (!dev->data->dev_conf.rxmode.hw_vlan_strip) > >> + PMD_INIT_LOG(ERR, "VLAN stripping is " > >> + "always on in fm10k"); > >> + } > >> + > >> + if (mask & ETH_VLAN_EXTEND_MASK) { > >> + if (dev->data->dev_conf.rxmode.hw_vlan_extend) > >> + PMD_INIT_LOG(ERR, "VLAN QinQ is not " > >> + "supported in fm10k"); > >> + } > >> + > >> + if (mask & ETH_VLAN_FILTER_MASK) { > >> + if (!dev->data->dev_conf.rxmode.hw_vlan_filter) > >> + PMD_INIT_LOG(ERR, "VLAN filter is always on in > >> fm10k"); > >> + } > >> +} > >> + > > Update fm10k_dev_infos_get() to configure above options to expected > values? >=20 > Could it be better to add CRC strip options to expected values by conveni= ent? Thanks for the comments; but this patch is for the VLAN offload, may not be= good place to fix other bugs. By the way, current struct rte_eth_dev_info=20 which fm10k_dev_infos_get() returns does not have=20 any setting for CRC strip options (please correct me if I am wrong).