From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id BBABA8D88 for ; Fri, 25 Sep 2015 11:00:37 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 25 Sep 2015 02:00:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,585,1437462000"; d="scan'208";a="812963759" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 25 Sep 2015 02:00:37 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 25 Sep 2015 02:00:36 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 25 Sep 2015 02:00:35 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.179]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.12]) with mapi id 14.03.0248.002; Fri, 25 Sep 2015 17:00:33 +0800 From: "He, Shaopeng" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 4/5] l3fwd-power: fix a memory leak for non-ip packet Thread-Index: AQHQ92KDrGNHBT//Y0m38bmZhT//r55M5YMQ Date: Fri, 25 Sep 2015 09:00:33 +0000 Message-ID: References: <1443159425-32502-1-git-send-email-shaopeng.he@intel.com> <1443159425-32502-5-git-send-email-shaopeng.he@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 4/5] l3fwd-power: fix a memory leak for non-ip packet X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Sep 2015 09:00:38 -0000 Hi, Pablo > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Friday, September 25, 2015 3:19 PM > To: He, Shaopeng; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 4/5] l3fwd-power: fix a memory leak for > non-ip packet >=20 > Hi Shaopeng, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shaopeng He > > Sent: Friday, September 25, 2015 6:37 AM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH 4/5] l3fwd-power: fix a memory leak for > > non-ip packet > > > > Previous l3fwd-power only processes IP and IPv6 packet, other packet's > > mbuf is not released, and causes a memory leak. > > This patch fixes this issue. >=20 > Is this patch related to the rest of the patchset? Something where fm10k = is > involved? > Because it does not look like. Thanks for the comments. This bug almost happens every time with fm10k when testing this interrupt m= ode.=20 But for other NIC cards, it rarely occurs. It is because of that right now = only fm10k=20 has the switch core, by that, other types of packets sneak into the testing= .=20 I include this bug-fixing in the patch set, hope that people can test this = feature more easily. Thanks, --Shaopeng >=20 > Thanks, > Pablo >=20 > > > > Signed-off-by: Shaopeng He > > --- > > examples/l3fwd-power/main.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd- > power/main.c > > index 8bb88ce..ecdff73 100644 > > --- a/examples/l3fwd-power/main.c > > +++ b/examples/l3fwd-power/main.c > > @@ -714,7 +714,8 @@ l3fwd_simple_forward(struct rte_mbuf *m, uint8_t > > portid, > > /* We don't currently handle IPv6 packets in LPM mode. */ > > rte_pktmbuf_free(m); > > #endif > > - } > > + } else > > + rte_pktmbuf_free(m); > > > > } > > > > -- > > 1.9.3