From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id E7699271 for ; Fri, 21 Sep 2018 10:31:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Sep 2018 01:31:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,284,1534834800"; d="scan'208";a="88100482" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 21 Sep 2018 01:31:13 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 21 Sep 2018 01:31:13 -0700 Received: from lcsmsx153.ger.corp.intel.com (10.186.165.228) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 21 Sep 2018 01:31:13 -0700 Received: from hasmsx105.ger.corp.intel.com ([169.254.1.136]) by LCSMSX153.ger.corp.intel.com ([169.254.8.230]) with mapi id 14.03.0319.002; Fri, 21 Sep 2018 11:31:10 +0300 From: "Stojaczyk, Dariusz" To: "dev@dpdk.org" CC: "Burakov, Anatoly" , "Wodkowski, PawelX" Thread-Topic: [dpdk-dev] [PATCH] eal: fix '--huge-unlink' option Thread-Index: AQHUUYN9ZjMSP1mTUUGdv/MIe+JOOqT6Zl9w Date: Fri, 21 Sep 2018 08:31:09 +0000 Message-ID: References: <1537530998-109749-1-git-send-email-pawelx.wodkowski@intel.com> In-Reply-To: <1537530998-109749-1-git-send-email-pawelx.wodkowski@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmNiZDE2YzctZjMxYy00ZTQwLTg3YjctZTZmYTRhNTIxOWU0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQU5uaWVjaU1ITmw3NHBmcUdDdWtCdGhMakRGUnErYTZcLzJ3cVJkVXNlQWtxOUlDS1RJYnZyRkVib1NDVDQzdTUifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.102.11.49] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] eal: fix '--huge-unlink' option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2018 08:31:21 -0000 I'd like to point out that the comments inside eal_memory.c are outdated (e= .g. the one from line #249). It makes it difficult to review this patch. > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pawel Wodkowski > Sent: Friday, September 21, 2018 1:57 PM > To: dev@dpdk.org > Cc: Wodkowski, PawelX > Subject: [dpdk-dev] [PATCH] eal: fix '--huge-unlink' option >=20 > The final_va field is set during remap_segment() but this information is = not > propagated to temporal copy of huge page memory configuration so the > unlink_hugepage_files() function wrongly assume that there is nothing to > unlink. Fix this issue by checking orig_va instead of final_va. >=20 > Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists") > To: Anatoly Burakov >=20 > Signed-off-by: Pawel Wodkowski